public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <ajones@ventanamicro.com>
To: Atish Patra <atishp@rivosinc.com>
Cc: linux-kernel@vger.kernel.org,
	"Clément Léger" <cleger@rivosinc.com>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Anup Patel" <anup@brainfault.org>,
	"Ajay Kaher" <ajay.kaher@broadcom.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alexghiti@rivosinc.com>,
	"Alexey Makhalov" <alexey.amakhalov@broadcom.com>,
	"Atish Patra" <atishp@atishpatra.org>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Juergen Gross" <jgross@suse.com>,
	kvm-riscv@lists.infradead.org, kvm@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Shuah Khan" <shuah@kernel.org>,
	virtualization@lists.linux.dev, "Will Deacon" <will@kernel.org>,
	x86@kernel.org
Subject: Re: [PATCH v6 01/24] RISC-V: Fix the typo in Scountovf CSR name
Date: Mon, 15 Apr 2024 15:01:42 +0200	[thread overview]
Message-ID: <20240415-b899e62329c901f59db9f146@orel> (raw)
In-Reply-To: <20240411000752.955910-2-atishp@rivosinc.com>

On Wed, Apr 10, 2024 at 05:07:29PM -0700, Atish Patra wrote:
> The counter overflow CSR name is "scountovf" not "sscountovf".
> 
> Fix the csr name.
> 
> Fixes: 4905ec2fb7e6 ("RISC-V: Add sscofpmf extension support")
> Reviewed-by: Clément Léger <cleger@rivosinc.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Reviewed-by: Anup Patel <anup@brainfault.org>
> Signed-off-by: Atish Patra <atishp@rivosinc.com>
> ---
>  arch/riscv/include/asm/csr.h | 2 +-
>  drivers/perf/riscv_pmu_sbi.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/riscv/include/asm/csr.h b/arch/riscv/include/asm/csr.h
> index 2468c55933cd..9d1b07932794 100644
> --- a/arch/riscv/include/asm/csr.h
> +++ b/arch/riscv/include/asm/csr.h
> @@ -281,7 +281,7 @@
>  #define CSR_HPMCOUNTER30H	0xc9e
>  #define CSR_HPMCOUNTER31H	0xc9f
>  
> -#define CSR_SSCOUNTOVF		0xda0
> +#define CSR_SCOUNTOVF		0xda0
>  
>  #define CSR_SSTATUS		0x100
>  #define CSR_SIE			0x104
> diff --git a/drivers/perf/riscv_pmu_sbi.c b/drivers/perf/riscv_pmu_sbi.c
> index 8cbe6e5f9c39..3e44d2fb8bf8 100644
> --- a/drivers/perf/riscv_pmu_sbi.c
> +++ b/drivers/perf/riscv_pmu_sbi.c
> @@ -27,7 +27,7 @@
>  
>  #define ALT_SBI_PMU_OVERFLOW(__ovl)					\
>  asm volatile(ALTERNATIVE_2(						\
> -	"csrr %0, " __stringify(CSR_SSCOUNTOVF),			\
> +	"csrr %0, " __stringify(CSR_SCOUNTOVF),				\
>  	"csrr %0, " __stringify(THEAD_C9XX_CSR_SCOUNTEROF),		\
>  		THEAD_VENDOR_ID, ERRATA_THEAD_PMU,			\
>  		CONFIG_ERRATA_THEAD_PMU,				\
> -- 
> 2.34.1
>

Reviewed-by: Andrew Jones <ajones@ventanamicro.com>

  reply	other threads:[~2024-04-15 13:01 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11  0:07 [PATCH v6 00/24] RISC-V SBI v2.0 PMU improvements and Perf sampling in KVM guest Atish Patra
2024-04-11  0:07 ` [PATCH v6 01/24] RISC-V: Fix the typo in Scountovf CSR name Atish Patra
2024-04-15 13:01   ` Andrew Jones [this message]
2024-04-11  0:07 ` [PATCH v6 02/24] RISC-V: Add FIRMWARE_READ_HI definition Atish Patra
2024-04-11  0:07 ` [PATCH v6 03/24] drivers/perf: riscv: Read upper bits of a firmware counter Atish Patra
2024-04-11  0:07 ` [PATCH v6 04/24] drivers/perf: riscv: Use BIT macro for shifting operations Atish Patra
2024-04-11  0:07 ` [PATCH v6 05/24] RISC-V: Add SBI PMU snapshot definitions Atish Patra
2024-04-11  0:07 ` [PATCH v6 06/24] RISC-V: KVM: Rename the SBI_STA_SHMEM_DISABLE to a generic name Atish Patra
2024-04-11  0:07 ` [PATCH v6 07/24] RISC-V: Use the minor version mask while computing sbi version Atish Patra
2024-04-15 13:06   ` Andrew Jones
2024-04-16  8:31     ` Atish Patra
2024-04-16  8:49       ` Andrew Jones
2024-04-11  0:07 ` [PATCH v6 08/24] drivers/perf: riscv: Implement SBI PMU snapshot function Atish Patra
2024-04-15 13:15   ` Andrew Jones
2024-04-16  8:33     ` Atish Patra
2024-04-11  0:07 ` [PATCH v6 09/24] drivers/perf: riscv: Fix counter mask iteration for RV32 Atish Patra
2024-04-11  0:07 ` [PATCH v6 10/24] RISC-V: KVM: Fix the initial sample period value Atish Patra
2024-04-11  0:07 ` [PATCH v6 11/24] RISC-V: KVM: No need to update the counter value during reset Atish Patra
2024-04-11  0:07 ` [PATCH v6 12/24] RISC-V: KVM: No need to exit to the user space if perf event failed Atish Patra
2024-04-11  0:07 ` [PATCH v6 13/24] RISC-V: KVM: Implement SBI PMU Snapshot feature Atish Patra
2024-04-15 13:19   ` Andrew Jones
2024-04-11  0:07 ` [PATCH v6 14/24] RISC-V: KVM: Add perf sampling support for guests Atish Patra
2024-04-15 13:23   ` Andrew Jones
2024-04-11  0:07 ` [PATCH v6 15/24] RISC-V: KVM: Support 64 bit firmware counters on RV32 Atish Patra
2024-04-11  0:07 ` [PATCH v6 16/24] RISC-V: KVM: Improve firmware counter read function Atish Patra
2024-04-11  0:07 ` [PATCH v6 17/24] KVM: riscv: selftests: Move sbi definitions to its own header file Atish Patra
2024-04-11  0:07 ` [PATCH v6 18/24] KVM: riscv: selftests: Add helper functions for extension checks Atish Patra
2024-04-11  0:07 ` [PATCH v6 19/24] KVM: riscv: selftests: Add Sscofpmf to get-reg-list test Atish Patra
2024-04-11  0:07 ` [PATCH v6 20/24] KVM: riscv: selftests: Add SBI PMU extension definitions Atish Patra
2024-04-11  0:07 ` [PATCH v6 21/24] KVM: riscv: selftests: Add SBI PMU selftest Atish Patra
2024-04-15 13:31   ` Andrew Jones
2024-04-11  0:07 ` [PATCH v6 22/24] KVM: riscv: selftests: Add a test for PMU snapshot functionality Atish Patra
2024-04-15 13:32   ` Andrew Jones
2024-04-11  0:07 ` [PATCH v6 23/24] KVM: riscv: selftests: Add a test for counter overflow Atish Patra
2024-04-15 13:36   ` Andrew Jones
2024-04-11  0:07 ` [PATCH v6 24/24] KVM: riscv: selftests: Add commandline option for SBI PMU test Atish Patra
2024-04-15 13:43   ` Andrew Jones
2024-04-16  8:49     ` Atish Patra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240415-b899e62329c901f59db9f146@orel \
    --to=ajones@ventanamicro.com \
    --cc=ajay.kaher@broadcom.com \
    --cc=alexey.amakhalov@broadcom.com \
    --cc=alexghiti@rivosinc.com \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=atishp@atishpatra.org \
    --cc=atishp@rivosinc.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=cleger@rivosinc.com \
    --cc=conor.dooley@microchip.com \
    --cc=jgross@suse.com \
    --cc=kvm-riscv@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=pbonzini@redhat.com \
    --cc=shuah@kernel.org \
    --cc=virtualization@lists.linux.dev \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox