Re: [PATCH v1] LoongArch/tlb: fix "error: parameter 'ptep' set but not used" due to __tlb_remove_tlb_entry()

Huacai Chen
2024-04-18T03:03:26Z

Hi, Andrew,

On Thu, Apr 18, 2024 at 4:58 AM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Wed, 17 Apr 2024 11:18:27 +0800 Huacai Chen <chenhuacai@kernel.org> wrote:
>
> > On Wed, Apr 17, 2024 at 3:25 AM Miguel Ojeda
> > <miguel.ojeda.sandonis@gmail.com> wrote:
> > >
> > > On Tue, Apr 16, 2024 at 4:49 PM David Hildenbrand <david@redhat.com> wrote:
> > > >
> > > > With LLVM=1 and W=1 we get:
> > >
> > > Hmm... I didn't need W=1 to trigger it (LLVM 18.1.2).
> > >
> > > > Reported-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
> > >
> > > Thanks, looks good to me -- built-tested:
> > >
> > > Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
> > > Tested-by: Miguel Ojeda <ojeda@kernel.org>
> > >
> >
> > Queued for loongarch-fixes, thanks.
> >
>
> (top-posting repaired so I can sensibly reply to this. Please avoid
> top-posting!)
Sorry, I only top-posting with "Queued ...", "Applied ..." because I
saw others do like this. If this is also unacceptable, I will not do
it again.

>
> I'd rather carry this in mm.git with your ack please. Otherwise mm.git
> won't compile without it and if I retain this patch we'll get
> duplicate-patch emails from Stephen and I won't be able to merge
> mm.git's mm-nonmm-stable tree into Linus until loongarch-fixes has
> merged.
loongarch-next always merges loongarch-fixes, so when I apply a patch
it will be in linux-next. Now this patch I have already applied to
loongarch-fixes and loongarch-next. In future, I will give an Acked-by
for you if needed.

Huacai

>
>