Re: [PATCH v4 02/11] riscv: add ISA extensions validation

Conor Dooley
2024-05-15T15:47:07Z

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

On Wed, May 15, 2024 at 03:26:23PM +0200, Clément Léger wrote:
> > This function is badly in need of some new variable names for the first
> > two parameters. It's hard to follow what each of them is meant to be
> > once you're inside this function and removed from their definitions.
> > The first parameter is the source bitmap that we've already filled from
> > the dt/acpi scan of that hart and the second is the per-hart data
> > structure that we're gonna assign it to and keep "forever", I think the
> > naming should reflect that.
>
> Yeah, wasn't sure of the naming at all. Would you be ok with the following:
>
> - source_isa: Input ISA bitmap parsed from ISA string (DT/ACPI)
> - resolved_isa: Output ISA bitmap resolved from the first one
> (configuration and extension dependencies matching).
>
> Since I'm a non-native english speaker, I'm not sure at all if it
> correctly means what they do, feel free to tell me if you have some
> better options.

I think those are fine, thanks.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]