From: Nicholas Piggin <npiggin@gmail.com>
To: Thomas Huth <thuth@redhat.com>, Andrew Jones <andrew.jones@linux.dev>
Cc: Nicholas Piggin <npiggin@gmail.com>, kvm@vger.kernel.org
Subject: [kvm-unit-tests PATCH 1/2] shellcheck: Fix shellcheck target with out of tree build
Date: Fri, 3 May 2024 15:25:06 +1000 [thread overview]
Message-ID: <20240503052510.968229-2-npiggin@gmail.com> (raw)
In-Reply-To: <20240503052510.968229-1-npiggin@gmail.com>
Prepend source directory to script names, and include source directory
in shellcheck search path.
Fixes: ddfdcc3929aef ("Add initial shellcheck checking")
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 6240d8dfa..b0f7ad08b 100644
--- a/Makefile
+++ b/Makefile
@@ -143,7 +143,7 @@ cscope:
.PHONY: shellcheck
shellcheck:
- shellcheck -a run_tests.sh */run */efi/run scripts/mkstandalone.sh
+ shellcheck -P $(SRCDIR) -a $(SRCDIR)/run_tests.sh $(SRCDIR)/*/run $(SRCDIR)/*/efi/run $(SRCDIR)/scripts/mkstandalone.sh
.PHONY: tags
tags:
--
2.43.0
next prev parent reply other threads:[~2024-05-03 5:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 5:25 [kvm-unit-tests PATCH 0/2] shellcheck: post-merge fixups Nicholas Piggin
2024-05-03 5:25 ` Nicholas Piggin [this message]
2024-05-03 6:31 ` [kvm-unit-tests PATCH 1/2] shellcheck: Fix shellcheck target with out of tree build Thomas Huth
2024-05-03 5:25 ` [kvm-unit-tests PATCH 2/2] shellcheck: Suppress SC2209 quoting warning in config.mak Nicholas Piggin
2024-05-03 6:31 ` Thomas Huth
2024-05-03 6:35 ` [kvm-unit-tests PATCH 0/2] shellcheck: post-merge fixups Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240503052510.968229-2-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=andrew.jones@linux.dev \
--cc=kvm@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox