From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6917B3EA72 for ; Sat, 18 May 2024 17:18:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716052734; cv=none; b=so0JrKzK/IeXT/nrgEBXYKtJDrAGpDvHoIkgGbcyd8lwqT7c3mf8Zrxq9hUpKBB7tV5QK6FXa1hMpHhedh6R5qqHrSBN1gJ5AcoIdgEDD7l7xvJ56Wl0IKMnqEh2F2rmJbyYPM/sGmrs4sjSashPWkLFmt+uQxQIEmH/s4fVosg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716052734; c=relaxed/simple; bh=//8QV5TSiMfT14T+L5Dni8yVPWQI23EOE8lPHpMRkQs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A/i/iBBxhvIFCW7oEiqrIKOa5B/Bgpu1P3oCOTGdwGghOYb2TO05jdMizYsv484oM63k6Qz0REKz/mJ0W4cZV8TSb+qGZZQrPEsyBq/1k+i91gTSZM1HDZcpUt0nZlMrhZtiilIlbXuGVDPtGGIy+mBTS0mv3klCGf+UEMfTG5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=kXqEraIZ; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kXqEraIZ" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1e651a9f3ffso37105575ad.1 for ; Sat, 18 May 2024 10:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1716052733; x=1716657533; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bI35mSpFGv5azuf3W34PAy5g+Nwe9xTUDOP2VBYb+qw=; b=kXqEraIZ6NRVqMoPc0XrmoY067N4ScbAVOsLwYbSycFL0/svhHlr4+DYb/ikiNC0+p l2J2GV/r5CyfCG0UDyAlruILjI4SovVpfIduxOzbCgjRMmy7EPbrky4YoAvSJuPsDTQh 2f9gIQZSvhg77F3CmfGNJa86Xk9TbNo+Z/rq4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716052733; x=1716657533; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bI35mSpFGv5azuf3W34PAy5g+Nwe9xTUDOP2VBYb+qw=; b=ljjskYwrWCUauZhAtck900KRwSAMLDip4LQ8kXg/9Ino/sA1SaofgVR5Wqc53l9Kkz 31YCpK898XrK3xG+va3/n2XtrgqSprihi3cU82CGL9v/g8K3RKO/FFJbAvcx/7QRlxZY 1KcpH8j3z5+6IxVmZxvva5HgabRHGE0VE+GB9hWE1Br8Hft634G1akIdgZPjjD8Fl3Ye ZTknMePWjGOk+na3TUy6f616NP9Ob8IQ8JHIzyK2EOUz04yEbUGjwtE/DeP+5EFvB82p go3o8vFTc4zjeo0wASH49zT67VvipiDFcRVgrV6N7/zZ+1hvvfmtLlqObtuMCAENuz5E PKag== X-Forwarded-Encrypted: i=1; AJvYcCU4BbF8C8fFMxoYeN/F1cwwWk5W7pjmOz1xtPbEbovs8FjEAuse+za+Snme0rHyH3unz2oF4pZm0ggovA53DJha8Qsb X-Gm-Message-State: AOJu0YzJ0prYjtBwnGN7+wmdnO9Y48g4ApC3n3AFX6O0T6B9ttRm382m qsSJlJRAyAr/8qUQb9IksqM+lQvt15cOUwTYmKfxw0pdydTmUrWSUP/+1t8Ufw== X-Google-Smtp-Source: AGHT+IHnTm7HxB1ifDLOfll4lXfhQucVtONb5bXh+in0GA9Emo8PEiZzBgcOx9HwsOaXGa4JlF1tXg== X-Received: by 2002:a05:6a20:5602:b0:1af:cbd3:ab4d with SMTP id adf61e73a8af0-1afde120e4dmr22666060637.33.1716052732590; Sat, 18 May 2024 10:18:52 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4fff45ce3sm11294743b3a.197.2024.05.18.10.18.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 May 2024 10:18:51 -0700 (PDT) Date: Sat, 18 May 2024 10:18:50 -0700 From: Kees Cook To: Masahiro Yamada Cc: Andy Lutomirski , Will Drewry , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Belloni , Benjamin Tissoires , Christian Borntraeger , Claudio Imbrenda , David Hildenbrand , Janosch Frank , Jiri Kosina , Shuah Khan , bpf@vger.kernel.org, kvm@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH 1/2] selftests: harness: remove unneeded __constructor_order_last() Message-ID: <202405181014.B84D979BA@keescook> References: <20240517114506.1259203-1-masahiroy@kernel.org> <20240517114506.1259203-2-masahiroy@kernel.org> <202405171621.A178606D8@keescook> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, May 18, 2024 at 12:29:00PM +0900, Masahiro Yamada wrote: > It will be set to "true" eventually, > but __LIST_APPEND() still sees "false" > on backward-order systems. Ah, yes -- you are right. I looked through the commit history (I had to go back to when the seccomp test, and the harness, was out of tree). There was a time when the logic happened during the list walking, rather than during list _creation_. I was remembering the former. So, yes, let's make this change. As you say, it also solves for defining TEST_HARNESS_MAIN before the tests. Thank you! I'd still like to replace all the open-coded TEST_HARNESS_MAIN calls, though. -- Kees Cook