Re: [PATCH v9 05/24] virt: sev-guest: Fix user-visible strings

Nikunj A. Dadhania
2024-06-19T05:58:18Z

On 6/19/2024 2:41 AM, Tom Lendacky wrote:
> On 5/30/24 23:30, Nikunj A Dadhania wrote:
>> User-visible abbreviations should be in capitals, ensure messages are
>> readable and clear.
>>
>> No functional change.
>>
>> Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
>> ---
>> drivers/virt/coco/sev-guest/sev-guest.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c
>> index b6be676f82be..5c0cbdad9fa2 100644
>> --- a/drivers/virt/coco/sev-guest/sev-guest.c
>> +++ b/drivers/virt/coco/sev-guest/sev-guest.c
>> @@ -95,7 +95,7 @@ static bool is_vmpck_empty(struct snp_guest_dev *snp_dev)
>> */
>> static void snp_disable_vmpck(struct snp_guest_dev *snp_dev)
>> {
>> - dev_alert(snp_dev->dev, "Disabling vmpck_id %d to prevent IV reuse.\n",
>> + dev_alert(snp_dev->dev, "Disabling VMPCK%d to prevent IV reuse.\n",
>
> You use "communication key" after each VMPCK%d below. I prefer this
> shorter notation, but whichever way it goes, they should all be the same.

No particular preference, I had added "communication key" from more clarity to user
strings. I will add the same to the above string as well.

Regards
Nikunj