Re: [PATCH v9 04/24] virt: sev-guest: Add SNP guest request structure

Tom Lendacky
2024-06-18T21:06:51Z

On 5/30/24 23:30, Nikunj A Dadhania wrote:
> Add a snp_guest_req structure to simplify the function arguments. This
> structure will be used to call the SNP Guest message request API instead
> of passing a long list of parameters.
>
> Update the snp_issue_guest_request() prototype to include the new guest
> request structure and move all the sev-guest.h header content to sev.h.
>
> Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>

Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
> arch/x86/include/asm/sev.h | 78 ++++++++++-
> drivers/virt/coco/sev-guest/sev-guest.h | 69 ----------
> arch/x86/kernel/sev.c | 15 ++-
> drivers/virt/coco/sev-guest/sev-guest.c | 169 +++++++++++++-----------
> 4 files changed, 177 insertions(+), 154 deletions(-)
> delete mode 100644 drivers/virt/coco/sev-guest/sev-guest.h
>