From: Nicholas Piggin <npiggin@gmail.com>
To: linux-s390@vger.kernel.org
Cc: "Nicholas Piggin" <npiggin@gmail.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Claudio Imbrenda" <imbrenda@linux.ibm.com>,
"Nico Böhr" <nrb@linux.ibm.com>,
"David Hildenbrand" <david@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
kvm@vger.kernel.org
Subject: [kvm-unit-tests PATCH 1/2] s390x: Only run genprotimg if necessary
Date: Sun, 2 Jun 2024 23:06:55 +1000 [thread overview]
Message-ID: <20240602130656.120866-2-npiggin@gmail.com> (raw)
In-Reply-To: <20240602130656.120866-1-npiggin@gmail.com>
genprotimg is not required if the --host-key-document= configure option
is not specified, so avoid running it in that case. This prevents the
build message:
bash: line 1: genprotimg: command not found
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
s390x/Makefile | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/s390x/Makefile b/s390x/Makefile
index 19c41a2ec..c6518bbd1 100644
--- a/s390x/Makefile
+++ b/s390x/Makefile
@@ -213,12 +213,16 @@ $(comm-key):
# The genprotimg arguments for the cck changed over time so we need to
# figure out which argument to use in order to set the cck
+ifneq ($(HOST_KEY_DOCUMENT),)
GENPROTIMG_HAS_COMM_KEY = $(shell $(GENPROTIMG) --help | grep -q -- --comm-key && echo yes)
ifeq ($(GENPROTIMG_HAS_COMM_KEY),yes)
GENPROTIMG_COMM_OPTION := --comm-key
else
GENPROTIMG_COMM_OPTION := --x-comm-key
endif
+else
+GENPROTIMG_HAS_COMM_KEY =
+endif
ifeq ($(CONFIG_DUMP),yes)
# allow dumping + PCKMO
--
2.43.0
next prev parent reply other threads:[~2024-06-02 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-02 13:06 [kvm-unit-tests PATCH 0/2] s390x: Fix build error messages Nicholas Piggin
2024-06-02 13:06 ` Nicholas Piggin [this message]
2024-06-03 11:54 ` [kvm-unit-tests PATCH 1/2] s390x: Only run genprotimg if necessary Janosch Frank
2024-06-04 5:18 ` Nicholas Piggin
2024-06-02 13:06 ` [kvm-unit-tests PATCH 2/2] s390x: Specify program headers with flags to avoid linker warnings Nicholas Piggin
2024-06-04 5:32 ` [kvm-unit-tests PATCH 0/2] s390x: Fix build error messages Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240602130656.120866-2-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox