From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6C2B15445E for ; Fri, 7 Jun 2024 21:34:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717796053; cv=none; b=KN9gcKyCguyCWgGNzwi9G7GShO639mFaEVZEyKkZB8qXubE0KClm1UlPttkvH5Hev3zkd+8NledowUSFmDCu1sJMA1dU7N2DJ5zQsBCcXrjjuBvBTQDZDhBJWoDU0YRlR0iHHWpQK/al5dUEZys4bznRycUA5G7Y4cCpdxKtJBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717796053; c=relaxed/simple; bh=cYsT0tM9d4orTtOiW3/EAkmjNwaChdXp7xaUoORONng=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=X8jrmXLxyVFO94gyAzd6l5Y+IhIcnrQdTI7nSi8m670BUoWkSWpIRWugWUtr1v7Yd87Q/nWE5flEZynWE1aJNnE5DvYhCb96LgacU7Tlmq81Mtii3Tbq0MoiGdh2tbCNycztKvVK3i4oM+JdafD07UEGTjBSOW6iV+pZlz3m/C4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EXTAE7gI; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EXTAE7gI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717796050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ks6Mblf6LFbqf1AYdlbF1eql1nbrqV8sks5KKNLnj54=; b=EXTAE7gIHAmv3Jb1vT4O5FuaAIaNbZ/zviEH5Jhhzoz7pQY5b0t8AdOuFZYzdvxkaI1MOr ACba5fhTQKMrSq5jMAN9Tq4qwpAw+w7ORiv1EgTgCGHL65HjEx0qq6zOoEIR9glJb9zc73 sreB6ADZjRtqlWQ04gOaQoJuNatObNs= Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-586-yziLTBfkO86xw4HWQE8TMw-1; Fri, 07 Jun 2024 17:34:09 -0400 X-MC-Unique: yziLTBfkO86xw4HWQE8TMw-1 Received: by mail-io1-f69.google.com with SMTP id ca18e2360f4ac-7e1fe2ba2e1so303679439f.3 for ; Fri, 07 Jun 2024 14:34:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717796048; x=1718400848; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ks6Mblf6LFbqf1AYdlbF1eql1nbrqV8sks5KKNLnj54=; b=T5tr7/G0Xjku/tTFBrhXBqgJtw+jyOz/tg4YXPNSro21F7cV7Jky19jleFUm5QCBFA p1uFljTKaE9PnFCOZWhOpeS80wpLtlJlfqDcor+frG+vpMJA8sA62L3v14uccqW9C83s enNo6VzANQ/iXnvKafajDgrGLXbboXBqk2MTyMJEAJeK1pIAh45ciz247Tp9MACJ4fo7 xfYoZzxz+q6buO9y9cEtJm0ygCMn2ZQjRQKaKA+oJH9HkGUAaI48a3r/+qpO0LBuEECi hGpACzLOBEd33AQpBBu3pI38BqAnfQkZDxa/C8Wl4aU1SOQew+1AF5hjvo/gpxKzWaYH +tgw== X-Forwarded-Encrypted: i=1; AJvYcCX43KUgLl+tgYEvnYBeoCxvYe126nmHx16/idwkFkwssUgvTdpQzlwfeWbT8tLgwTnzQojapod8/xAs+ArSuQAHZxa0 X-Gm-Message-State: AOJu0YzTTu34RphB8DBq0wmjC1X19WWsmGsrQwhg6ippx8NOi/7UF35k 3kGdJb4EHfhas2OWUwZjgKzhcbwMB4v1c8eQYygvQvNEYIXhQG3RSnFNLs4mqHtlTG1ewtMr3l6 28HGCzDPi8A/098IPr0oDOWxPybYb2tvKDEmXuthts+WPII0I1A== X-Received: by 2002:a05:6602:3f94:b0:7e1:79e8:d671 with SMTP id ca18e2360f4ac-7eb5724adc6mr458171139f.14.1717796048606; Fri, 07 Jun 2024 14:34:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHO0WMUh0lNCHTe8ZHkKnWOcJw/B79V9jbHlRGWij/etIT/6UowckVzjO7CWnh2PMVwyJPhdA== X-Received: by 2002:a05:6602:3f94:b0:7e1:79e8:d671 with SMTP id ca18e2360f4ac-7eb5724adc6mr458168939f.14.1717796048181; Fri, 07 Jun 2024 14:34:08 -0700 (PDT) Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4b7a2244a77sm1055724173.40.2024.06.07.14.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 14:34:07 -0700 (PDT) Date: Fri, 7 Jun 2024 15:34:06 -0600 From: Alex Williamson To: "Zeng, Xin" Cc: "Tian, Kevin" , Arnd Bergmann , Jason Gunthorpe , "Yishai Hadas" , Shameer Kolothum , "Cao, Yahui" , "Cabiddu, Giovanni" , "kvm@vger.kernel.org" , qat-linux , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] vfio/qat: add PCI_IOV dependency Message-ID: <20240607153406.60355e6c.alex.williamson@redhat.com> In-Reply-To: References: <20240528120501.3382554-1-arnd@kernel.org> Organization: Red Hat Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 31 May 2024 02:56:09 +0000 "Zeng, Xin" wrote: > On Wednesday, May 29, 2024 1:36 PM, Tian, Kevin wrote: > > To: Zeng, Xin ; Arnd Bergmann ; > > Cabiddu, Giovanni ; Alex Williamson > > ; Cao, Yahui > > Cc: Arnd Bergmann ; Jason Gunthorpe ; > > Yishai Hadas ; Shameer Kolothum > > ; kvm@vger.kernel.org; qat- > > linux ; linux-kernel@vger.kernel.org > > Subject: RE: [PATCH] vfio/qat: add PCI_IOV dependency > > > > > From: Zeng, Xin > > > Sent: Wednesday, May 29, 2024 11:11 AM > > > > > > On Wednesday, May 29, 2024 10:25 AM, Tian, Kevin > > > > To: Arnd Bergmann ; Zeng, Xin ; > > > > Cabiddu, Giovanni ; Alex Williamson > > > > ; Cao, Yahui > > > > Cc: Arnd Bergmann ; Jason Gunthorpe ; > > > > Yishai Hadas ; Shameer Kolothum > > > > ; kvm@vger.kernel.org; qat- > > > > linux ; linux-kernel@vger.kernel.org > > > > Subject: RE: [PATCH] vfio/qat: add PCI_IOV dependency > > > > > > > > > From: Arnd Bergmann > > > > > Sent: Tuesday, May 28, 2024 8:05 PM > > > > > > > > > > From: Arnd Bergmann > > > > > > > > > > The newly added driver depends on the crypto driver, but it uses > > > exported > > > > > symbols that are only available when IOV is also turned on: > > > > > > > > at a glance those undefined symbols don't use any symbol under > > > > IOV. They are just wrappers to certain callbacks registered by > > > > by respective qat drivers which support migration. > > > > > > > > Probably they'd better be moved out of CONFIG_PCI_IOV in > > > > "drivers/crypto/intel/qat/qat_common/Makefile" to remove > > > > this dependency in vfio variant driver. > > > > > > > > > > Thanks, Kevin :-). This dependency is like the relationship between the QAT > > > vfio > > > variant driver and macro CRYPTO_DEV_QAT_4XXX. The variant driver > > doesn't > > > directly reference the symbols exported by module qat_4xxx which is > > > protected > > > by CRYPTO_DEV_QAT_4XXX, but requires the module qat_4xxx at runtime > > so > > > far. > > > Alex suggested to put CRYPTO_DEV_QAT_4XXX as the dependency of this > > > variant > > > driver. > > > For CONFIG_PCI_IOV, if it is disabled, this variant driver doesn't serve the > > > user as > > > well since no VFs will be created by QAT PF driver. To keep the consistency, > > it > > > might > > > be right to make it as the dependency of this variant driver as Arnd pointed > > > out. > > > What do you think? > > > > > > > Following this rationale then we need also make PCI_IOV a dependency > > for mlx5 and hisilicon given they are for VF migration too? > > After more thoughts about this, I would agree with your first point that > PCI_IOV should not be the dependency of the variant driver if we consider > passthrough VFs in a nested virtualized environment. > So decoupling PCI_IOV from migration helpers in QAT PF driver sounds a > better option. Is this then being taken care of in the QAT PF driver? Are there patches posted targeting v6.10? Is there an archive of qat-linux list somewhere? I can't find any relevant postings on linux-crypto@vger and can't find a public archive of qat-linux(??). Thanks, Alex