From: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
To: "Claudio Imbrenda" <imbrenda@linux.ibm.com>,
"Nina Schoetterl-Glausch" <nsg@linux.ibm.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Nico Böhr" <nrb@linux.ibm.com>, "Thomas Huth" <thuth@redhat.com>
Cc: Andrew Jones <andrew.jones@linux.dev>,
kvm@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
linux-s390@vger.kernel.org, David Hildenbrand <david@redhat.com>
Subject: [kvm-unit-tests PATCH v3 6/7] s390x: Use library functions for snippet exit
Date: Thu, 20 Jun 2024 16:16:59 +0200 [thread overview]
Message-ID: <20240620141700.4124157-7-nsg@linux.ibm.com> (raw)
In-Reply-To: <20240620141700.4124157-1-nsg@linux.ibm.com>
Replace the existing code for exiting from snippets with the newly
introduced library functionality.
Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
---
s390x/sie-dat.c | 11 +++--------
s390x/snippets/c/sie-dat.c | 19 +------------------
2 files changed, 4 insertions(+), 26 deletions(-)
diff --git a/s390x/sie-dat.c b/s390x/sie-dat.c
index 9e60f26e..c8f38220 100644
--- a/s390x/sie-dat.c
+++ b/s390x/sie-dat.c
@@ -27,23 +27,18 @@ static void test_sie_dat(void)
uint64_t test_page_gpa, test_page_hpa;
uint8_t *test_page_hva, expected_val;
bool contents_match;
- uint8_t r1;
/* guest will tell us the guest physical address of the test buffer */
sie(&vm);
- assert(vm.sblk->icptcode == ICPT_INST &&
- (vm.sblk->ipa & 0xff00) == 0x8300 && vm.sblk->ipb == 0x9c0000);
-
- r1 = (vm.sblk->ipa & 0xf0) >> 4;
- test_page_gpa = vm.save_area.guest.grs[r1];
+ assert(snippet_is_force_exit_value(&vm));
+ test_page_gpa = snippet_get_force_exit_value(&vm);
test_page_hpa = virt_to_pte_phys(guest_root, (void*)test_page_gpa);
test_page_hva = __va(test_page_hpa);
report_info("test buffer gpa=0x%lx hva=%p", test_page_gpa, test_page_hva);
/* guest will now write to the test buffer and we verify the contents */
sie(&vm);
- assert(vm.sblk->icptcode == ICPT_INST &&
- vm.sblk->ipa == 0x8300 && vm.sblk->ipb == 0x440000);
+ assert(snippet_is_force_exit(&vm));
contents_match = true;
for (unsigned int i = 0; i < GUEST_TEST_PAGE_COUNT; i++) {
diff --git a/s390x/snippets/c/sie-dat.c b/s390x/snippets/c/sie-dat.c
index 9d89801d..26f045b1 100644
--- a/s390x/snippets/c/sie-dat.c
+++ b/s390x/snippets/c/sie-dat.c
@@ -10,28 +10,11 @@
#include <libcflat.h>
#include <asm-generic/page.h>
#include <asm/mem.h>
+#include <snippet-guest.h>
#include "sie-dat.h"
static uint8_t test_pages[GUEST_TEST_PAGE_COUNT * PAGE_SIZE] __attribute__((__aligned__(PAGE_SIZE)));
-static inline void force_exit(void)
-{
- asm volatile("diag 0,0,0x44\n"
- :
- :
- : "memory"
- );
-}
-
-static inline void force_exit_value(uint64_t val)
-{
- asm volatile("diag %[val],0,0x9c\n"
- :
- : [val] "d"(val)
- : "memory"
- );
-}
-
int main(void)
{
uint8_t *invalid_ptr;
--
2.44.0
next prev parent reply other threads:[~2024-06-20 14:17 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 14:16 [kvm-unit-tests PATCH v3 0/7] s390x: STFLE nested interpretation Nina Schoetterl-Glausch
2024-06-20 14:16 ` [kvm-unit-tests PATCH v3 1/7] lib: Add pseudo random functions Nina Schoetterl-Glausch
2024-06-25 3:08 ` Nicholas Piggin
2024-06-25 7:06 ` Nina Schoetterl-Glausch
2024-08-12 14:17 ` Andrew Jones
2024-10-10 8:25 ` Nico Boehr
2024-10-10 8:37 ` Andrew Jones
2024-06-20 14:16 ` [kvm-unit-tests PATCH v3 2/7] s390x: lib: Remove double include Nina Schoetterl-Glausch
2024-06-21 6:58 ` Janosch Frank
2024-06-20 14:16 ` [kvm-unit-tests PATCH v3 3/7] s390x: Add sie_is_pv Nina Schoetterl-Glausch
2024-06-20 16:41 ` Claudio Imbrenda
2024-06-21 6:59 ` Janosch Frank
2024-06-25 1:58 ` Nicholas Piggin
2024-06-20 14:16 ` [kvm-unit-tests PATCH v3 4/7] s390x: Add function for checking diagnose intercepts Nina Schoetterl-Glausch
2024-06-20 16:47 ` Claudio Imbrenda
2024-06-20 17:46 ` Nina Schoetterl-Glausch
2024-06-21 7:13 ` Janosch Frank
2024-06-25 2:14 ` Nicholas Piggin
2024-06-25 8:11 ` Nina Schoetterl-Glausch
2024-06-25 23:52 ` Nicholas Piggin
2024-06-20 14:16 ` [kvm-unit-tests PATCH v3 5/7] s390x: Add library functions for exiting from snippet Nina Schoetterl-Glausch
2024-06-20 16:55 ` Claudio Imbrenda
2024-06-20 17:16 ` Nina Schoetterl-Glausch
2024-06-20 17:26 ` Claudio Imbrenda
2024-06-25 3:13 ` Nicholas Piggin
2024-06-25 2:43 ` Nicholas Piggin
2024-10-16 14:42 ` Nina Schoetterl-Glausch
2024-06-25 2:57 ` Nicholas Piggin
2024-06-25 9:21 ` Claudio Imbrenda
2024-06-20 14:16 ` Nina Schoetterl-Glausch [this message]
2024-06-20 16:56 ` [kvm-unit-tests PATCH v3 6/7] s390x: Use library functions for snippet exit Claudio Imbrenda
2024-06-25 2:58 ` Nicholas Piggin
2024-06-20 14:17 ` [kvm-unit-tests PATCH v3 7/7] s390x: Add test for STFLE interpretive execution (format-0) Nina Schoetterl-Glausch
2024-06-20 17:25 ` Claudio Imbrenda
2024-06-20 17:42 ` Nina Schoetterl-Glausch
2024-06-25 3:11 ` Nicholas Piggin
2024-08-27 14:08 ` Nico Boehr
2024-09-02 14:24 ` Nina Schoetterl-Glausch
2024-09-03 10:46 ` Heiko Carstens
2024-10-10 8:27 ` Nico Boehr
2024-10-15 11:01 ` Nina Schoetterl-Glausch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620141700.4124157-7-nsg@linux.ibm.com \
--to=nsg@linux.ibm.com \
--cc=andrew.jones@linux.dev \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox