Re: [PATCH 0/6] Make set_dev_pasid op supportting domain replacement

Jason Gunthorpe
2024-07-15T12:16:13Z

On Mon, Jul 15, 2024 at 04:11:43PM +0800, Yi Liu wrote:
> On 2024/7/12 02:37, Jason Gunthorpe wrote:
> > On Fri, Jun 28, 2024 at 01:55:32AM -0700, Yi Liu wrote:
> > > This splits the preparation works of the iommu and the Intel iommu driver
> > > out from the iommufd pasid attach/replace series. [1]
> > >
> > > To support domain replacement, the definition of the set_dev_pasid op
> > > needs to be enhanced. Meanwhile, the existing set_dev_pasid callbacks
> > > should be extended as well to suit the new definition.
> > >
> > > pasid attach/replace is mandatory on Intel VT-d given the PASID table
> > > locates in the physical address space hence must be managed by the kernel,
> > > both for supporting vSVA and coming SIOV. But it's optional on ARM/AMD
> > > which allow configuring the PASID/CD table either in host physical address
> > > space or nested on top of an GPA address space. This series only extends
> > > the Intel iommu driver as the minimal requirement.
> >
> > Sicne this will be pushed to the next cyle that will have my ARM code
> > the smmuv3 will need to be updated too. It is already prepped to
> > support replace, just add this please:
>
> thanks. So your related series has made the internal helpers to support
> domain replacement in set_dev_pasid path. The below diff just passes the
> old_domain across the helpers. Is it? Just to double confirm with you. :)

Yes

Jason