Re: [PATCH 0/6] Make set_dev_pasid op supportting domain replacement

Baolu Lu
2024-08-16T02:56:30Z

On 8/16/24 9:19 AM, Yi Liu wrote:
>> So the expectation is replace existing PASID from PASID table only if
>> old_domain
>> is passed. Otherwise sev_dev_pasid() should throw an error right?
>>
>
> yes. If no old_domain passed in, then it is just a normal attachment. As
> you are working on AMD iommu, it would be great if you can have a patch to
> make the AMD set_dev_pasid() op suit this expectation. Then it can be
> incorporated in this series. 🙂

Perhaps this has been discussed before, but I can't recall. Out of
curiosity, why not introduce a specific replace_dev_pasid callback?

Thanks,
baolu