public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Nicholas Piggin <npiggin@gmail.com>,
	Andrew Jones <andrew.jones@linux.dev>,
	kvm@vger.kernel.org
Subject: [kvm-unit-tests PATCH 5/6] gitlab-ci: add a shellcheck test
Date: Fri, 26 Jul 2024 17:04:46 +1000	[thread overview]
Message-ID: <20240726070456.467533-6-npiggin@gmail.com> (raw)
In-Reply-To: <20240726070456.467533-1-npiggin@gmail.com>

Now that we have some shellcheck support, might as well run it in
CI.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 .gitlab-ci.yml | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 0f72cefe7..2d55c6dcf 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -429,3 +429,16 @@ check-kerneldoc:
   before_script:
     - apk -U add bash make perl gcc
   allow_failure: true
+
+check-shellcheck:
+  extends: .intree_template
+  stage: build
+  image: python:3.10-alpine
+  needs: []
+  script:
+    - ./configure --arch=x86_64
+    - make -s shellcheck 2>&1 | tee shellcheckwarnings.txt
+    - test -z `cat shellcheckwarnings.txt`
+  before_script:
+    - apk -U add bash make gcc shellcheck
+  allow_failure: true
-- 
2.45.2


  parent reply	other threads:[~2024-07-26  7:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-26  7:04 [kvm-unit-tests PATCH 0/6] Checking and CI improvements Nicholas Piggin
2024-07-26  7:04 ` [kvm-unit-tests PATCH 1/6] gitlab-ci: fix CentOS mirror list Nicholas Piggin
2024-07-26  7:04 ` [kvm-unit-tests PATCH 2/6] arm: Fix kerneldoc Nicholas Piggin
2024-07-26  9:40   ` Suzuki K Poulose
2024-07-26  7:04 ` [kvm-unit-tests PATCH 3/6] gitlab-ci: upgrade to CentOS 8 Nicholas Piggin
2024-07-26  7:04 ` [kvm-unit-tests PATCH 4/6] gitlab-ci: Move check-kerneldoc test out of the centos test Nicholas Piggin
2024-07-26  7:04 ` Nicholas Piggin [this message]
2024-07-26  7:04 ` [kvm-unit-tests PATCH 6/6] checkpatch support Nicholas Piggin
2024-07-29 13:12 ` [kvm-unit-tests PATCH 0/6] Checking and CI improvements Andrew Jones
2024-08-12 14:32 ` Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240726070456.467533-6-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=andrew.jones@linux.dev \
    --cc=kvm@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox