From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
nrb@linux.ibm.com, schlameuss@linux.ibm.com, nsg@linux.ibm.com,
npiggin@gmail.com, mhartmay@linux.ibm.com
Subject: [kvm-unit-tests PATCH v2 2/4] s390x/Makefile: Add more comments
Date: Tue, 6 Aug 2024 08:42:28 +0000 [thread overview]
Message-ID: <20240806084409.169039-3-frankja@linux.ibm.com> (raw)
In-Reply-To: <20240806084409.169039-1-frankja@linux.ibm.com>
More comments in Makefiles can only make them more approachable.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
s390x/Makefile | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/s390x/Makefile b/s390x/Makefile
index aa55b470..f09bccfc 100644
--- a/s390x/Makefile
+++ b/s390x/Makefile
@@ -49,12 +49,15 @@ pv-tests += $(TEST_DIR)/pv-diags.elf
pv-tests += $(TEST_DIR)/pv-icptcode.elf
pv-tests += $(TEST_DIR)/pv-ipl.elf
+# Add PV host tests if we're able to generate them
+# The host key document and a tool to generate SE headers are the prerequisite
ifneq ($(HOST_KEY_DOCUMENT),)
ifneq ($(GEN_SE_HEADER),)
tests += $(pv-tests)
endif
endif
+# Add binary flat images for use in non-KVM hypervisors
tests_binary = $(patsubst %.elf,%.bin,$(tests))
ifneq ($(HOST_KEY_DOCUMENT),)
tests_pv_binary = $(patsubst %.bin,%.pv.bin,$(tests_binary))
@@ -140,6 +143,7 @@ $(TEST_DIR)/pv-icptcode.elf: pv-snippets += $(SNIPPET_DIR)/asm/loop.gbin
$(TEST_DIR)/pv-icptcode.elf: pv-snippets += $(SNIPPET_DIR)/asm/pv-icpt-vir-timing.gbin
$(TEST_DIR)/pv-ipl.elf: pv-snippets += $(SNIPPET_DIR)/asm/pv-diag-308.gbin
+# Add PV tests and snippets if GEN_SE_HEADER is set
ifneq ($(GEN_SE_HEADER),)
snippets += $(pv-snippets)
tests += $(pv-tests)
@@ -148,6 +152,7 @@ else
snippet-hdr-obj =
endif
+# Generate loader script
lds-autodepend-flags = -MMD -MF $(dir $*).$(notdir $*).d -MT $@
%.lds: %.lds.S $(asm-offsets)
$(CPP) $(lds-autodepend-flags) $(CPPFLAGS) -P -C -o $@ $<
--
2.43.0
next prev parent reply other threads:[~2024-08-06 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 8:42 [kvm-unit-tests PATCH v2 0/4] s390x: split off snippet and sie related code Janosch Frank
2024-08-06 8:42 ` [kvm-unit-tests PATCH v2 1/4] s390x/Makefile: Split snippet makefile rules into new file Janosch Frank
2024-08-06 8:52 ` Claudio Imbrenda
2024-08-06 9:01 ` Christoph Schlameuss
2024-08-06 8:42 ` Janosch Frank [this message]
2024-08-06 8:42 ` [kvm-unit-tests PATCH v2 3/4] s390x: Move SIE assembly " Janosch Frank
2024-08-06 8:42 ` [kvm-unit-tests PATCH v2 4/4] lib: s390x: Split SIE fw structs from lib structs Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806084409.169039-3-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhartmay@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=schlameuss@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox