Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Cleber Rosa <crosa@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>,
	"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
	"Radoslaw Biernacki" <rad@semihalf.com>,
	"Troy Lee" <leetroy@gmail.com>,
	"Akihiko Odaki" <akihiko.odaki@daynix.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	kvm@vger.kernel.org, "Joel Stanley" <joel@jms.id.au>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Sriram Yagnaraman" <sriram.yagnaraman@ericsson.com>,
	"Cédric Le Goater" <clg@kaod.org>, "Paul Durrant" <paul@xen.org>,
	"Eric Auger" <eric.auger@redhat.com>,
	"David Woodhouse" <dwmw2@infradead.org>,
	qemu-arm@nongnu.org, "Cleber Rosa" <crosa@redhat.com>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	"Jamin Lin" <jamin_lin@aspeedtech.com>,
	"Steven Lee" <steven_lee@aspeedtech.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Leif Lindholm" <quic_llindhol@quicinc.com>
Subject: [PATCH v2 7/9] tests/avocado/tuxrun_baselines.py: use Avocado's zstd support
Date: Tue,  6 Aug 2024 13:31:17 -0400	[thread overview]
Message-ID: <20240806173119.582857-8-crosa@redhat.com> (raw)
In-Reply-To: <20240806173119.582857-1-crosa@redhat.com>

This makes use of the avocado.utils.archive support for zstd.

In order to not duplicate code, the skip condition uses a private
utility from the module which is going to become public in Avocado
versions 103.1 LTS (and also in versions >= 107.0).

Reference: https://github.com/avocado-framework/avocado/pull/5996
Reference: https://github.com/avocado-framework/avocado/pull/5953
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 tests/avocado/tuxrun_baselines.py | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/tests/avocado/tuxrun_baselines.py b/tests/avocado/tuxrun_baselines.py
index 736e4aa289..bd02e88ed6 100644
--- a/tests/avocado/tuxrun_baselines.py
+++ b/tests/avocado/tuxrun_baselines.py
@@ -17,6 +17,7 @@
 from avocado_qemu import QemuSystemTest
 from avocado_qemu import exec_command, exec_command_and_wait_for_pattern
 from avocado_qemu import wait_for_console_pattern
+from avocado.utils import archive
 from avocado.utils import process
 from avocado.utils.path import find_command
 
@@ -40,17 +41,12 @@ def get_tag(self, tagname, default=None):
 
         return default
 
+    @skipUnless(archive._probe_zstd_cmd(),
+                'Could not find "zstd", or it is not able to properly '
+                'decompress decompress the rootfs')
     def setUp(self):
         super().setUp()
 
-        # We need zstd for all the tuxrun tests
-        # See https://github.com/avocado-framework/avocado/issues/5609
-        zstd = find_command('zstd', False)
-        if zstd is False:
-            self.cancel('Could not find "zstd", which is required to '
-                        'decompress rootfs')
-        self.zstd = zstd
-
         # Process the TuxRun specific tags, most machines work with
         # reasonable defaults but we sometimes need to tweak the
         # config. To avoid open coding everything we store all these
@@ -99,8 +95,8 @@ def fetch_tuxrun_assets(self, csums=None, dt=None):
                                          asset_hash = isum,
                                          algorithm = "sha256")
 
-        cmd = f"{self.zstd} -d {disk_image_zst} -o {self.workdir}/rootfs.ext4"
-        process.run(cmd)
+        archive.extract(disk_image_zst, os.path.join(self.workdir,
+                                                     "rootfs.ext4"))
 
         if dt:
             dsum = csums.get(dt, None)
-- 
2.45.2


  parent reply	other threads:[~2024-08-06 17:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-06 17:31 [PATCH v2 0/9] Bump Avocado to 103.0 LTS and update tests for compatibility and new features Cleber Rosa
2024-08-06 17:31 ` [PATCH v2 1/9] Bump avocado to 103.0 Cleber Rosa
2024-08-06 17:31 ` [PATCH v2 2/9] tests/avocado: apply proper skipUnless decorator Cleber Rosa
2024-08-06 19:28   ` Philippe Mathieu-Daudé
2024-08-12 10:21   ` Thomas Huth
2024-08-06 17:31 ` [PATCH v2 3/9] tests/avocado: add cdrom permission related tests Cleber Rosa
2024-08-16 14:46   ` Thomas Huth
2024-08-06 17:31 ` [PATCH v2 4/9] tests/avocado: machine aarch64: standardize location and RO access Cleber Rosa
2024-08-06 17:31 ` [PATCH v2 5/9] tests/avocado: simplify parameters on fetch_asset with name only Cleber Rosa
2024-08-06 17:31 ` [PATCH v2 6/9] tests/avocado/boot_xen.py: fetch kernel during test setUp() Cleber Rosa
2024-08-06 17:31 ` Cleber Rosa [this message]
2024-08-06 18:20   ` [PATCH v2 7/9] tests/avocado/tuxrun_baselines.py: use Avocado's zstd support Marcin Juszkiewicz
2024-08-07 17:26     ` Cleber Rosa
2024-08-06 17:31 ` [PATCH v2 8/9] tests/avocado/machine_aarch64_sbsaref.py: allow for rw usage of image Cleber Rosa
2024-08-06 19:30   ` Philippe Mathieu-Daudé
2024-08-07 17:26     ` Cleber Rosa
2024-08-06 17:31 ` [PATCH v2 9/9] Avocado tests: allow for parallel execution of tests Cleber Rosa
2024-08-12 10:17   ` Thomas Huth
2024-08-15 14:08     ` Cleber Rosa
2024-08-15 16:02       ` Thomas Huth
2024-08-06 18:20 ` [PATCH v2 0/9] Bump Avocado to 103.0 LTS and update tests for compatibility and new features Marcin Juszkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240806173119.582857-8-crosa@redhat.com \
    --to=crosa@redhat.com \
    --cc=akihiko.odaki@daynix.com \
    --cc=alex.bennee@linaro.org \
    --cc=andrew@codeconstruct.com.au \
    --cc=aurelien@aurel32.net \
    --cc=bleal@redhat.com \
    --cc=clg@kaod.org \
    --cc=dwmw2@infradead.org \
    --cc=eric.auger@redhat.com \
    --cc=jamin_lin@aspeedtech.com \
    --cc=joel@jms.id.au \
    --cc=kvm@vger.kernel.org \
    --cc=leetroy@gmail.com \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=paul@xen.org \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quic_llindhol@quicinc.com \
    --cc=rad@semihalf.com \
    --cc=sriram.yagnaraman@ericsson.com \
    --cc=steven_lee@aspeedtech.com \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox