From: Binbin Wu <binbin.wu@linux.intel.com>
To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: pbonzini@redhat.com, seanjc@google.com, isaku.yamahata@intel.com,
rick.p.edgecombe@intel.com, michael.roth@amd.com,
binbin.wu@linux.intel.com
Subject: [PATCH v2 1/2] KVM: x86: Check hypercall's exit to userspace generically
Date: Tue, 13 Aug 2024 13:12:55 +0800 [thread overview]
Message-ID: <20240813051256.2246612-2-binbin.wu@linux.intel.com> (raw)
In-Reply-To: <20240813051256.2246612-1-binbin.wu@linux.intel.com>
Check whether a KVM hypercall needs to exit to userspace or not based on
hypercall_exit_enabled field of struct kvm_arch.
Userspace can request a hypercall to exit to userspace for handling by
enable KVM_CAP_EXIT_HYPERCALL and the enabled hypercall will be set in
hypercall_exit_enabled. Make the check code generic based on it.
Signed-off-by: Binbin Wu <binbin.wu@linux.intel.com>
---
arch/x86/kvm/x86.c | 4 ++--
arch/x86/kvm/x86.h | 7 +++++++
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index af6c8cf6a37a..6e16c9751af7 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -10226,8 +10226,8 @@ int kvm_emulate_hypercall(struct kvm_vcpu *vcpu)
cpl = kvm_x86_call(get_cpl)(vcpu);
ret = __kvm_emulate_hypercall(vcpu, nr, a0, a1, a2, a3, op_64_bit, cpl);
- if (nr == KVM_HC_MAP_GPA_RANGE && !ret)
- /* MAP_GPA tosses the request to the user space. */
+ if (!ret && is_kvm_hc_exit_enabled(vcpu->kvm, nr))
+ /* The hypercall is requested to exit to userspace. */
return 0;
if (!op_64_bit)
diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h
index 50596f6f8320..0cbec76b42e6 100644
--- a/arch/x86/kvm/x86.h
+++ b/arch/x86/kvm/x86.h
@@ -547,4 +547,11 @@ int kvm_sev_es_string_io(struct kvm_vcpu *vcpu, unsigned int size,
unsigned int port, void *data, unsigned int count,
int in);
+static inline bool is_kvm_hc_exit_enabled(struct kvm *kvm, unsigned long hc_nr)
+{
+ if(WARN_ON_ONCE(hc_nr >= sizeof(kvm->arch.hypercall_exit_enabled) * 8))
+ return false;
+
+ return kvm->arch.hypercall_exit_enabled & (1 << hc_nr);
+}
#endif
--
2.43.2
next prev parent reply other threads:[~2024-08-13 5:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 5:12 [PATCH v2 0/2] KVM: x86: Check hypercall's exit to userspace generically Binbin Wu
2024-08-13 5:12 ` Binbin Wu [this message]
2024-08-13 5:56 ` [PATCH v2 1/2] " Yuan Yao
2024-08-13 6:14 ` Yuan Yao
2024-08-13 17:50 ` Isaku Yamahata
2024-08-13 23:11 ` Huang, Kai
2024-08-14 0:52 ` Isaku Yamahata
2024-08-14 1:27 ` Binbin Wu
2024-08-14 1:31 ` Sean Christopherson
2024-08-14 2:36 ` Huang, Kai
2024-08-14 4:59 ` Binbin Wu
2024-08-13 23:16 ` Huang, Kai
2024-08-14 0:53 ` Isaku Yamahata
2024-08-14 1:08 ` Binbin Wu
2024-08-13 5:12 ` [PATCH v2 2/2] KVM: x86: Use is_kvm_hc_exit_enabled() instead of opencode Binbin Wu
2024-08-13 17:51 ` Isaku Yamahata
2024-08-13 23:18 ` Huang, Kai
2024-08-19 10:07 ` Binbin Wu
2024-08-19 22:24 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240813051256.2246612-2-binbin.wu@linux.intel.com \
--to=binbin.wu@linux.intel.com \
--cc=isaku.yamahata@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox