From: Heiko Carstens <hca@linux.ibm.com>
To: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
Cc: Nico Boehr <nrb@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Andrew Jones <andrew.jones@linux.dev>,
Thomas Huth <thuth@redhat.com>,
Nicholas Piggin <npiggin@gmail.com>,
David Hildenbrand <david@redhat.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v3 7/7] s390x: Add test for STFLE interpretive execution (format-0)
Date: Tue, 3 Sep 2024 12:46:20 +0200 [thread overview]
Message-ID: <20240903104620.8020-B-hca@linux.ibm.com> (raw)
In-Reply-To: <0d1fb151a09701588f98547cdb9f74bc743cb615.camel@linux.ibm.com>
On Mon, Sep 02, 2024 at 04:24:53PM +0200, Nina Schoetterl-Glausch wrote:
> On Tue, 2024-08-27 at 16:08 +0200, Nico Boehr wrote:
> > Quoting Nina Schoetterl-Glausch (2024-06-20 16:17:00)
> >
> > And: is long displacement even appropriate here?
> >
> > The cast also is hard to understand. Since this is not super high
> > performance code, do we just want to clobber memory so this gets a bit
> > easier to understand?
> >
> > > + [len] "+RT"(res[0])
> >
> > Same question about RT as above.
>
> Long, but providing a short displacement should be fine too.
> Not sure if there is any benefit to letting the compiler choose.
There are some older gcc compilers around which fail to compile if you
specify T for long displacement, but the compiler sees that a short
displacement would work. So please specify RT to avoid such compile
bugs.
See https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=3e4be43f69da
next prev parent reply other threads:[~2024-09-03 10:46 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 14:16 [kvm-unit-tests PATCH v3 0/7] s390x: STFLE nested interpretation Nina Schoetterl-Glausch
2024-06-20 14:16 ` [kvm-unit-tests PATCH v3 1/7] lib: Add pseudo random functions Nina Schoetterl-Glausch
2024-06-25 3:08 ` Nicholas Piggin
2024-06-25 7:06 ` Nina Schoetterl-Glausch
2024-08-12 14:17 ` Andrew Jones
2024-10-10 8:25 ` Nico Boehr
2024-10-10 8:37 ` Andrew Jones
2024-06-20 14:16 ` [kvm-unit-tests PATCH v3 2/7] s390x: lib: Remove double include Nina Schoetterl-Glausch
2024-06-21 6:58 ` Janosch Frank
2024-06-20 14:16 ` [kvm-unit-tests PATCH v3 3/7] s390x: Add sie_is_pv Nina Schoetterl-Glausch
2024-06-20 16:41 ` Claudio Imbrenda
2024-06-21 6:59 ` Janosch Frank
2024-06-25 1:58 ` Nicholas Piggin
2024-06-20 14:16 ` [kvm-unit-tests PATCH v3 4/7] s390x: Add function for checking diagnose intercepts Nina Schoetterl-Glausch
2024-06-20 16:47 ` Claudio Imbrenda
2024-06-20 17:46 ` Nina Schoetterl-Glausch
2024-06-21 7:13 ` Janosch Frank
2024-06-25 2:14 ` Nicholas Piggin
2024-06-25 8:11 ` Nina Schoetterl-Glausch
2024-06-25 23:52 ` Nicholas Piggin
2024-06-20 14:16 ` [kvm-unit-tests PATCH v3 5/7] s390x: Add library functions for exiting from snippet Nina Schoetterl-Glausch
2024-06-20 16:55 ` Claudio Imbrenda
2024-06-20 17:16 ` Nina Schoetterl-Glausch
2024-06-20 17:26 ` Claudio Imbrenda
2024-06-25 3:13 ` Nicholas Piggin
2024-06-25 2:43 ` Nicholas Piggin
2024-10-16 14:42 ` Nina Schoetterl-Glausch
2024-06-25 2:57 ` Nicholas Piggin
2024-06-25 9:21 ` Claudio Imbrenda
2024-06-20 14:16 ` [kvm-unit-tests PATCH v3 6/7] s390x: Use library functions for snippet exit Nina Schoetterl-Glausch
2024-06-20 16:56 ` Claudio Imbrenda
2024-06-25 2:58 ` Nicholas Piggin
2024-06-20 14:17 ` [kvm-unit-tests PATCH v3 7/7] s390x: Add test for STFLE interpretive execution (format-0) Nina Schoetterl-Glausch
2024-06-20 17:25 ` Claudio Imbrenda
2024-06-20 17:42 ` Nina Schoetterl-Glausch
2024-06-25 3:11 ` Nicholas Piggin
2024-08-27 14:08 ` Nico Boehr
2024-09-02 14:24 ` Nina Schoetterl-Glausch
2024-09-03 10:46 ` Heiko Carstens [this message]
2024-10-10 8:27 ` Nico Boehr
2024-10-15 11:01 ` Nina Schoetterl-Glausch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903104620.8020-B-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=andrew.jones@linux.dev \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox