From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3047B14386C for ; Wed, 11 Sep 2024 08:35:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726043726; cv=none; b=qXnrdOu0cbpHDC6JIZhYrH5Lw9SFZolAq8V47XlA4KjxibNcVfEB3pPO8z3SHzvRQRp10roAId4nD3gaBKlHEBBW8d0BrCKPXgnuvaIylKEVtMpkciHdkRN7OI9etviefVAsfnSZrQhlV2BrGJY7quDsXeZ8F5j6vArxgXrqqe0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726043726; c=relaxed/simple; bh=pj4sOscBwjxD+a2sgfuYUDp+OZrCpZoBJhq8wSHikVE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lW69VVZiVbxKahflBVPaujDh9FWVVOlxR7XFbuhqbaOBij6UK2vTfV8zn25bQA2by2sJj7P7mI3EkTpVYSAFbbg3wTo72mPaHZ2gGC4lKlxf4o46KGu3c1iCS+VKp6OKYs71BhNI41td5a6yAUN9v5QTFxs+lXm6/XGaOul1mAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=f15G6Ujj; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f15G6Ujj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726043724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=re2cfP3YBaOsffor8m/DNC1HDSaHt4Pl1sDqo5GtM5Q=; b=f15G6UjjSd5XkrpXdS4A+21cdi+OX26Z6/AxIUS3Xbu4ZkpeWDbO7Zp11jDcDWXg1b4efb ANSopByTO+DnDMySwKsscfAwY4Lp5WjsCOFxhGdDpUbN6U3SFNtjW9RVAkq2WR1EZZUKob ggulB5tx+f2Yci/F2ood2VtlYKo954A= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-287-yhLa1sOFO3SH99DZG1JDMg-1; Wed, 11 Sep 2024 04:35:20 -0400 X-MC-Unique: yhLa1sOFO3SH99DZG1JDMg-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 75E151944D39; Wed, 11 Sep 2024 08:35:11 +0000 (UTC) Received: from localhost (unknown [10.42.28.10]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5F32719560A3; Wed, 11 Sep 2024 08:35:06 +0000 (UTC) Date: Wed, 11 Sep 2024 09:35:05 +0100 From: "Richard W.M. Jones" To: Pierrick Bouvier Cc: qemu-devel@nongnu.org, Zhao Liu , Joel Stanley , Kevin Wolf , Paolo Bonzini , qemu-arm@nongnu.org, Corey Minyard , Eric Farman , Thomas Huth , Keith Busch , WANG Xuerui , Hyman Huang , Stefan Berger , Michael Rolnik , Alistair Francis , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Markus Armbruster , Sriram Yagnaraman , Palmer Dabbelt , qemu-riscv@nongnu.org, Ani Sinha , Halil Pasic , Jesper Devantier , Laurent Vivier , Peter Maydell , Igor Mammedov , kvm@vger.kernel.org, Alex =?iso-8859-1?Q?Benn=E9e?= , Richard Henderson , Fam Zheng , qemu-s390x@nongnu.org, Hanna Reitz , Nicholas Piggin , Eduardo Habkost , Laurent Vivier , Rob Herring , Marcel Apfelbaum , qemu-block@nongnu.org, "Maciej S. Szmigiero" , qemu-ppc@nongnu.org, Daniel Henrique Barboza , Christian Borntraeger , Harsh Prateek Bora , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Nina Schoetterl-Glausch , "Michael S. Tsirkin" , Fabiano Rosas , Helge Deller , Dmitry Fleytman , Daniel Henrique Barboza , Akihiko Odaki , Marcelo Tosatti , David Gibson , Aurelien Jarno , Liu Zhiwei , Yanan Wang , Peter Xu , Bin Meng , Weiwei Li , Klaus Jensen , Jean-Christophe Dubois , Jason Wang Subject: Re: [PATCH 07/39] hw/watchdog: replace assert(0) with g_assert_not_reached() Message-ID: <20240911083310.GO1450@redhat.com> References: <20240910221606.1817478-1-pierrick.bouvier@linaro.org> <20240910221606.1817478-8-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240910221606.1817478-8-pierrick.bouvier@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On Tue, Sep 10, 2024 at 03:15:34PM -0700, Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier > --- > hw/watchdog/watchdog.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/watchdog/watchdog.c b/hw/watchdog/watchdog.c > index 955046161bf..d0ce3c4ac55 100644 > --- a/hw/watchdog/watchdog.c > +++ b/hw/watchdog/watchdog.c > @@ -85,7 +85,7 @@ void watchdog_perform_action(void) > break; > > default: > - assert(0); > + g_assert_not_reached(); > } > } > Reviewed-by: Richard W.M. Jones -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com nbdkit - Flexible, fast NBD server with plugins https://gitlab.com/nbdkit/nbdkit