From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1253154BE4 for ; Wed, 11 Sep 2024 08:36:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726043766; cv=none; b=WiwREaa/M9gKGVrn+/KchRaslaOW8cR8gEnJW79j+OzRi+UdHf9ACUYcI05aExx5Ae/ri1c6N4BfyMPOVbNvuPK2pJO0jmFgEx33LjjUiDwd1hHCAQeYWfXRt4eGmwtAhk6bCA7K7IffonwFkwP2jTBmnVTjBLkb2CVviRtWyRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726043766; c=relaxed/simple; bh=uMHnH4MehEAeu/F3MCzAvr/pYPqH8qtMLYyGLrER2bM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fEjO9ge5K6wgR/iMWA771yJxt04nXMexHY6SGbZr7mEhJrl8eEA4jmxyNg9MqYy8vJvvuDfPqV/Lyp0qm9myl1/xk83y6ZDiVakoTZxMpsItILtzLZpVySfXt581NOSOms+ScIqUVeTNo7dM0qCksVYfDWiqLy63OcITFBbcq/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CV7oxiqE; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CV7oxiqE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726043763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/XNGw8Se064Ya4KciD5cw1pBjcoikCLo2yQ3fCVI8Z4=; b=CV7oxiqEaUX9mAMMlLBkTAf9c6PVGpWzAuItTiPDZlYQ9dQ7h9JBzWPf/N05m6nBEojI8E 7ii3qwmYlKTRM5xL5z/BPM+WCrD61cUm/YMRPYY5KXVcb5a4qcHKUN/ljwjaozElKeM2td +FMq0F+hUrPhkOCxcKh7cGgKtNae2BU= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-490--aAmEBQ_PUqRpI0skSRBqw-1; Wed, 11 Sep 2024 04:35:59 -0400 X-MC-Unique: -aAmEBQ_PUqRpI0skSRBqw-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2A039195394E; Wed, 11 Sep 2024 08:35:51 +0000 (UTC) Received: from localhost (unknown [10.42.28.10]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 88B4830001A1; Wed, 11 Sep 2024 08:35:47 +0000 (UTC) Date: Wed, 11 Sep 2024 09:35:46 +0100 From: "Richard W.M. Jones" To: Pierrick Bouvier Cc: qemu-devel@nongnu.org, Zhao Liu , Joel Stanley , Kevin Wolf , Paolo Bonzini , qemu-arm@nongnu.org, Corey Minyard , Eric Farman , Thomas Huth , Keith Busch , WANG Xuerui , Hyman Huang , Stefan Berger , Michael Rolnik , Alistair Francis , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Markus Armbruster , Sriram Yagnaraman , Palmer Dabbelt , qemu-riscv@nongnu.org, Ani Sinha , Halil Pasic , Jesper Devantier , Laurent Vivier , Peter Maydell , Igor Mammedov , kvm@vger.kernel.org, Alex =?iso-8859-1?Q?Benn=E9e?= , Richard Henderson , Fam Zheng , qemu-s390x@nongnu.org, Hanna Reitz , Nicholas Piggin , Eduardo Habkost , Laurent Vivier , Rob Herring , Marcel Apfelbaum , qemu-block@nongnu.org, "Maciej S. Szmigiero" , qemu-ppc@nongnu.org, Daniel Henrique Barboza , Christian Borntraeger , Harsh Prateek Bora , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Nina Schoetterl-Glausch , "Michael S. Tsirkin" , Fabiano Rosas , Helge Deller , Dmitry Fleytman , Daniel Henrique Barboza , Akihiko Odaki , Marcelo Tosatti , David Gibson , Aurelien Jarno , Liu Zhiwei , Yanan Wang , Peter Xu , Bin Meng , Weiwei Li , Klaus Jensen , Jean-Christophe Dubois , Jason Wang Subject: Re: [PATCH 25/39] block: remove break after g_assert_not_reached() Message-ID: <20240911083546.GP1450@redhat.com> References: <20240910221606.1817478-1-pierrick.bouvier@linaro.org> <20240910221606.1817478-26-pierrick.bouvier@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240910221606.1817478-26-pierrick.bouvier@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On Tue, Sep 10, 2024 at 03:15:52PM -0700, Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier > --- > block/ssh.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/block/ssh.c b/block/ssh.c > index 27d582e0e3d..871e1d47534 100644 > --- a/block/ssh.c > +++ b/block/ssh.c > @@ -474,7 +474,6 @@ static int check_host_key(BDRVSSHState *s, SshHostKeyCheck *hkc, Error **errp) > errp); > } > g_assert_not_reached(); > - break; > case SSH_HOST_KEY_CHECK_MODE_KNOWN_HOSTS: > return check_host_key_knownhosts(s, errp); > default: > -- > 2.39.2 Reviewed-by: Richard W.M. Jones -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW