From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 558911B1D5E for ; Thu, 12 Sep 2024 14:06:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726149972; cv=none; b=Igno/ymmV80JoZA5UZGi5LSxvZ/BOgxrM2ivyjtcWUTp+oAz81NU8vfZEgkU5JEokPikiSqfMAvjcNG9ewCtXBaBowRiuggQQl4tmi62aFOpLbq7L18EjlXi1/ce+H7Qizn+tm7IvxB//WYns1dBaCijxXKWamkyfDYl4RBC9gw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726149972; c=relaxed/simple; bh=KVbFmUhSgZemh9B5IlH8iz8XJGIcyGBcxsmX72xzX1k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZK/pDi9g198ymi8zZqhJyZy9YJ7kvWysT2CYQVTXzt+xOtbtMIeAahnE9Y0P9WUhAM8R0ZxQUwCDMl+QMMNMSXUIkmedfUgrMtUU/LBs6IPc/F3pEhRN8Fwl8K3iUhk9IQECtMgNbazdw38ziib1V6LAR6uqAp5bgqsENWW1bMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=l570DgAE; arc=none smtp.client-ip=91.218.175.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="l570DgAE" Date: Thu, 12 Sep 2024 16:06:02 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1726149967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rLndykp0CSNrjGcDsu/5BT8m6e7kp7zpu2JL8IyFJTk=; b=l570DgAEVJuJj43meLvdrBk2VN4/pSt3UFwhRKnFtqAfpYapREAeiOEraYt5d7kbq3Ixkl QeaXs9fBQ1U/2aCPNSvsHxylayeGjk7ZUkHwt0WjUOVcUpfTdNLGPnNQ9XeG8ykAJA2enU FQ6wIKz+I93XDhxUT6JywFTo1RnbvYk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: James Raphael Tiovalen Cc: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, atishp@rivosinc.com, cade.richard@berkeley.edu Subject: Re: [kvm-unit-tests PATCH v3 1/2] riscv: sbi: Add HSM extension functions Message-ID: <20240912-f404e2ed36d3a09b123a4f6e@orel> References: <20240910151536.163830-1-jamestiotio@gmail.com> <20240910151536.163830-2-jamestiotio@gmail.com> <20240911-595775a85e53a6fd92bdf707@orel> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240911-595775a85e53a6fd92bdf707@orel> X-Migadu-Flow: FLOW_OUT On Wed, Sep 11, 2024 at 05:45:57PM GMT, Andrew Jones wrote: > On Tue, Sep 10, 2024 at 11:15:35PM GMT, James Raphael Tiovalen wrote: > > Add helper functions to perform hart-related operations to prepare for > > the HSM tests. Also add the HSM state IDs and default suspend type > > constants. > > > > Reviewed-by: Andrew Jones > > Signed-off-by: James Raphael Tiovalen > > --- > > lib/riscv/asm/sbi.h | 17 +++++++++++++++++ > > lib/riscv/sbi.c | 10 ++++++++++ > > riscv/sbi.c | 5 +++++ > > 3 files changed, 32 insertions(+) > > > > diff --git a/lib/riscv/asm/sbi.h b/lib/riscv/asm/sbi.h > > index e032444d..1319439b 100644 > > --- a/lib/riscv/asm/sbi.h > > +++ b/lib/riscv/asm/sbi.h > > @@ -49,6 +49,21 @@ enum sbi_ext_ipi_fid { > > SBI_EXT_IPI_SEND_IPI = 0, > > }; > > > > +enum sbi_ext_hsm_sid { > > + SBI_EXT_HSM_STARTED = 0, > > + SBI_EXT_HSM_STOPPED, > > + SBI_EXT_HSM_START_PENDING, > > + SBI_EXT_HSM_STOP_PENDING, > > + SBI_EXT_HSM_SUSPENDED, > > + SBI_EXT_HSM_SUSPEND_PENDING, > > + SBI_EXT_HSM_RESUME_PENDING, > > +}; > > + > > +enum sbi_ext_hsm_hart_suspend_type { > > + SBI_EXT_HSM_HART_SUSPEND_RETENTIVE = 0, > > + SBI_EXT_HSM_HART_SUSPEND_NON_RETENTIVE = 0x80000000, > > +}; > > + > > enum sbi_ext_dbcn_fid { > > SBI_EXT_DBCN_CONSOLE_WRITE = 0, > > SBI_EXT_DBCN_CONSOLE_READ, > > @@ -67,6 +82,8 @@ struct sbiret sbi_ecall(int ext, int fid, unsigned long arg0, > > > > void sbi_shutdown(void); > > struct sbiret sbi_hart_start(unsigned long hartid, unsigned long entry, unsigned long sp); > > +struct sbiret sbi_hart_stop(void); > > +struct sbiret sbi_hart_get_status(unsigned long hartid); > > struct sbiret sbi_send_ipi(unsigned long hart_mask, unsigned long hart_mask_base); > > struct sbiret sbi_send_ipi_cpu(int cpu); > > struct sbiret sbi_send_ipi_cpumask(const cpumask_t *mask); > > diff --git a/lib/riscv/sbi.c b/lib/riscv/sbi.c > > index ecc63acd..8972e765 100644 > > --- a/lib/riscv/sbi.c > > +++ b/lib/riscv/sbi.c > > @@ -42,6 +42,16 @@ struct sbiret sbi_hart_start(unsigned long hartid, unsigned long entry, unsigned > > return sbi_ecall(SBI_EXT_HSM, SBI_EXT_HSM_HART_START, hartid, entry, sp, 0, 0, 0); > > } > > > > +struct sbiret sbi_hart_stop(void) > > +{ > > + return sbi_ecall(SBI_EXT_HSM, SBI_EXT_HSM_HART_STOP, 0, 0, 0, 0, 0, 0); > > +} > > + > > +struct sbiret sbi_hart_get_status(unsigned long hartid) > > +{ > > + return sbi_ecall(SBI_EXT_HSM, SBI_EXT_HSM_HART_STATUS, hartid, 0, 0, 0, 0, 0); > > +} > > + > > struct sbiret sbi_send_ipi(unsigned long hart_mask, unsigned long hart_mask_base) > > { > > return sbi_ecall(SBI_EXT_IPI, SBI_EXT_IPI_SEND_IPI, hart_mask, hart_mask_base, 0, 0, 0, 0); > > diff --git a/riscv/sbi.c b/riscv/sbi.c > > index f88bf700..c9fbd6db 100644 > > --- a/riscv/sbi.c > > +++ b/riscv/sbi.c > > @@ -73,6 +73,11 @@ static phys_addr_t get_highest_addr(void) > > return highest_end - 1; > > } > > > > +static struct sbiret sbi_hart_suspend(uint32_t suspend_type, unsigned long resume_addr, unsigned long opaque) > > +{ > > + return sbi_ecall(SBI_EXT_HSM, SBI_EXT_HSM_HART_SUSPEND, suspend_type, resume_addr, opaque, 0, 0, 0); > > +} > > + > > This hunk needs to be moved to the next patch since the build will > otherwise fail due to the function being unused. We want each commit > to build in order to maintain bisectability. You may want to test > your series with something like > > ./configure --arch=riscv64 --cross-prefix=riscv64-linux-gnu- > git rebase -x 'make' > > Also we should put sbi_hart_suspend() directly under sbi_dbcn_write_byte() > in order to keep all the sbi_ecall wrappers grouped together. > I removed the hunk and applied to riscv/sbi, https://gitlab.com/jones-drew/kvm-unit-tests/-/commits/riscv/sbi Thanks, drew