Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: WangYuli <wangyuli@uniontech.com>
Cc: stable@vger.kernel.org, sashal@kernel.org, maobibo@loongson.cn,
	guanwentao@uniontech.com, zhangdandan@uniontech.com,
	chenhuacai@loongson.cn, zhaotianrui@loongson.cn,
	kernel@xen0n.name, kvm@vger.kernel.org,
	loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6.10] LoongArch: KVM: Remove undefined a6 argument comment for kvm_hypercall()
Date: Mon, 16 Sep 2024 13:39:04 +0200	[thread overview]
Message-ID: <2024091647-absolve-wharf-f271@gregkh> (raw)
In-Reply-To: <5B13B2AF7C2779A7+20240916092857.433334-1-wangyuli@uniontech.com>

On Mon, Sep 16, 2024 at 05:28:57PM +0800, WangYuli wrote:
> From: Dandan Zhang <zhangdandan@uniontech.com>
> 
> [ Upstream commit 494b0792d962e8efac72b3a5b6d9bcd4e6fa8cf0 ]
> 
> The kvm_hypercall() set for LoongArch is limited to a1-a5. So the
> mention of a6 in the comment is undefined that needs to be rectified.
> 
> Reviewed-by: Bibo Mao <maobibo@loongson.cn>
> Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
> Signed-off-by: Dandan Zhang <zhangdandan@uniontech.com>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> --
> Changlog:
>  *v1 -> v2: Correct the commit-msg format.
> ---
>  arch/loongarch/include/asm/kvm_para.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/loongarch/include/asm/kvm_para.h b/arch/loongarch/include/asm/kvm_para.h
> index 4ba2312e5f8c..6d5e9b6c5714 100644
> --- a/arch/loongarch/include/asm/kvm_para.h
> +++ b/arch/loongarch/include/asm/kvm_para.h
> @@ -28,9 +28,9 @@
>   * Hypercall interface for KVM hypervisor
>   *
>   * a0: function identifier
> - * a1-a6: args
> + * a1-a5: args
>   * Return value will be placed in a0.
> - * Up to 6 arguments are passed in a1, a2, a3, a4, a5, a6.
> + * Up to 5 arguments are passed in a1, a2, a3, a4, a5.
>   */
>  static __always_inline long kvm_hypercall0(u64 fid)
>  {
> -- 
> 2.43.0
> 
> 

Again, why is this needed?

thanks,

greg k-h

  reply	other threads:[~2024-09-16 11:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16  9:28 [PATCH v2 6.10] LoongArch: KVM: Remove undefined a6 argument comment for kvm_hypercall() WangYuli
2024-09-16 11:39 ` Greg KH [this message]
2024-09-17  8:49   ` WangYuli
2024-09-17  9:13     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024091647-absolve-wharf-f271@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=chenhuacai@loongson.cn \
    --cc=guanwentao@uniontech.com \
    --cc=kernel@xen0n.name \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=maobibo@loongson.cn \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=wangyuli@uniontech.com \
    --cc=zhangdandan@uniontech.com \
    --cc=zhaotianrui@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox