From: Heiko Carstens <hca@linux.ibm.com>
To: Nico Boehr <nrb@linux.ibm.com>
Cc: borntraeger@linux.ibm.com, frankja@linux.ibm.com,
imbrenda@linux.ibm.com, david@redhat.com, kvm@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: Re: [PATCH v1 2/2] KVM: s390: Change virtual to physical address access in diag 0x258 handler
Date: Wed, 18 Sep 2024 12:58:07 +0200 [thread overview]
Message-ID: <20240918105807.6794-C-hca@linux.ibm.com> (raw)
In-Reply-To: <20240917151904.74314-3-nrb@linux.ibm.com>
On Tue, Sep 17, 2024 at 05:18:34PM +0200, Nico Boehr wrote:
> From: Michael Mueller <mimu@linux.ibm.com>
>
> The parameters for the diag 0x258 are real addresses, not virtual, but
> KVM was using them as virtual addresses. This only happened to work, since
> the Linux kernel as a guest used to have a 1:1 mapping for physical vs
> virtual addresses.
>
> Fix KVM so that it correctly uses the addresses as real addresses.
>
> Cc: stable@vger.kernel.org
> Fixes: 8ae04b8f500b ("KVM: s390: Guest's memory access functions get access registers")
> Suggested-by: Vasily Gorbik <gor@linux.ibm.com>
> Signed-off-by: Michael Mueller <mimu@linux.ibm.com>
> [ nrb: drop tested-by tags ]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This shouldn't be part of the commit message.
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
> ---
> arch/s390/kvm/diag.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
prev parent reply other threads:[~2024-09-18 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 15:18 [PATCH v1 0/2] KVM: s390: fix diag258 virtual-physical confusion Nico Boehr
2024-09-17 15:18 ` [PATCH v1 1/2] KVM: s390: gaccess: check if guest address is in memslot Nico Boehr
2024-09-18 10:55 ` Heiko Carstens
2024-09-18 11:03 ` Christian Borntraeger
2024-09-17 15:18 ` [PATCH v1 2/2] KVM: s390: Change virtual to physical address access in diag 0x258 handler Nico Boehr
2024-09-18 10:46 ` Christian Borntraeger
2024-09-18 10:58 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240918105807.6794-C-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox