Re: [PATCH 4/8] KVM: return value from kvm_arch_sync_dirty_log

kernel test robot
2024-09-19T01:51:06Z

Hi Lilit,

kernel test robot noticed the following build errors:

[auto build test ERROR on powerpc/topic/ppc-kvm]
[also build test ERROR on v6.11]
[cannot apply to kvmarm/next kvm/queue linus/master kvm/linux-next next-20240918]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Lilit-Janpoladyan/arm64-add-an-interface-for-stage-2-page-tracking/20240918-233004
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git topic/ppc-kvm
patch link: https://lore.kernel.org/r/20240918152807.25135-5-lilitj%40amazon.com
patch subject: [PATCH 4/8] KVM: return value from kvm_arch_sync_dirty_log
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20240919/202409190941.BQaCqQSk-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240919/202409190941.BQaCqQSk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409190941.BQaCqQSk-lkp@intel.com/

All errors (new ones prefixed by >>):

arch/s390/kvm/kvm-s390.c: In function 'kvm_arch_sync_dirty_log':
>> arch/s390/kvm/kvm-s390.c:705:25: error: 'return' with no value, in function returning non-void [-Wreturn-mismatch]
705 | return;
| ^~~~~~
arch/s390/kvm/kvm-s390.c:680:5: note: declared here
680 | int kvm_arch_sync_dirty_log(struct kvm *kvm, struct kvm_memory_slot *memslot)
| ^~~~~~~~~~~~~~~~~~~~~~~

vim +/return +705 arch/s390/kvm/kvm-s390.c

5b5865e81387b9 Lilit Janpoladyan 2024-09-18 679
522a3b6f0285f5 Lilit Janpoladyan 2024-09-18 680 int kvm_arch_sync_dirty_log(struct kvm *kvm, struct kvm_memory_slot *memslot)
15f36ebd34b5b2 Jason J. Herne 2012-08-02 681 {
0959e168678d2d Janosch Frank 2018-07-17 682 int i;
15f36ebd34b5b2 Jason J. Herne 2012-08-02 683 gfn_t cur_gfn, last_gfn;
0959e168678d2d Janosch Frank 2018-07-17 684 unsigned long gaddr, vmaddr;
15f36ebd34b5b2 Jason J. Herne 2012-08-02 685 struct gmap *gmap = kvm->arch.gmap;
0959e168678d2d Janosch Frank 2018-07-17 686 DECLARE_BITMAP(bitmap, _PAGE_ENTRIES);
15f36ebd34b5b2 Jason J. Herne 2012-08-02 687
0959e168678d2d Janosch Frank 2018-07-17 688 /* Loop over all guest segments */
0959e168678d2d Janosch Frank 2018-07-17 689 cur_gfn = memslot->base_gfn;
15f36ebd34b5b2 Jason J. Herne 2012-08-02 690 last_gfn = memslot->base_gfn + memslot->npages;
0959e168678d2d Janosch Frank 2018-07-17 691 for (; cur_gfn <= last_gfn; cur_gfn += _PAGE_ENTRIES) {
0959e168678d2d Janosch Frank 2018-07-17 692 gaddr = gfn_to_gpa(cur_gfn);
0959e168678d2d Janosch Frank 2018-07-17 693 vmaddr = gfn_to_hva_memslot(memslot, cur_gfn);
0959e168678d2d Janosch Frank 2018-07-17 694 if (kvm_is_error_hva(vmaddr))
0959e168678d2d Janosch Frank 2018-07-17 695 continue;
0959e168678d2d Janosch Frank 2018-07-17 696
0959e168678d2d Janosch Frank 2018-07-17 697 bitmap_zero(bitmap, _PAGE_ENTRIES);
0959e168678d2d Janosch Frank 2018-07-17 698 gmap_sync_dirty_log_pmd(gmap, bitmap, gaddr, vmaddr);
0959e168678d2d Janosch Frank 2018-07-17 699 for (i = 0; i < _PAGE_ENTRIES; i++) {
0959e168678d2d Janosch Frank 2018-07-17 700 if (test_bit(i, bitmap))
0959e168678d2d Janosch Frank 2018-07-17 701 mark_page_dirty(kvm, cur_gfn + i);
0959e168678d2d Janosch Frank 2018-07-17 702 }
15f36ebd34b5b2 Jason J. Herne 2012-08-02 703
1763f8d09d522b Christian Borntraeger 2016-02-03 704 if (fatal_signal_pending(current))
1763f8d09d522b Christian Borntraeger 2016-02-03 @705 return;
70c88a00fbf659 Christian Borntraeger 2016-02-02 706 cond_resched();
15f36ebd34b5b2 Jason J. Herne 2012-08-02 707 }
522a3b6f0285f5 Lilit Janpoladyan 2024-09-18 708 return 0;
15f36ebd34b5b2 Jason J. Herne 2012-08-02 709 }
15f36ebd34b5b2 Jason J. Herne 2012-08-02 710

--
0-DAY CI Kernel Test Service