From: Igor Mammedov <imammedo@redhat.com>
To: boris.ostrovsky@oracle.com
Cc: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Mackay <eric.mackay@oracle.com>
Subject: Re: [PATCH] KVM/x86: Do not clear SIPI while in SMM
Date: Tue, 24 Sep 2024 11:40:51 +0200 [thread overview]
Message-ID: <20240924114051.1d5f7470@imammedo.users.ipa.redhat.com> (raw)
In-Reply-To: <534247e4-76d6-41d2-86c7-0155406ccd80@oracle.com>
On Fri, 19 Apr 2024 12:17:01 -0400
boris.ostrovsky@oracle.com wrote:
> On 4/17/24 9:58 AM, boris.ostrovsky@oracle.com wrote:
> >
> > I noticed that I was using a few months old qemu bits and now I am
> > having trouble reproducing this on latest bits. Let me see if I can get
> > this to fail with latest first and then try to trace why the processor
> > is in this unexpected state.
>
> Looks like 012b170173bc "system/qdev-monitor: move drain_call_rcu call
> under if (!dev) in qmp_device_add()" is what makes the test to stop failing.
>
> I need to understand whether lack of failures is a side effect of timing
> changes that simply make hotplug fail less likely or if this is an
> actual (but seemingly unintentional) fix.
Agreed, we should find out culprit of the problem.
PS:
also if you are using AMD host, there was a regression in OVMF
where where vCPU that OSPM was already online-ing, was yanked
from under OSMP feet by OVMF (which depending on timing could
manifest as lost SIPI).
edk2 commit that should fix it is:
https://github.com/tianocore/edk2/commit/1c19ccd5103b
Switching to Intel host should rule that out at least.
(or use fixed edk2-ovmf-20240524-5.el10.noarch package from centos,
if you are forced to use AMD host)
> -boris
>
next prev parent reply other threads:[~2024-09-24 9:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 20:47 [PATCH] KVM/x86: Do not clear SIPI while in SMM Boris Ostrovsky
2024-04-16 20:53 ` Paolo Bonzini
2024-04-16 20:57 ` boris.ostrovsky
2024-04-16 22:03 ` Paolo Bonzini
2024-04-16 22:14 ` Sean Christopherson
2024-04-16 23:02 ` boris.ostrovsky
2024-04-16 22:56 ` boris.ostrovsky
2024-04-16 23:17 ` Sean Christopherson
2024-04-16 23:37 ` boris.ostrovsky
2024-04-17 12:40 ` Igor Mammedov
2024-04-17 13:58 ` boris.ostrovsky
2024-04-19 16:17 ` boris.ostrovsky
2024-09-24 9:40 ` Igor Mammedov [this message]
2024-09-24 21:59 ` boris.ostrovsky
2024-09-27 1:22 ` Eric Mackay
2024-09-27 9:28 ` Igor Mammedov
2024-09-30 23:34 ` Eric Mackay
2024-10-01 8:18 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240924114051.1d5f7470@imammedo.users.ipa.redhat.com \
--to=imammedo@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=eric.mackay@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox