Re: [RFC 01/29] nvkm/vgpu: introduce NVIDIA vGPU support prelude

Greg KH
2024-10-14T11:49:58Z

On Mon, Oct 14, 2024 at 09:59:18AM +0000, Zhi Wang wrote:
> On 26/09/2024 12.20, Greg KH wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > On Sun, Sep 22, 2024 at 05:49:23AM -0700, Zhi Wang wrote:
> >> NVIDIA GPU virtualization is a technology that allows multiple virtual
> >> machines (VMs) to share the power of a single GPU, enabling greater
> >> flexibility, efficiency, and cost-effectiveness in data centers and cloud
> >> environments.
> >>
> >> The first step of supporting NVIDIA vGPU in nvkm is to introduce the
> >> necessary vGPU data structures and functions to hook into the
> >> (de)initialization path of nvkm.
> >>
> >> Introduce NVIDIA vGPU data structures and functions hooking into the
> >> the (de)initialization path of nvkm and support the following patches.
> >>
> >> Cc: Neo Jia <cjia@nvidia.com>
> >> Cc: Surath Mitra <smitra@nvidia.com>
> >> Signed-off-by: Zhi Wang <zhiw@nvidia.com>
> >
> > Some minor comments that are a hint you all aren't running checkpatch on
> > your code...
> >
> >> --- /dev/null
> >> +++ b/drivers/gpu/drm/nouveau/include/nvkm/vgpu_mgr/vgpu_mgr.h
> >> @@ -0,0 +1,17 @@
> >> +/* SPDX-License-Identifier: MIT */
> >
> > Wait, what? Why? Ick. You all also forgot the copyright line :(
> >
>
> Will fix it accordingly.
>
> Back to the reason, I am trying to follow the majority in the nouveau
> since this is the change of nouveau.
>
> What's your guidelines about those already in the code?

My "guidelines" is that your lawyers agree what needs to be done and to
do that.

After that, my opinion is you do the proper thing and follow the kernel
licenses here, ESPECIALLY as you will be talking to gpl-only symbols
(hint, MIT licensed code doesn't make any sense there, and go get your
legal approval if you think it does...)

> >> +static bool support_vgpu_mgr = false;
> >
> > A global variable for the whole system? Are you sure that will work
> > well over time? Why isn't this a per-device thing?
> >
> >> +module_param_named(support_vgpu_mgr, support_vgpu_mgr, bool, 0400);
> >
> > This is not the 1990's, please never add new module parameters, use
> > per-device variables. And no documentation? That's not ok either even
> > if you did want to have this.
>
> Thanks for the comments. I am most collecting people opinion on the
> means of enabling/disabling the vGPU, via kernel parameter or not is
> just one of the options. If it is chosen, having a global kernel
> parameter is not expected to be in the !RFC patch.

That wasn't explained anywhere I noticed, did I miss it?

Please do this properly, again, kernel module parameters is not the
proper way.

> >> +static inline struct pci_dev *nvkm_to_pdev(struct nvkm_device *device)
> >> +{
> >> + struct nvkm_device_pci *pci = container_of(device, typeof(*pci),
> >> + device);
> >> +
> >> + return pci->pdev;
> >> +}
> >> +
> >> +/**
> >> + * nvkm_vgpu_mgr_is_supported - check if a platform support vGPU
> >> + * @device: the nvkm_device pointer
> >> + *
> >> + * Returns: true on supported platform which is newer than ADA Lovelace
> >> + * with SRIOV support.
> >> + */
> >> +bool nvkm_vgpu_mgr_is_supported(struct nvkm_device *device)
> >> +{
> >> + struct pci_dev *pdev = nvkm_to_pdev(device);
> >> +
> >> + if (!support_vgpu_mgr)
> >> + return false;
> >> +
> >> + return device->card_type == AD100 && pci_sriov_get_totalvfs(pdev);
> >
> > checkpatch please.
> >
>
> I did before sending it, but it doesn't complain this line.
>
> My command line
> $ scripts/checkpatch.pl [this patch]

Then something is odd as that ' ' should have been caught.

> > And "AD100" is an odd #define, as you know.
>
> I agree and people commented about it in the internal review. But it is
> from the nouveau driver and it has been used in many other places in
> nouveau driver. What would be your guidelines in this situation?

Something properly namespaced?

> >> +/**
> >> + * nvkm_vgpu_mgr_init - Initialize the vGPU manager support
> >> + * @device: the nvkm_device pointer
> >> + *
> >> + * Returns: 0 on success, -ENODEV on platforms that are not supported.
> >> + */
> >> +int nvkm_vgpu_mgr_init(struct nvkm_device *device)
> >> +{
> >> + struct nvkm_vgpu_mgr *vgpu_mgr = &device->vgpu_mgr;
> >> +
> >> + if (!nvkm_vgpu_mgr_is_supported(device))
> >> + return -ENODEV;
> >> +
> >> + vgpu_mgr->nvkm_dev = device;
> >> + vgpu_mgr->enabled = true;
> >> +
> >> + pci_info(nvkm_to_pdev(device),
> >> + "NVIDIA vGPU mananger support is enabled.\n");
> >
> > When drivers work properly, they are quiet.
> >
>
> I totally understand this rule that driver should be quiet. But this is
> not the same as "driver is loaded". This is a feature reporting like
> many others

And again, those "many others" need to be quiet too, we have many ways
to properly gather system information, and the kernel boot log is not
that.

> My concern is as nouveau is a kernel driver, when a user mets a kernel
> panic and offers a dmesg to analyze, it would be at least nice to know
> if the vGPU feature is turned on or not. Sysfs is doable, but it helps
> in different scenarios.

A kernel panic is usually way way way after this initial boot time
message. Again, keep the boot fast, and quiet please.

thanks,

greg k-h