* [kvm:kvm-coco-queue 62/109] arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: incorrect type in argument 1 (different address spaces)
@ 2024-10-12 8:09 kernel test robot
2024-10-14 16:34 ` Edgecombe, Rick P
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2024-10-12 8:09 UTC (permalink / raw)
To: Isaku Yamahata
Cc: oe-kbuild-all, kvm, Robert Hu, Farrah Chen, Danmei Wei,
Paolo Bonzini, Kai Huang, Yan Zhao, Rick Edgecombe
tree: https://git.kernel.org/pub/scm/virt/kvm/kvm.git kvm-coco-queue
head: d2c7662a6ea1c325a9ae878b3f1a265264bcd18b
commit: b6bcd88ad43aebc2385c7ff418b0532e80e60e19 [62/109] KVM: x86/tdp_mmu: Propagate building mirror page tables
config: x86_64-randconfig-121-20241011 (https://download.01.org/0day-ci/archive/20241012/202410121644.Eq7zRGPO-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241012/202410121644.Eq7zRGPO-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410121644.Eq7zRGPO-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile *v @@ got unsigned long long [noderef] [usertype] __rcu *__ai_ptr @@
arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: expected void const volatile *v
arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: got unsigned long long [noderef] [usertype] __rcu *__ai_ptr
>> arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: cast removes address space '__rcu' of expression
>> arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: cast removes address space '__rcu' of expression
>> arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: cast removes address space '__rcu' of expression
>> arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: cast removes address space '__rcu' of expression
>> arch/x86/kvm/mmu/tdp_mmu.c:754:29: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep @@
arch/x86/kvm/mmu/tdp_mmu.c:754:29: sparse: expected unsigned long long [usertype] *sptep
arch/x86/kvm/mmu/tdp_mmu.c:754:29: sparse: got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep
arch/x86/kvm/mmu/tdp_mmu.c:1246:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[addressable] [usertype] sptep @@
arch/x86/kvm/mmu/tdp_mmu.c:1246:25: sparse: expected unsigned long long [usertype] *sptep
arch/x86/kvm/mmu/tdp_mmu.c:1246:25: sparse: got unsigned long long [noderef] [usertype] __rcu *[addressable] [usertype] sptep
>> arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: dereference of noderef expression
>> arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: dereference of noderef expression
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep @@
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: expected unsigned long long [usertype] *sptep
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep
arch/x86/kvm/mmu/tdp_mmu.c: note: in included file (through include/linux/rbtree.h, include/linux/mm_types.h, include/linux/mmzone.h, ...):
include/linux/rcupdate.h:869:25: sparse: sparse: context imbalance in '__tdp_mmu_zap_root' - unexpected unlock
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep @@
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: expected unsigned long long [usertype] *sptep
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep @@
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: expected unsigned long long [usertype] *sptep
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep @@
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: expected unsigned long long [usertype] *sptep
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep
arch/x86/kvm/mmu/tdp_mmu.c:1536:33: sparse: sparse: context imbalance in 'tdp_mmu_split_huge_pages_root' - unexpected unlock
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep @@
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: expected unsigned long long [usertype] *sptep
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep @@
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: expected unsigned long long [usertype] *sptep
arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep
vim +474 arch/x86/kvm/mmu/tdp_mmu.c
455
456 static int __must_check set_external_spte_present(struct kvm *kvm, tdp_ptep_t sptep,
457 gfn_t gfn, u64 old_spte,
458 u64 new_spte, int level)
459 {
460 bool was_present = is_shadow_present_pte(old_spte);
461 bool is_present = is_shadow_present_pte(new_spte);
462 bool is_leaf = is_present && is_last_spte(new_spte, level);
463 kvm_pfn_t new_pfn = spte_to_pfn(new_spte);
464 int ret = 0;
465
466 KVM_BUG_ON(was_present, kvm);
467
468 lockdep_assert_held(&kvm->mmu_lock);
469 /*
470 * We need to lock out other updates to the SPTE until the external
471 * page table has been modified. Use FROZEN_SPTE similar to
472 * the zapping case.
473 */
> 474 if (!try_cmpxchg64(sptep, &old_spte, FROZEN_SPTE))
475 return -EBUSY;
476
477 /*
478 * Use different call to either set up middle level
479 * external page table, or leaf.
480 */
481 if (is_leaf) {
482 ret = static_call(kvm_x86_set_external_spte)(kvm, gfn, level, new_pfn);
483 } else {
484 void *external_spt = get_external_spt(gfn, new_spte, level);
485
486 KVM_BUG_ON(!external_spt, kvm);
487 ret = static_call(kvm_x86_link_external_spt)(kvm, gfn, level, external_spt);
488 }
489 if (ret)
490 __kvm_tdp_mmu_write_spte(sptep, old_spte);
491 else
492 __kvm_tdp_mmu_write_spte(sptep, new_spte);
493 return ret;
494 }
495
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [kvm:kvm-coco-queue 62/109] arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: incorrect type in argument 1 (different address spaces)
2024-10-12 8:09 [kvm:kvm-coco-queue 62/109] arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: incorrect type in argument 1 (different address spaces) kernel test robot
@ 2024-10-14 16:34 ` Edgecombe, Rick P
0 siblings, 0 replies; 2+ messages in thread
From: Edgecombe, Rick P @ 2024-10-14 16:34 UTC (permalink / raw)
To: lkp, Yamahata, Isaku
Cc: oe-kbuild-all@lists.linux.dev, Huang, Kai, Zhao, Yan Y,
robert.hu@intel.com, pbonzini@redhat.com, kvm@vger.kernel.org,
Chen, Farrah, danmei.wei@intel.com
On Sat, 2024-10-12 at 16:09 +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/virt/kvm/kvm.git kvm-coco-queue
> head: d2c7662a6ea1c325a9ae878b3f1a265264bcd18b
> commit: b6bcd88ad43aebc2385c7ff418b0532e80e60e19 [62/109] KVM: x86/tdp_mmu: Propagate building mirror page tables
> config: x86_64-randconfig-121-20241011 (https://download.01.org/0day-ci/archive/20241012/202410121644.Eq7zRGPO-lkp@intel.com/config)
> compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241012/202410121644.Eq7zRGPO-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202410121644.Eq7zRGPO-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
> > > arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile *v @@ got unsigned long long [noderef] [usertype] __rcu *__ai_ptr @@
> arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: expected void const volatile *v
> arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: got unsigned long long [noderef] [usertype] __rcu *__ai_ptr
> > > arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: cast removes address space '__rcu' of expression
> > > arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: cast removes address space '__rcu' of expression
> > > arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: cast removes address space '__rcu' of expression
> > > arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: cast removes address space '__rcu' of expression
> > > arch/x86/kvm/mmu/tdp_mmu.c:754:29: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep @@
> arch/x86/kvm/mmu/tdp_mmu.c:754:29: sparse: expected unsigned long long [usertype] *sptep
> arch/x86/kvm/mmu/tdp_mmu.c:754:29: sparse: got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep
> arch/x86/kvm/mmu/tdp_mmu.c:1246:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[addressable] [usertype] sptep @@
> arch/x86/kvm/mmu/tdp_mmu.c:1246:25: sparse: expected unsigned long long [usertype] *sptep
> arch/x86/kvm/mmu/tdp_mmu.c:1246:25: sparse: got unsigned long long [noderef] [usertype] __rcu *[addressable] [usertype] sptep
> > > arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: dereference of noderef expression
> > > arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: dereference of noderef expression
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep @@
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: expected unsigned long long [usertype] *sptep
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep
> arch/x86/kvm/mmu/tdp_mmu.c: note: in included file (through include/linux/rbtree.h, include/linux/mm_types.h, include/linux/mmzone.h, ...):
> include/linux/rcupdate.h:869:25: sparse: sparse: context imbalance in '__tdp_mmu_zap_root' - unexpected unlock
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep @@
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: expected unsigned long long [usertype] *sptep
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep @@
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: expected unsigned long long [usertype] *sptep
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep @@
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: expected unsigned long long [usertype] *sptep
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep
> arch/x86/kvm/mmu/tdp_mmu.c:1536:33: sparse: sparse: context imbalance in 'tdp_mmu_split_huge_pages_root' - unexpected unlock
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep @@
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: expected unsigned long long [usertype] *sptep
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected unsigned long long [usertype] *sptep @@ got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep @@
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: expected unsigned long long [usertype] *sptep
> arch/x86/kvm/mmu/tdp_mmu.c:618:33: sparse: got unsigned long long [noderef] [usertype] __rcu *[usertype] sptep
I think we need something like the below. The first hunk needs to target:
70caac283fb30 KVM: x86/mmu: Add an is_mirror member for union kvm_mmu_page_role
and the second:
161d4f7c6d80e KVM: x86/tdp_mmu: Propagate building mirror page tables
Should we send some proper fixup patches?
diff --git a/arch/x86/kvm/mmu/spte.h b/arch/x86/kvm/mmu/spte.h
index a72f0e3bde173..5d30d59bedfc0 100644
--- a/arch/x86/kvm/mmu/spte.h
+++ b/arch/x86/kvm/mmu/spte.h
@@ -267,9 +267,9 @@ static inline struct kvm_mmu_page *root_to_sp(hpa_t root)
return spte_to_child_sp(root);
}
-static inline bool is_mirror_sptep(u64 *sptep)
+static inline bool is_mirror_sptep(tdp_ptep_t sptep)
{
- return is_mirror_sp(sptep_to_sp(sptep));
+ return is_mirror_sp(sptep_to_sp(rcu_dereference((sptep))));
}
static inline bool is_mmio_spte(struct kvm *kvm, u64 spte)
diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c
index 019b43723d901..76512e05e31f2 100644
--- a/arch/x86/kvm/mmu/tdp_mmu.c
+++ b/arch/x86/kvm/mmu/tdp_mmu.c
@@ -511,7 +511,7 @@ static int __must_check set_external_spte_present(struct kvm
*kvm, tdp_ptep_t sp
* page table has been modified. Use FROZEN_SPTE similar to
* the zapping case.
*/
- if (!try_cmpxchg64(sptep, &old_spte, FROZEN_SPTE))
+ if (!try_cmpxchg64(rcu_dereference(sptep), &old_spte, FROZEN_SPTE))
return -EBUSY;
/*
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-14 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-12 8:09 [kvm:kvm-coco-queue 62/109] arch/x86/kvm/mmu/tdp_mmu.c:474:14: sparse: sparse: incorrect type in argument 1 (different address spaces) kernel test robot
2024-10-14 16:34 ` Edgecombe, Rick P
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox