Re: [PATCH v2 1/7] s390/kdump: implement is_kdump_kernel()

Heiko Carstens
2024-10-14T18:21:09Z

On Mon, Oct 14, 2024 at 04:46:13PM +0200, David Hildenbrand wrote:
> s390 currently always results in is_kdump_kernel() == false, because
> it sets "elfcorehdr_addr = ELFCORE_ADDR_MAX;" early during setup_arch to
> deactivate the elfcorehdr= kernel parameter.
>
> Let's follow the powerpc example and implement our own logic.
>
> This is required for virtio-mem to reliably identify a kdump
> environment to not try hotplugging memory.
>
> Tested-by: Mario Casquero <mcasquer@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> arch/s390/include/asm/kexec.h | 4 ++++
> arch/s390/kernel/crash_dump.c | 6 ++++++
> 2 files changed, 10 insertions(+)

Looks like this could work. But the comment in smp.c above
dump_available() needs to be updated.

Are you willing to do that, or should I provide an addon patch?