public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: borntraeger@de.ibm.com, nsg@linux.ibm.com, nrb@linux.ibm.com,
	frankja@linux.ibm.com, seiden@linux.ibm.com, hca@linux.ibm.com,
	agordeev@linux.ibm.com, gor@linux.ibm.com,
	gerald.schaefer@linux.ibm.com, kvm@vger.kernel.org,
	linux-s390@vger.kernel.org
Subject: [PATCH v3 09/11] s390/mm: Simplify get_fault_type()
Date: Tue, 15 Oct 2024 18:43:24 +0200	[thread overview]
Message-ID: <20241015164326.124987-10-imbrenda@linux.ibm.com> (raw)
In-Reply-To: <20241015164326.124987-1-imbrenda@linux.ibm.com>

From: Heiko Carstens <hca@linux.ibm.com>

With the gmap code gone get_fault_type() can be simplified:

- every fault with user_mode(regs) == true must be a fault in user address
  space

- every fault with user_mode(regs) == false is only a fault in user
  address space if the used address space is the secondary address space

- every other fault is within the kernel address space

Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Reviewed-by: Alexander Gordeev <agordeev@linux.ibm.com>
---
 arch/s390/mm/fault.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c
index e48910b0b816..6e96fc7905fc 100644
--- a/arch/s390/mm/fault.c
+++ b/arch/s390/mm/fault.c
@@ -68,17 +68,10 @@ static enum fault_type get_fault_type(struct pt_regs *regs)
 {
 	union teid teid = { .val = regs->int_parm_long };
 
-	if (likely(teid.as == PSW_BITS_AS_PRIMARY)) {
-		if (user_mode(regs))
-			return USER_FAULT;
-		return KERNEL_FAULT;
-	}
-	if (teid.as == PSW_BITS_AS_SECONDARY)
+	if (user_mode(regs))
 		return USER_FAULT;
-	/* Access register mode, not used in the kernel */
-	if (teid.as == PSW_BITS_AS_ACCREG)
+	if (teid.as == PSW_BITS_AS_SECONDARY)
 		return USER_FAULT;
-	/* Home space -> access via kernel ASCE */
 	return KERNEL_FAULT;
 }
 
-- 
2.47.0


  parent reply	other threads:[~2024-10-15 16:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 16:43 [PATCH v3 00/11] s390/kvm: Handle guest-related program interrupts in KVM Claudio Imbrenda
2024-10-15 16:43 ` [PATCH v3 01/11] s390/entry: Remove __GMAP_ASCE and use _PIF_GUEST_FAULT again Claudio Imbrenda
2024-10-15 16:43 ` [PATCH v3 02/11] s390/kvm: Remove kvm_arch_fault_in_page() Claudio Imbrenda
2024-10-15 16:43 ` [PATCH v3 03/11] s390/mm/gmap: Refactor gmap_fault() and add support for pfault Claudio Imbrenda
2024-10-21  9:41   ` Heiko Carstens
2024-10-15 16:43 ` [PATCH v3 04/11] s390/mm/gmap: Fix __gmap_fault() return code Claudio Imbrenda
2024-10-15 16:43 ` [PATCH v3 05/11] s390/mm/fault: Handle guest-related program interrupts in KVM Claudio Imbrenda
2024-10-16 10:05   ` Heiko Carstens
2024-10-16 14:34     ` Claudio Imbrenda
2024-10-15 16:43 ` [PATCH v3 06/11] s390/kvm: Stop using gmap_{en,dis}able() Claudio Imbrenda
2024-10-21  9:50   ` Heiko Carstens
2024-10-21 11:45     ` Claudio Imbrenda
2024-10-15 16:43 ` [PATCH v3 07/11] s390/mm/gmap: Remove gmap_{en,dis}able() Claudio Imbrenda
2024-10-21  9:50   ` Heiko Carstens
2024-10-15 16:43 ` [PATCH v3 08/11] s390: Remove gmap pointer from lowcore Claudio Imbrenda
2024-10-21  9:50   ` Heiko Carstens
2024-10-15 16:43 ` Claudio Imbrenda [this message]
2024-10-15 16:43 ` [PATCH v3 10/11] s390/mm: Get rid of fault type switch statements Claudio Imbrenda
2024-10-15 16:43 ` [PATCH v3 11/11] s390/mm: Convert to LOCK_MM_AND_FIND_VMA Claudio Imbrenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241015164326.124987-10-imbrenda@linux.ibm.com \
    --to=imbrenda@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=gerald.schaefer@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    --cc=nsg@linux.ibm.com \
    --cc=seiden@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox