Re: [kvm-unit-tests PATCH v4 4/6] s390x: Add library functions for exiting from snippet

Nico Boehr
2025-01-08T08:27:36Z

On Thu Dec 12, 2024 at 4:33 PM CET, Nina Schoetterl-Glausch wrote:
> On Tue, 2024-12-10 at 11:20 +0100, Nico Boehr wrote:
> > On Wed Oct 16, 2024 at 8:03 PM CEST, Nina Schoetterl-Glausch wrote:
> > > It is useful to be able to force an exit to the host from the snippet,
> > > as well as do so while returning a value.
> > > Add this functionality, also add helper functions for the host to check
> > > for an exit and get or check the value.
> > > Use diag 0x44 and 0x9c for this.
> > > Add a guest specific snippet header file and rename snippet.h to reflect
> > > that it is host specific.
> > >
> > > Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
> >
> > Hi Nina,
> >
> > would you mind if I fix this up like this?
>
> Looks good to me.
> Thanks!

Alright, thanks. It's now in the CI for coverage. When no issues come up, I will pick it.