From: Jason Gunthorpe <jgg@nvidia.com>
To: Yi Liu <yi.l.liu@intel.com>
Cc: joro@8bytes.org, kevin.tian@intel.com, baolu.lu@linux.intel.com,
will@kernel.org, alex.williamson@redhat.com,
eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org,
chao.p.peng@linux.intel.com, iommu@lists.linux.dev,
zhenzhong.duan@intel.com, vasant.hegde@amd.com
Subject: Re: [PATCH v2 3/3] iommu/vt-d: Make the blocked domain support PASID
Date: Fri, 18 Oct 2024 12:54:29 -0300 [thread overview]
Message-ID: <20241018155429.GI3559746@nvidia.com> (raw)
In-Reply-To: <20241018055824.24880-4-yi.l.liu@intel.com>
On Thu, Oct 17, 2024 at 10:58:24PM -0700, Yi Liu wrote:
> -static void intel_iommu_remove_dev_pasid(struct device *dev, ioasid_t pasid,
> - struct iommu_domain *domain)
> +static int blocking_domain_set_dev_pasid(struct iommu_domain *domain,
> + struct device *dev, ioasid_t pasid,
> + struct iommu_domain *old)
> {
> struct device_domain_info *info = dev_iommu_priv_get(dev);
> struct intel_iommu *iommu = info->iommu;
> @@ -4292,10 +4298,12 @@ static void intel_iommu_remove_dev_pasid(struct device *dev, ioasid_t pasid,
> INTEL_PASID_TEARDOWN_DRAIN_PRQ);
>
> /* Identity domain has no meta data for pasid. */
> - if (domain->type == IOMMU_DOMAIN_IDENTITY)
> - return;
> + if (old->type == IOMMU_DOMAIN_IDENTITY)
> + goto out;
Just return 0
Jason
next prev parent reply other threads:[~2024-10-18 15:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 5:58 [PATCH v2 0/3] Support attaching PASID to the blocked_domain Yi Liu
2024-10-18 5:58 ` [PATCH v2 1/3] iommu: Add a wrapper for remove_dev_pasid Yi Liu
2024-10-18 14:39 ` Jason Gunthorpe
2024-10-21 9:35 ` Yi Liu
2024-10-21 12:33 ` Jason Gunthorpe
2024-10-22 12:51 ` Yi Liu
2024-10-23 11:10 ` Vasant Hegde
2024-10-29 5:20 ` Yi Liu
2024-10-29 16:38 ` Vasant Hegde
2024-10-18 5:58 ` [PATCH v2 2/3] iommu/arm-smmu-v3: Make the blocked domain support PASID Yi Liu
2024-10-22 6:06 ` Nicolin Chen
2024-10-18 5:58 ` [PATCH v2 3/3] iommu/vt-d: " Yi Liu
2024-10-18 15:54 ` Jason Gunthorpe [this message]
2024-10-21 9:36 ` Yi Liu
2024-10-22 9:44 ` [PATCH v2 0/3] Support attaching PASID to the blocked_domain Vasant Hegde
2024-10-22 10:14 ` Yi Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018155429.GI3559746@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox