Re: [PATCH v5 17/37] KVM: arm64: Sanitise ID_AA64MMFR3_EL1

Joey Gouly
2024-10-24T12:46:54Z

On Thu, Oct 24, 2024 at 01:32:09PM +0100, Mark Brown wrote:
> On Wed, Oct 23, 2024 at 03:53:25PM +0100, Marc Zyngier wrote:
>
> > Add the missing sanitisation of ID_AA64MMFR3_EL1, making sure we
> > solely expose S1PIE and TCRX (we currently don't support anything
> > else).
>
> > case SYS_ID_AA64MMFR3_EL1:
> > - val &= ID_AA64MMFR3_EL1_TCRX | ID_AA64MMFR3_EL1_S1POE;
> > +
> > + val &= ID_AA64MMFR3_EL1_TCRX | ID_AA64MMFR3_EL1_S1POE |
> > + ID_AA64MMFR3_EL1_S1PIE;
>
> The changelog is now out of date, POE has been added.

This will disappear with a rebase won't it? Since you made the same change in
d4a89e5aee23 ("KVM: arm64: Expose S1PIE to guests"), in Linus' tree.

Thanks,
Joey