From: Raghavendra Rao Ananta <rananta@google.com>
To: Subhasish Ghosh <subhasish.ghosh@arm.com>,
Joey Gouly <joey.gouly@arm.com>,
Andrew Jones <andrew.jones@linux.dev>
Cc: Oliver Upton <oliver.upton@linux.dev>,
Marc Zyngier <maz@kernel.org>,
Raghavendra Rao Anata <rananta@google.com>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: [kvm-unit-tests PATCH v2 2/4] arm: fpu: Convert 'q' registers to 'v' to satisfy clang
Date: Wed, 23 Oct 2024 15:26:36 +0000 [thread overview]
Message-ID: <20241023152638.3317648-3-rananta@google.com> (raw)
In-Reply-To: <20241023152638.3317648-1-rananta@google.com>
Clang doesn't seem to support 'q' register notation in the clobbered
list, and hence throws the following error:
arm/fpu.c:235:3: error: unknown register name 'q0' in asm
fpu_reg_read(outdata);
^
arm/fpu.c:59:10: note: expanded from macro 'fpu_reg_read'
: "q0", "q1", "q2", "q3", \
^
arm/fpu.c:281:3: error: unknown register name 'q0' in asm
fpu_reg_write(*indata);
^
arm/fpu.c:92:10: note: expanded from macro 'fpu_reg_write'
: "q0", "q1", "q2", "q3", \
^
2 errors generated.
Hence, replace 'q' with 'v' registers for the clobbered list.
Fixes: d47d370c8f ("arm: Add test for FPU/SIMD context save/restore")
Signed-off-by: Raghavendra Rao Ananta <rananta@google.com>
---
arm/fpu.c | 40 ++++++++++++++++++++--------------------
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/arm/fpu.c b/arm/fpu.c
index edbd9a94..587b6ea3 100644
--- a/arm/fpu.c
+++ b/arm/fpu.c
@@ -56,16 +56,16 @@ static inline bool arch_collect_entropy(uint64_t *random)
"stp q30, q31, [%0], #32\n\t" \
: "=r" (__val) \
: \
- : "q0", "q1", "q2", "q3", \
- "q4", "q5", "q6", "q7", \
- "q8", "q9", "q10", "q11", \
- "q12", "q13", "q14", \
- "q15", "q16", "q17", \
- "q18", "q19", "q20", \
- "q21", "q22", "q23", \
- "q24", "q25", "q26", \
- "q27", "q28", "q29", \
- "q30", "q31", "memory"); \
+ : "v0", "v1", "v2", "v3", \
+ "v4", "v5", "v6", "v7", \
+ "v8", "v9", "v10", "v11", \
+ "v12", "v13", "v14", \
+ "v15", "v16", "v17", \
+ "v18", "v19", "v20", \
+ "v21", "v22", "v23", \
+ "v24", "v25", "v26", \
+ "v27", "v28", "v29", \
+ "v30", "v31", "memory"); \
})
#define fpu_reg_write(val) \
@@ -89,16 +89,16 @@ do { \
"ldp q30, q31, [%0], #32\n\t" \
: \
: "r" (__val) \
- : "q0", "q1", "q2", "q3", \
- "q4", "q5", "q6", "q7", \
- "q8", "q9", "q10", "q11", \
- "q12", "q13", "q14", \
- "q15", "q16", "q17", \
- "q18", "q19", "q20", \
- "q21", "q22", "q23", \
- "q24", "q25", "q26", \
- "q27", "q28", "q29", \
- "q30", "q31", "memory"); \
+ : "v0", "v1", "v2", "v3", \
+ "v4", "v5", "v6", "v7", \
+ "v8", "v9", "v10", "v11", \
+ "v12", "v13", "v14", \
+ "v15", "v16", "v17", \
+ "v18", "v19", "v20", \
+ "v21", "v22", "v23", \
+ "v24", "v25", "v26", \
+ "v27", "v28", "v29", \
+ "v30", "v31", "memory"); \
} while (0)
#ifdef CC_HAS_SVE
--
2.47.0.105.g07ac214952-goog
next prev parent reply other threads:[~2024-10-23 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 15:26 [kvm-unit-tests PATCH v2 0/4] Fix arm64 clang errors on fpu tests Raghavendra Rao Ananta
2024-10-23 15:26 ` [kvm-unit-tests PATCH v2 1/4] arm: Fix clang error in sve_vl() Raghavendra Rao Ananta
2024-10-23 15:26 ` Raghavendra Rao Ananta [this message]
2024-10-23 15:26 ` [kvm-unit-tests PATCH v2 3/4] arm: fpu: Add '.arch_extension fp' to fpu macros Raghavendra Rao Ananta
2024-10-23 15:26 ` [kvm-unit-tests PATCH v2 4/4] arm: fpu: Fix the input/output args for inline asm in fpu.c Raghavendra Rao Ananta
2024-10-24 8:31 ` [kvm-unit-tests PATCH 5/4] arm64: gitlab-ci: Add clang build tests Andrew Jones
2024-10-24 8:40 ` [kvm-unit-tests PATCH v2 0/4] Fix arm64 clang errors on fpu tests Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023152638.3317648-3-rananta@google.com \
--to=rananta@google.com \
--cc=andrew.jones@linux.dev \
--cc=joey.gouly@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=subhasish.ghosh@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox