From: Nikita Kalyazin <kalyazin@amazon.com>
To: <pbonzini@redhat.com>, <corbet@lwn.net>, <kvm@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <jthoughton@google.com>, <brijesh.singh@amd.com>,
<michael.roth@amd.com>, <graf@amazon.de>, <jgowans@amazon.com>,
<roypat@amazon.co.uk>, <derekmn@amazon.com>, <nsaenz@amazon.es>,
<xmarcalx@amazon.com>, <kalyazin@amazon.com>
Subject: [RFC PATCH 0/4] KVM: ioctl for populating guest_memfd
Date: Thu, 24 Oct 2024 09:54:25 +0000 [thread overview]
Message-ID: <20241024095429.54052-1-kalyazin@amazon.com> (raw)
Firecracker currently allows to populate guest memory from a separate
process via UserfaultFD [1]. This helps keep the VMM codebase and
functionality concise and generic, while offloading the logic of
obtaining guest memory to another process. UserfaultFD is currently not
supported for guest_memfd, because it binds to a VMA, while guest_memfd
does not need to (or cannot) be necessarily mapped to userspace,
especially for private memory. [2] proposes an alternative to
UserfaultFD for intercepting stage-2 faults, while this series
conceptually compliments it with the ability to populate guest memory
backed by guest_memfd for `KVM_X86_SW_PROTECTED_VM` VMs.
Patches 1-3 add a new ioctl, `KVM_GUEST_MEMFD_POPULATE`, that uses a
vendor-agnostic implementation of `post_populate` callback.
Patch 4 allows to call the ioctl from a separate (non-VMM) process. It
has been prohibited by [3], but I have not been able to locate the exact
justification for the requirement.
Questions:
- Does exposing a generic population interface via ioctl look
sensible in this form?
- Is there a path where "only VMM can call KVM API" requirement is
relaxed? If not, what is the recommended efficient alternative for
populating guest memory from outside the VMM?
[1]: https://github.com/firecracker-microvm/firecracker/blob/main/docs/snapshotting/handling-page-faults-on-snapshot-resume.md
[2]: https://lore.kernel.org/kvm/CADrL8HUHRMwUPhr7jLLBgD9YLFAnVHc=N-C=8er-x6GUtV97pQ@mail.gmail.com/T/
[3]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6d4e4c4fca5be806b888d606894d914847e82d78
Nikita
Nikita Kalyazin (4):
KVM: guest_memfd: add generic post_populate callback
KVM: add KVM_GUEST_MEMFD_POPULATE ioctl for guest_memfd
KVM: allow KVM_GUEST_MEMFD_POPULATE in another mm
KVM: document KVM_GUEST_MEMFD_POPULATE ioctl
Documentation/virt/kvm/api.rst | 23 +++++++++++++++++++++++
include/linux/kvm_host.h | 3 +++
include/uapi/linux/kvm.h | 9 +++++++++
virt/kvm/guest_memfd.c | 28 ++++++++++++++++++++++++++++
virt/kvm/kvm_main.c | 19 ++++++++++++++++++-
5 files changed, 81 insertions(+), 1 deletion(-)
base-commit: c8d430db8eec7d4fd13a6bea27b7086a54eda6da
--
2.40.1
next reply other threads:[~2024-10-24 9:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 9:54 Nikita Kalyazin [this message]
2024-10-24 9:54 ` [PATCH 1/4] KVM: guest_memfd: add generic post_populate callback Nikita Kalyazin
2024-11-22 18:40 ` Mike Day
2024-11-25 11:46 ` Nikita Kalyazin
2024-10-24 9:54 ` [PATCH 2/4] KVM: add KVM_GUEST_MEMFD_POPULATE ioctl for guest_memfd Nikita Kalyazin
2024-10-24 9:54 ` [PATCH 3/4] KVM: allow KVM_GUEST_MEMFD_POPULATE in another mm Nikita Kalyazin
2024-10-24 9:54 ` [PATCH 4/4] KVM: document KVM_GUEST_MEMFD_POPULATE ioctl Nikita Kalyazin
2024-11-20 12:09 ` [RFC PATCH 0/4] KVM: ioctl for populating guest_memfd Nikita Kalyazin
2024-11-20 13:46 ` David Hildenbrand
2024-11-20 15:13 ` David Hildenbrand
2024-11-20 15:58 ` Nikita Kalyazin
2024-11-20 16:20 ` David Hildenbrand
2024-11-20 16:44 ` David Hildenbrand
2024-11-20 17:21 ` Nikita Kalyazin
2024-11-20 18:29 ` David Hildenbrand
2024-11-21 16:46 ` Nikita Kalyazin
2024-11-26 16:04 ` Nikita Kalyazin
2024-11-28 12:11 ` David Hildenbrand
2024-11-20 13:55 ` Paolo Bonzini
2024-11-20 17:41 ` Nikita Kalyazin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024095429.54052-1-kalyazin@amazon.com \
--to=kalyazin@amazon.com \
--cc=brijesh.singh@amd.com \
--cc=corbet@lwn.net \
--cc=derekmn@amazon.com \
--cc=graf@amazon.de \
--cc=jgowans@amazon.com \
--cc=jthoughton@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=nsaenz@amazon.es \
--cc=pbonzini@redhat.com \
--cc=roypat@amazon.co.uk \
--cc=xmarcalx@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox