From: Yi Liu <yi.l.liu@intel.com>
To: joro@8bytes.org, jgg@nvidia.com, kevin.tian@intel.com,
baolu.lu@linux.intel.com
Cc: alex.williamson@redhat.com, eric.auger@redhat.com,
nicolinc@nvidia.com, kvm@vger.kernel.org,
chao.p.peng@linux.intel.com, yi.l.liu@intel.com,
iommu@lists.linux.dev, zhenzhong.duan@intel.com,
vasant.hegde@amd.com, will@kernel.org
Subject: [PATCH v3 7/7] iommu: Remove the remove_dev_pasid op
Date: Mon, 4 Nov 2024 05:20:33 -0800 [thread overview]
Message-ID: <20241104132033.14027-8-yi.l.liu@intel.com> (raw)
In-Reply-To: <20241104132033.14027-1-yi.l.liu@intel.com>
The iommu drivers that supports PASID have supported attaching pasid to the
blocked_domain, hence remove the remove_dev_pasid op from the iommu_ops.
Signed-off-by: Yi Liu <yi.l.liu@intel.com>
---
drivers/iommu/iommu.c | 17 ++++-------------
include/linux/iommu.h | 5 -----
2 files changed, 4 insertions(+), 18 deletions(-)
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index e8b2850cc61f..53f8e60acf30 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -3405,17 +3405,9 @@ static void iommu_remove_dev_pasid(struct device *dev, ioasid_t pasid,
{
const struct iommu_ops *ops = dev_iommu_ops(dev);
struct iommu_domain *blocked_domain = ops->blocked_domain;
- int ret = 1;
- if (blocked_domain && blocked_domain->ops->set_dev_pasid) {
- ret = blocked_domain->ops->set_dev_pasid(blocked_domain,
- dev, pasid, domain);
- } else if (ops->remove_dev_pasid) {
- ops->remove_dev_pasid(dev, pasid, domain);
- ret = 0;
- }
-
- WARN_ON(ret);
+ WARN_ON(blocked_domain->ops->set_dev_pasid(blocked_domain,
+ dev, pasid, domain));
}
static int __iommu_set_group_pasid(struct iommu_domain *domain,
@@ -3474,9 +3466,8 @@ int iommu_attach_device_pasid(struct iommu_domain *domain,
int ret;
if (!domain->ops->set_dev_pasid ||
- (!ops->remove_dev_pasid &&
- (!ops->blocked_domain ||
- !ops->blocked_domain->ops->set_dev_pasid)))
+ !ops->blocked_domain ||
+ !ops->blocked_domain->ops->set_dev_pasid)
return -EOPNOTSUPP;
if (!group)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 2ec0c9915aa5..257b1a53879a 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -537,9 +537,6 @@ static inline int __iommu_copy_struct_from_user_array(
* - IOMMU_DOMAIN_DMA: must use a dma domain
* - 0: use the default setting
* @default_domain_ops: the default ops for domains
- * @remove_dev_pasid: Remove any translation configurations of a specific
- * pasid, so that any DMA transactions with this pasid
- * will be blocked by the hardware.
* @pgsize_bitmap: bitmap of all possible supported page sizes
* @owner: Driver module providing these ops
* @identity_domain: An always available, always attachable identity
@@ -586,8 +583,6 @@ struct iommu_ops {
struct iommu_page_response *msg);
int (*def_domain_type)(struct device *dev);
- void (*remove_dev_pasid)(struct device *dev, ioasid_t pasid,
- struct iommu_domain *domain);
const struct iommu_domain_ops *default_domain_ops;
unsigned long pgsize_bitmap;
--
2.34.1
next prev parent reply other threads:[~2024-11-04 13:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 13:20 [PATCH v3 0/7] Support attaching PASID to the blocked_domain Yi Liu
2024-11-04 13:20 ` [PATCH v3 1/7] iommu: Prevent pasid attach if no ops->remove_dev_pasid Yi Liu
2024-11-05 15:42 ` Jason Gunthorpe
2024-11-07 9:33 ` Tian, Kevin
2024-11-07 10:02 ` Yi Liu
2024-11-04 13:20 ` [PATCH v3 2/7] iommu: Consolidate the ops->remove_dev_pasid usage into a helper Yi Liu
2024-11-05 15:42 ` Jason Gunthorpe
2024-11-06 9:33 ` Vasant Hegde
2024-11-07 9:34 ` Tian, Kevin
2024-11-04 13:20 ` [PATCH v3 3/7] iommu: Detaching pasid by attaching to the blocked_domain Yi Liu
2024-11-05 15:42 ` Jason Gunthorpe
2024-11-06 9:37 ` Vasant Hegde
2024-11-07 9:35 ` Tian, Kevin
2024-11-07 10:04 ` Yi Liu
2024-11-04 13:20 ` [PATCH v3 4/7] iommu/arm-smmu-v3: Make the blocked domain support PASID Yi Liu
2024-11-04 13:20 ` [PATCH v3 5/7] iommu/vt-d: " Yi Liu
2024-11-05 3:46 ` Baolu Lu
2024-11-05 5:11 ` Yi Liu
2024-11-05 5:45 ` Baolu Lu
2024-11-05 15:43 ` Jason Gunthorpe
2024-11-04 13:20 ` [PATCH v3 6/7] iommu/amd: " Yi Liu
2024-11-05 15:44 ` Jason Gunthorpe
2024-11-06 9:27 ` Vasant Hegde
2024-11-07 9:36 ` Tian, Kevin
2024-11-04 13:20 ` Yi Liu [this message]
2024-11-05 15:44 ` [PATCH v3 7/7] iommu: Remove the remove_dev_pasid op Jason Gunthorpe
2024-11-06 9:39 ` Vasant Hegde
2024-11-07 9:37 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104132033.14027-8-yi.l.liu@intel.com \
--to=yi.l.liu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox