Re: [RFC PATCH 01/15] irqchip/riscv-imsic: Use hierarchy to reach irq_set_affinity

Thomas Gleixner
2024-12-03T20:55:35Z

On Tue, Dec 03 2024 at 22:07, Anup Patel wrote:
> On Tue, Dec 3, 2024 at 7:23 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>> Sorry, I missed that when reviewing the original IMSIC MSI support.
>>
>> The whole IMSIC MSI support can be moved over to MSI LIB which makes all
>> of this indirection go away and your intermediate domain will just fit
>> in.
>>
>> Uncompiled patch below. If that works, it needs to be split up properly.
>>
>> Note, this removes the setup of the irq_retrigger callback, but that's
>> fine because on hierarchical domains irq_chip_retrigger_hierarchy() is
>> invoked anyway. See try_retrigger().
>
> The IMSIC driver was merged one kernel release before common
> MSI LIB was merged.

Ah indeed.

> We should definitely update the IMSIC driver to use MSI LIB, I will
> try your suggested changes (below) and post a separate series.

Pick up the delta patch I gave Andrew...