From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B9861A01BE for ; Mon, 25 Nov 2024 12:08:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732536532; cv=none; b=n6rtmqsMHciO3/S6terQZLYzhZTUx8pNkEWK5/MI/EY1xpjht/bt0SEomNslxp5dsM/bQjZkpjXaM+z2K9qI3m+alQwPI45WkwP7FEa8dq2mENnfC2kgA2sAM9N7V3O0PWo304TsQFiwWFtXyYBJjquWFApMP0PO4XOGMEUU55w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732536532; c=relaxed/simple; bh=MLOsvRZ/ecr2Y/Jx8is/W8Kgryf9gi/kqVRqbk12X34=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qn30qBiW7VussiS+t9d3T4LoAEzOkDjO1bP+NmI7mM8zMMq/ximArl/XCW8tLOgrpwKDGqKI262gqi99ckRRnoTUP+S3ZlflUMyCebYseXzWrmcEagmmc2/ez3Sn+e2nhBPmS4yRbE49PNffa6DTxwqld74GvphMpyy3bC5G1do= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=FHIHd9ku; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="FHIHd9ku" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-434a099ba95so5356775e9.0 for ; Mon, 25 Nov 2024 04:08:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1732536528; x=1733141328; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rtGYra4ZiucyLvI8CA3+YqcIlZT99r5pBwc2AIGV96M=; b=FHIHd9kuk+HOH6mEcaJc8ZBuVcZkTiPS7KGTghK16k06LigipTuauIY/tb+NGiLsDC j/cOOwzEF8wz3+GlL5666TTnuAaoPQuxVUeCzCu6dUwn85OEd2vMGwo2cmCwx5oKXP/J 5ywXdSZvXQ++0tKYPbMsP2Sy1K/PjnVYr9W2oro58nUhFxEf8RaqkymvXuuRtIwfJS33 0+0IT5NdFvh+j+gTHmGm46woE7fRCStKAqeDwXpVGVwd5BdXukf1n2SJ7tptc8V2dwn6 F0pIEJNXLhS8Ct3pzS8g0yDYdOdNdPqX3Mb1aeuV5stBoEVjXAk+tmZXhbvvRI0ZeGFv qJkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732536528; x=1733141328; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rtGYra4ZiucyLvI8CA3+YqcIlZT99r5pBwc2AIGV96M=; b=sbh63C/GXU1gCkQWAw5l/Loz6LEIDc6CDTSLFrxwXc9OTsCcVb2gNHIuCpy5TNOsfY E4TPpwWfV3vVsel0m7OLNCe3u1HTxuHH9Jv1d1BDnghTpaDBVuYBActQXToKZ/LeM+LX esfb32g/KmiVMtmVLOaJxdt3COLqbduGXHAv+PR7RSD2SNUEiu6U8vzbXVwQe4q6Tv15 62m9TRZHcDWbvvUZS1ZHynqXfPFJTA4FBRHnnLXSsGZcXX2axqBvBXGtAhk7iTeYoZVn pHZWQc6N4ns953RE3mJXr3R51Ct77i9KsJ6GAcWsDNk2q6wuXZRNapgcV2PQi2MZyPHp z1Wg== X-Forwarded-Encrypted: i=1; AJvYcCXVH7mlG3Z8kW4CEPCBHrWXUyfDbs+MuoJ07nYAqONr3gLWYwXVg3P9wn+sMGxhgvvFX4U=@vger.kernel.org X-Gm-Message-State: AOJu0YwBi9xjMEDkGw48EKpUkbks3tyQqyUu8fOsYY9MRjredOqPdaJ3 qjR0blNAaLIf4NEnmdqmAoulmQ4Hn8/tKRAU5AVufAnpCnb/8/h0/166Oyqoi9I= X-Gm-Gg: ASbGncsxAbRaAjHoQ8BDPdU1N7V/N43FDb/7pNg90RcyTOMPQeJ6eVgdYj4kzslvzTq BgamQxrck6vdpT0l6IP/COlgbpnqdrTcKdy1bgEBq3SmkDcUUl1UP5INrdtdyJVEGf2EtODnPsr dejDbCegEUD0CHRZOFqhBlucDH8LRB4fnpmRPsPtPveszP3/9865FWsMn0VYrf8O8gi6efkQWGQ VSJqZWpqhDbKU0a8ROreJ163lb9arM90drJ9M3BODi2YmMtypc8DLJtcOjqf6o2O66KOImf8Fu+ g6If8qc6jVyQmn8NAP+u5k85UMdTj03Jrq8= X-Google-Smtp-Source: AGHT+IEcHSdgJj5nANfMThAU2OGxyIx79hhPO8lC6bsUu2hPonUhJGs8xsqe5h4w4zgbyjw1N3+XCw== X-Received: by 2002:a7b:ce91:0:b0:434:9de2:b101 with SMTP id 5b1f17b1804b1-4349de2b333mr40945755e9.2.1732536528430; Mon, 25 Nov 2024 04:08:48 -0800 (PST) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434a02f2ea1sm29588115e9.34.2024.11.25.04.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2024 04:08:48 -0800 (PST) Date: Mon, 25 Nov 2024 13:08:47 +0100 From: Andrew Jones To: Max Hsu Cc: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Anup Patel , Atish Patra , Palmer Dabbelt , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, Samuel Holland Subject: Re: [PATCH RFC v3 3/3] riscv: KVM: Add Svukte extension support for Guest/VM Message-ID: <20241125-7cfad4185ec1a66fa08ff0f0@orel> References: <20241120-dev-maxh-svukte-v3-v3-0-1e533d41ae15@sifive.com> <20241120-dev-maxh-svukte-v3-v3-3-1e533d41ae15@sifive.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241120-dev-maxh-svukte-v3-v3-3-1e533d41ae15@sifive.com> On Wed, Nov 20, 2024 at 10:09:34PM +0800, Max Hsu wrote: > Add KVM_RISCV_ISA_EXT_SVUKTE for VMM to detect the enablement > or disablement the Svukte extension for Guest/VM > > Reviewed-by: Samuel Holland > Signed-off-by: Max Hsu > --- > arch/riscv/include/uapi/asm/kvm.h | 1 + > arch/riscv/kvm/vcpu_onereg.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/arch/riscv/include/uapi/asm/kvm.h b/arch/riscv/include/uapi/asm/kvm.h > index 4f24201376b17215315cf1fb8888d0a562dc76ac..158f9253658c4c28a533b2bda179fb48bf41e1fc 100644 > --- a/arch/riscv/include/uapi/asm/kvm.h > +++ b/arch/riscv/include/uapi/asm/kvm.h > @@ -177,6 +177,7 @@ enum KVM_RISCV_ISA_EXT_ID { > KVM_RISCV_ISA_EXT_ZAWRS, > KVM_RISCV_ISA_EXT_SMNPM, > KVM_RISCV_ISA_EXT_SSNPM, > + KVM_RISCV_ISA_EXT_SVUKTE, > KVM_RISCV_ISA_EXT_MAX, > }; > > diff --git a/arch/riscv/kvm/vcpu_onereg.c b/arch/riscv/kvm/vcpu_onereg.c > index 5b68490ad9b75fef6a18289d8c5cf9291594e01e..4c3a77cdeed0956e21e53d1ab4e948a170ac5c5c 100644 > --- a/arch/riscv/kvm/vcpu_onereg.c > +++ b/arch/riscv/kvm/vcpu_onereg.c > @@ -43,6 +43,7 @@ static const unsigned long kvm_isa_ext_arr[] = { > KVM_ISA_EXT_ARR(SVINVAL), > KVM_ISA_EXT_ARR(SVNAPOT), > KVM_ISA_EXT_ARR(SVPBMT), > + KVM_ISA_EXT_ARR(SVUKTE), > KVM_ISA_EXT_ARR(ZACAS), > KVM_ISA_EXT_ARR(ZAWRS), > KVM_ISA_EXT_ARR(ZBA), > > -- > 2.43.2 Anup raised the missing entry in kvm_riscv_vcpu_isa_disable_allowed() in the last review. An additional paragraph was added to the cover letter for this review, but I think there's still a misunderstanding. If the guest can always use the extension (whether it's advertised in its ISA string or not), then that means it cannot be disabled from the perspective of the VMM. The only ISA extensions which may be disabled are the ones that trap on their use, allowing KVM to emulate responses which a physical hart without the extension would produce. Thanks, drew