public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Tom Lendacky <thomas.lendacky@amd.com>,
	Binbin Wu <binbin.wu@linux.intel.com>,
	 Isaku Yamahata <isaku.yamahata@intel.com>,
	Kai Huang <kai.huang@intel.com>,
	 Xiaoyao Li <xiaoyao.li@intel.com>
Subject: [PATCH v4 0/6] KVM: x86: Prep KVM hypercall handling for TDX
Date: Wed, 27 Nov 2024 16:43:38 -0800	[thread overview]
Message-ID: <20241128004344.4072099-1-seanjc@google.com> (raw)

Effectively v4 of Binbin's series to handle hypercall exits to userspace in
a generic manner, so that TDX

Binbin and Kai, this is fairly different that what we last discussed.  While
sorting through Binbin's latest patch, I stumbled on what I think/hope is an
approach that will make life easier for TDX.  Rather than have common code
set the return value, _and_ have TDX implement a callback to do the same for
user return MSRs, just use the callback for all paths.

As for abusing vcpu->run->hypercall.ret... It's obviously a bit gross, but
I think it's a lesser evil than having multiple a one-line wrappers just to
trampoline in the return code.

v4:
 - Fix an SEV-* bug where KVM trips the WARN in is_64_bit_mode().
 - Add a pile of reworks to (hopefully) avoid as much duplicate code when
   TDX comes along.

v3: https://lore.kernel.org/all/20240826022255.361406-1-binbin.wu@linux.intel.com

Binbin Wu (1):
  KVM: x86: Add a helper to check for user interception of KVM
    hypercalls

Sean Christopherson (5):
  KVM: x86: Play nice with protected guests in complete_hypercall_exit()
  KVM: x86: Move "emulate hypercall" function declarations to x86.h
  KVM: x86: Bump hypercall stat prior to fully completing hypercall
  KVM: x86: Always complete hypercall via function callback
  KVM: x86: Refactor __kvm_emulate_hypercall() into a macro

 arch/x86/include/asm/kvm_host.h |  6 ----
 arch/x86/kvm/svm/sev.c          |  4 +--
 arch/x86/kvm/x86.c              | 50 +++++++++++----------------------
 arch/x86/kvm/x86.h              | 28 ++++++++++++++++++
 4 files changed, 47 insertions(+), 41 deletions(-)


base-commit: 4d911c7abee56771b0219a9fbf0120d06bdc9c14
-- 
2.47.0.338.g60cca15819-goog


             reply	other threads:[~2024-11-28  0:43 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-28  0:43 Sean Christopherson [this message]
2024-11-28  0:43 ` [PATCH v4 1/6] KVM: x86: Play nice with protected guests in complete_hypercall_exit() Sean Christopherson
2024-11-28  3:22   ` Xiaoyao Li
2024-11-29  9:01   ` Nikunj A. Dadhania
2024-12-02 18:54   ` Tom Lendacky
2024-12-03  7:29   ` Binbin Wu
2024-11-28  0:43 ` [PATCH v4 2/6] KVM: x86: Add a helper to check for user interception of KVM hypercalls Sean Christopherson
2024-12-02 18:57   ` Tom Lendacky
2024-11-28  0:43 ` [PATCH v4 3/6] KVM: x86: Move "emulate hypercall" function declarations to x86.h Sean Christopherson
2024-11-28  3:23   ` Xiaoyao Li
2024-12-02 20:05   ` Tom Lendacky
2024-12-03  7:33   ` Binbin Wu
2024-11-28  0:43 ` [PATCH v4 4/6] KVM: x86: Bump hypercall stat prior to fully completing hypercall Sean Christopherson
2024-11-28  3:24   ` Xiaoyao Li
2024-12-02 20:13   ` Tom Lendacky
2024-12-02 20:33     ` Tom Lendacky
2024-12-03  7:37   ` Binbin Wu
2024-11-28  0:43 ` [PATCH v4 5/6] KVM: x86: Always complete hypercall via function callback Sean Christopherson
2024-11-28  3:08   ` Xiaoyao Li
2024-12-02 18:44     ` Sean Christopherson
2024-12-02 20:57   ` Tom Lendacky
2024-12-02 20:59     ` Tom Lendacky
2024-12-03  0:14       ` Sean Christopherson
2024-11-28  0:43 ` [PATCH v4 6/6] KVM: x86: Refactor __kvm_emulate_hypercall() into a macro Sean Christopherson
2024-11-28  8:38   ` Adrian Hunter
2024-12-10 16:20     ` Paolo Bonzini
2024-12-10 20:03       ` Sean Christopherson
2024-12-12  7:32         ` Adrian Hunter
2024-12-12 15:42           ` Paolo Bonzini
2024-12-12 18:40           ` Sean Christopherson
2024-12-03  8:01   ` Binbin Wu
2024-12-10 16:17   ` Paolo Bonzini
2024-12-10 20:10     ` Sean Christopherson
2024-11-28  1:06 ` [PATCH v4 0/6] KVM: x86: Prep KVM hypercall handling for TDX Huang, Kai
2024-12-19  2:40 ` Sean Christopherson
2025-01-15  9:40   ` Binbin Wu
2025-01-17 19:31     ` Sean Christopherson
2025-01-20  0:37       ` Binbin Wu
2025-01-21 18:04         ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241128004344.4072099-1-seanjc@google.com \
    --to=seanjc@google.com \
    --cc=binbin.wu@linux.intel.com \
    --cc=isaku.yamahata@intel.com \
    --cc=kai.huang@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=thomas.lendacky@amd.com \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox