From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Lendacky <thomas.lendacky@amd.com>,
Binbin Wu <binbin.wu@linux.intel.com>,
Isaku Yamahata <isaku.yamahata@intel.com>,
Kai Huang <kai.huang@intel.com>,
Xiaoyao Li <xiaoyao.li@intel.com>
Subject: [PATCH v4 2/6] KVM: x86: Add a helper to check for user interception of KVM hypercalls
Date: Wed, 27 Nov 2024 16:43:40 -0800 [thread overview]
Message-ID: <20241128004344.4072099-3-seanjc@google.com> (raw)
In-Reply-To: <20241128004344.4072099-1-seanjc@google.com>
From: Binbin Wu <binbin.wu@linux.intel.com>
Add and use user_exit_on_hypercall() to check if userspace wants to handle
a KVM hypercall instead of open-coding the logic everywhere.
No functional change intended.
Signed-off-by: Binbin Wu <binbin.wu@linux.intel.com>
Reviewed-by: Isaku Yamahata <isaku.yamahata@intel.com>
Reviewed-by: Kai Huang <kai.huang@intel.com>
Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>
[sean: squash into one patch, keep explicit KVM_HC_MAP_GPA_RANGE check]
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
arch/x86/kvm/svm/sev.c | 4 ++--
arch/x86/kvm/x86.c | 2 +-
arch/x86/kvm/x86.h | 5 +++++
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
index 72674b8825c4..6ac6312c4d57 100644
--- a/arch/x86/kvm/svm/sev.c
+++ b/arch/x86/kvm/svm/sev.c
@@ -3640,7 +3640,7 @@ static int snp_begin_psc_msr(struct vcpu_svm *svm, u64 ghcb_msr)
return 1; /* resume guest */
}
- if (!(vcpu->kvm->arch.hypercall_exit_enabled & (1 << KVM_HC_MAP_GPA_RANGE))) {
+ if (!user_exit_on_hypercall(vcpu->kvm, KVM_HC_MAP_GPA_RANGE)) {
set_ghcb_msr(svm, GHCB_MSR_PSC_RESP_ERROR);
return 1; /* resume guest */
}
@@ -3723,7 +3723,7 @@ static int snp_begin_psc(struct vcpu_svm *svm, struct psc_buffer *psc)
bool huge;
u64 gfn;
- if (!(vcpu->kvm->arch.hypercall_exit_enabled & (1 << KVM_HC_MAP_GPA_RANGE))) {
+ if (!user_exit_on_hypercall(vcpu->kvm, KVM_HC_MAP_GPA_RANGE)) {
snp_complete_psc(svm, VMGEXIT_PSC_ERROR_GENERIC);
return 1;
}
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 0b2fe4aa04a2..13fe5d6eb8f3 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -10041,7 +10041,7 @@ unsigned long __kvm_emulate_hypercall(struct kvm_vcpu *vcpu, unsigned long nr,
u64 gpa = a0, npages = a1, attrs = a2;
ret = -KVM_ENOSYS;
- if (!(vcpu->kvm->arch.hypercall_exit_enabled & (1 << KVM_HC_MAP_GPA_RANGE)))
+ if (!user_exit_on_hypercall(vcpu->kvm, KVM_HC_MAP_GPA_RANGE))
break;
if (!PAGE_ALIGNED(gpa) || !npages ||
diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h
index ec623d23d13d..45dd53284dbd 100644
--- a/arch/x86/kvm/x86.h
+++ b/arch/x86/kvm/x86.h
@@ -612,4 +612,9 @@ int kvm_sev_es_string_io(struct kvm_vcpu *vcpu, unsigned int size,
unsigned int port, void *data, unsigned int count,
int in);
+static inline bool user_exit_on_hypercall(struct kvm *kvm, unsigned long hc_nr)
+{
+ return kvm->arch.hypercall_exit_enabled & BIT(hc_nr);
+}
+
#endif
--
2.47.0.338.g60cca15819-goog
next prev parent reply other threads:[~2024-11-28 0:43 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 0:43 [PATCH v4 0/6] KVM: x86: Prep KVM hypercall handling for TDX Sean Christopherson
2024-11-28 0:43 ` [PATCH v4 1/6] KVM: x86: Play nice with protected guests in complete_hypercall_exit() Sean Christopherson
2024-11-28 3:22 ` Xiaoyao Li
2024-11-29 9:01 ` Nikunj A. Dadhania
2024-12-02 18:54 ` Tom Lendacky
2024-12-03 7:29 ` Binbin Wu
2024-11-28 0:43 ` Sean Christopherson [this message]
2024-12-02 18:57 ` [PATCH v4 2/6] KVM: x86: Add a helper to check for user interception of KVM hypercalls Tom Lendacky
2024-11-28 0:43 ` [PATCH v4 3/6] KVM: x86: Move "emulate hypercall" function declarations to x86.h Sean Christopherson
2024-11-28 3:23 ` Xiaoyao Li
2024-12-02 20:05 ` Tom Lendacky
2024-12-03 7:33 ` Binbin Wu
2024-11-28 0:43 ` [PATCH v4 4/6] KVM: x86: Bump hypercall stat prior to fully completing hypercall Sean Christopherson
2024-11-28 3:24 ` Xiaoyao Li
2024-12-02 20:13 ` Tom Lendacky
2024-12-02 20:33 ` Tom Lendacky
2024-12-03 7:37 ` Binbin Wu
2024-11-28 0:43 ` [PATCH v4 5/6] KVM: x86: Always complete hypercall via function callback Sean Christopherson
2024-11-28 3:08 ` Xiaoyao Li
2024-12-02 18:44 ` Sean Christopherson
2024-12-02 20:57 ` Tom Lendacky
2024-12-02 20:59 ` Tom Lendacky
2024-12-03 0:14 ` Sean Christopherson
2024-11-28 0:43 ` [PATCH v4 6/6] KVM: x86: Refactor __kvm_emulate_hypercall() into a macro Sean Christopherson
2024-11-28 8:38 ` Adrian Hunter
2024-12-10 16:20 ` Paolo Bonzini
2024-12-10 20:03 ` Sean Christopherson
2024-12-12 7:32 ` Adrian Hunter
2024-12-12 15:42 ` Paolo Bonzini
2024-12-12 18:40 ` Sean Christopherson
2024-12-03 8:01 ` Binbin Wu
2024-12-10 16:17 ` Paolo Bonzini
2024-12-10 20:10 ` Sean Christopherson
2024-11-28 1:06 ` [PATCH v4 0/6] KVM: x86: Prep KVM hypercall handling for TDX Huang, Kai
2024-12-19 2:40 ` Sean Christopherson
2025-01-15 9:40 ` Binbin Wu
2025-01-17 19:31 ` Sean Christopherson
2025-01-20 0:37 ` Binbin Wu
2025-01-21 18:04 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241128004344.4072099-3-seanjc@google.com \
--to=seanjc@google.com \
--cc=binbin.wu@linux.intel.com \
--cc=isaku.yamahata@intel.com \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thomas.lendacky@amd.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox