From: Nikunj A Dadhania <nikunj@amd.com>
To: <linux-kernel@vger.kernel.org>, <thomas.lendacky@amd.com>,
<bp@alien8.de>, <x86@kernel.org>, <kvm@vger.kernel.org>
Cc: <mingo@redhat.com>, <tglx@linutronix.de>,
<dave.hansen@linux.intel.com>, <pgonda@google.com>,
<seanjc@google.com>, <pbonzini@redhat.com>, <nikunj@amd.com>
Subject: [PATCH v15 06/13] x86/sev: Prevent GUEST_TSC_FREQ MSR interception for Secure TSC enabled guests
Date: Tue, 3 Dec 2024 14:30:38 +0530 [thread overview]
Message-ID: <20241203090045.942078-7-nikunj@amd.com> (raw)
In-Reply-To: <20241203090045.942078-1-nikunj@amd.com>
The hypervisor should not be intercepting GUEST_TSC_FREQ MSR(0xcOO10134)
when Secure TSC is enabled. A #VC exception will be generated if the
GUEST_TSC_FREQ MSR is being intercepted. If this should occur and SecureTSC
is enabled, terminate guest execution.
Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
---
arch/x86/include/asm/msr-index.h | 1 +
arch/x86/coco/sev/core.c | 8 ++++++++
2 files changed, 9 insertions(+)
diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h
index 3ae84c3b8e6d..233be13cc21f 100644
--- a/arch/x86/include/asm/msr-index.h
+++ b/arch/x86/include/asm/msr-index.h
@@ -608,6 +608,7 @@
#define MSR_AMD_PERF_CTL 0xc0010062
#define MSR_AMD_PERF_STATUS 0xc0010063
#define MSR_AMD_PSTATE_DEF_BASE 0xc0010064
+#define MSR_AMD64_GUEST_TSC_FREQ 0xc0010134
#define MSR_AMD64_OSVW_ID_LENGTH 0xc0010140
#define MSR_AMD64_OSVW_STATUS 0xc0010141
#define MSR_AMD_PPIN_CTL 0xc00102f0
diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c
index af28fb962309..59c5e716fdd1 100644
--- a/arch/x86/coco/sev/core.c
+++ b/arch/x86/coco/sev/core.c
@@ -1473,6 +1473,14 @@ static enum es_result vc_handle_msr(struct ghcb *ghcb, struct es_em_ctxt *ctxt)
if (regs->cx == MSR_IA32_TSC && (sev_status & MSR_AMD64_SNP_SECURE_TSC))
return __vc_handle_msr_tsc(regs, write);
+ /*
+ * GUEST_TSC_FREQ should not be intercepted when Secure TSC is
+ * enabled. Terminate the SNP guest when the interception is enabled.
+ */
+ if (regs->cx == MSR_AMD64_GUEST_TSC_FREQ && (sev_status & MSR_AMD64_SNP_SECURE_TSC))
+ return ES_VMM_ERROR;
+
+
ghcb_set_rcx(ghcb, regs->cx);
if (write) {
ghcb_set_rax(ghcb, regs->ax);
--
2.34.1
next prev parent reply other threads:[~2024-12-03 9:01 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 9:00 [PATCH v15 00/13] Add Secure TSC support for SNP guests Nikunj A Dadhania
2024-12-03 9:00 ` [PATCH v15 01/13] x86/sev: Carve out and export SNP guest messaging init routines Nikunj A Dadhania
2024-12-03 14:19 ` Borislav Petkov
2024-12-03 14:35 ` Nikunj A. Dadhania
2024-12-03 14:50 ` Borislav Petkov
2024-12-03 14:52 ` Nikunj A. Dadhania
2024-12-04 9:30 ` Nikunj A. Dadhania
2024-12-04 10:00 ` Nikunj A. Dadhania
2024-12-04 20:02 ` Borislav Petkov
2024-12-05 6:23 ` Nikunj A. Dadhania
2024-12-06 20:27 ` Borislav Petkov
2024-12-07 0:27 ` Dionna Amalie Glaze
2024-12-09 15:36 ` Borislav Petkov
2024-12-09 6:16 ` Nikunj A. Dadhania
2024-12-09 15:38 ` Borislav Petkov
2024-12-10 6:38 ` Nikunj A Dadhania
2025-01-04 19:06 ` Francesco Lavra
2025-01-06 4:14 ` Nikunj A. Dadhania
2024-12-03 9:00 ` [PATCH v15 02/13] x86/sev: Relocate SNP guest messaging routines to common code Nikunj A Dadhania
2024-12-04 20:20 ` Borislav Petkov
2024-12-05 6:25 ` Nikunj A. Dadhania
2024-12-03 9:00 ` [PATCH v15 03/13] x86/sev: Add Secure TSC support for SNP guests Nikunj A Dadhania
2024-12-05 11:55 ` Borislav Petkov
2024-12-06 4:19 ` Nikunj A. Dadhania
2024-12-16 16:06 ` Tom Lendacky
2024-12-17 6:12 ` Nikunj A Dadhania
2025-01-04 20:26 ` Francesco Lavra
2025-01-06 4:34 ` Nikunj A. Dadhania
2024-12-03 9:00 ` [PATCH v15 04/13] x86/sev: Change TSC MSR behavior for Secure TSC enabled guests Nikunj A Dadhania
2024-12-09 15:57 ` Borislav Petkov
2024-12-10 5:02 ` Nikunj A. Dadhania
2024-12-10 11:43 ` Borislav Petkov
2024-12-10 16:44 ` Nikunj A Dadhania
2024-12-10 14:29 ` Tom Lendacky
2024-12-10 16:59 ` Nikunj A Dadhania
2024-12-11 19:00 ` Borislav Petkov
2024-12-11 22:01 ` Tom Lendacky
2024-12-11 22:22 ` Borislav Petkov
2024-12-11 22:43 ` Tom Lendacky
2024-12-03 9:00 ` [PATCH v15 05/13] x86/sev: Prevent RDTSC/RDTSCP interception " Nikunj A Dadhania
2024-12-10 11:53 ` Borislav Petkov
2024-12-03 9:00 ` Nikunj A Dadhania [this message]
2024-12-10 12:11 ` [PATCH v15 06/13] x86/sev: Prevent GUEST_TSC_FREQ MSR " Borislav Petkov
2024-12-10 17:13 ` Nikunj A Dadhania
2024-12-10 17:18 ` Borislav Petkov
2024-12-12 4:53 ` Nikunj A. Dadhania
2024-12-17 10:57 ` Borislav Petkov
2024-12-18 5:20 ` Nikunj A. Dadhania
2024-12-24 11:53 ` Borislav Petkov
2025-01-01 8:44 ` Nikunj A. Dadhania
2025-01-01 16:10 ` Borislav Petkov
2025-01-02 5:03 ` Nikunj A. Dadhania
2025-01-02 9:07 ` Borislav Petkov
2025-01-02 9:30 ` Nikunj A. Dadhania
2025-01-02 14:45 ` Tom Lendacky
2025-01-02 14:54 ` Borislav Petkov
2024-12-10 17:22 ` Tom Lendacky
2024-12-03 9:00 ` [PATCH v15 07/13] x86/sev: Mark Secure TSC as reliable clocksource Nikunj A Dadhania
2024-12-11 20:32 ` Borislav Petkov
2024-12-12 5:07 ` Nikunj A Dadhania
2024-12-03 9:00 ` [PATCH v15 08/13] x86/cpu/amd: Do not print FW_BUG for Secure TSC Nikunj A Dadhania
2024-12-17 11:10 ` Borislav Petkov
2024-12-18 5:21 ` Nikunj A. Dadhania
2024-12-03 9:00 ` [PATCH v15 09/13] tsc: Use the GUEST_TSC_FREQ MSR for discovering TSC frequency Nikunj A Dadhania
2024-12-16 16:31 ` Tom Lendacky
2024-12-17 6:27 ` Nikunj A Dadhania
2024-12-17 7:05 ` Tom Lendacky
2024-12-17 7:57 ` Nikunj A. Dadhania
2024-12-30 11:29 ` Borislav Petkov
2025-01-01 8:56 ` Nikunj A. Dadhania
2025-01-01 16:15 ` Borislav Petkov
2025-01-02 5:10 ` Nikunj A. Dadhania
2025-01-02 9:17 ` Borislav Petkov
2025-01-02 10:01 ` Nikunj A. Dadhania
2025-01-02 10:45 ` Borislav Petkov
2025-01-02 13:10 ` Nikunj A. Dadhania
2025-01-03 12:04 ` Borislav Petkov
2025-01-03 13:59 ` Nikunj A. Dadhania
2025-01-04 10:28 ` Borislav Petkov
2024-12-03 9:00 ` [PATCH v15 10/13] tsc: Upgrade TSC clocksource rating Nikunj A Dadhania
2024-12-30 11:36 ` Borislav Petkov
2025-01-02 5:20 ` Nikunj A. Dadhania
2025-01-02 9:32 ` Borislav Petkov
2025-01-03 10:09 ` Nikunj A. Dadhania
2025-01-03 12:06 ` Borislav Petkov
2025-01-03 14:03 ` Nikunj A. Dadhania
2024-12-03 9:00 ` [PATCH v15 11/13] tsc: Switch to native sched clock Nikunj A Dadhania
2024-12-03 9:00 ` [PATCH v15 12/13] x86/kvmclock: Abort SecureTSC enabled guest when kvmclock is selected Nikunj A Dadhania
2024-12-16 16:36 ` Tom Lendacky
2024-12-30 17:04 ` Borislav Petkov
2025-01-01 9:44 ` Nikunj A. Dadhania
2025-01-01 16:19 ` Borislav Petkov
2025-01-02 5:34 ` Nikunj A. Dadhania
2025-01-02 9:25 ` Borislav Petkov
2025-01-02 10:06 ` Nikunj A. Dadhania
2024-12-03 9:00 ` [PATCH v15 13/13] x86/sev: Allow Secure TSC feature for SNP guests Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241203090045.942078-7-nikunj@amd.com \
--to=nikunj@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pgonda@google.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox