From: Andrew Jones <andrew.jones@linux.dev>
To: "Clément Léger" <cleger@rivosinc.com>
Cc: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
Andrew Jones <ajones@ventanamicro.com>,
Anup Patel <apatel@ventanamicro.com>,
Atish Patra <atishp@rivosinc.com>
Subject: Re: [kvm-unit-tests PATCH v6 4/5] riscv: lib: Add SBI SSE extension definitions
Date: Wed, 15 Jan 2025 13:06:56 +0100 [thread overview]
Message-ID: <20250115-ce8e8a312ade5e6c362d514d@orel> (raw)
In-Reply-To: <20250110111247.2963146-5-cleger@rivosinc.com>
On Fri, Jan 10, 2025 at 12:12:43PM +0100, Clément Léger wrote:
> Add SBI SSE extension definitions in sbi.h
>
> Signed-off-by: Clément Léger <cleger@rivosinc.com>
> ---
> lib/riscv/asm/sbi.h | 89 +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 89 insertions(+)
>
> diff --git a/lib/riscv/asm/sbi.h b/lib/riscv/asm/sbi.h
> index 98a9b097..83bdfb82 100644
> --- a/lib/riscv/asm/sbi.h
> +++ b/lib/riscv/asm/sbi.h
> @@ -11,6 +11,11 @@
> #define SBI_ERR_ALREADY_AVAILABLE -6
> #define SBI_ERR_ALREADY_STARTED -7
> #define SBI_ERR_ALREADY_STOPPED -8
> +#define SBI_ERR_NO_SHMEM -9
> +#define SBI_ERR_INVALID_STATE -10
> +#define SBI_ERR_BAD_RANGE -11
> +#define SBI_ERR_TIMEOUT -12
> +#define SBI_ERR_IO -13
We need SBI_ERR_DENIED_LOCKED too, but I guess that can be added with the
FWFT extension.
>
> #ifndef __ASSEMBLY__
> #include <cpumask.h>
> @@ -23,6 +28,7 @@ enum sbi_ext_id {
> SBI_EXT_SRST = 0x53525354,
> SBI_EXT_DBCN = 0x4442434E,
> SBI_EXT_SUSP = 0x53555350,
> + SBI_EXT_SSE = 0x535345,
> };
>
> enum sbi_ext_base_fid {
> @@ -71,6 +77,89 @@ enum sbi_ext_dbcn_fid {
> SBI_EXT_DBCN_CONSOLE_WRITE_BYTE,
> };
>
> +enum sbi_ext_sse_fid {
> + SBI_EXT_SSE_READ_ATTRS = 0,
> + SBI_EXT_SSE_WRITE_ATTRS,
> + SBI_EXT_SSE_REGISTER,
> + SBI_EXT_SSE_UNREGISTER,
> + SBI_EXT_SSE_ENABLE,
> + SBI_EXT_SSE_DISABLE,
> + SBI_EXT_SSE_COMPLETE,
> + SBI_EXT_SSE_INJECT,
> + SBI_EXT_SSE_HART_UNMASK,
> + SBI_EXT_SSE_HART_MASK,
> +};
> +
> +/* SBI SSE Event Attributes. */
> +enum sbi_sse_attr_id {
> + SBI_SSE_ATTR_STATUS = 0x00000000,
> + SBI_SSE_ATTR_PRIORITY = 0x00000001,
> + SBI_SSE_ATTR_CONFIG = 0x00000002,
> + SBI_SSE_ATTR_PREFERRED_HART = 0x00000003,
> + SBI_SSE_ATTR_ENTRY_PC = 0x00000004,
> + SBI_SSE_ATTR_ENTRY_ARG = 0x00000005,
> + SBI_SSE_ATTR_INTERRUPTED_SEPC = 0x00000006,
> + SBI_SSE_ATTR_INTERRUPTED_FLAGS = 0x00000007,
> + SBI_SSE_ATTR_INTERRUPTED_A6 = 0x00000008,
> + SBI_SSE_ATTR_INTERRUPTED_A7 = 0x00000009,
> +};
> +
> +#define SBI_SSE_ATTR_STATUS_STATE_OFFSET 0
> +#define SBI_SSE_ATTR_STATUS_STATE_MASK 0x3
> +#define SBI_SSE_ATTR_STATUS_PENDING_OFFSET 2
> +#define SBI_SSE_ATTR_STATUS_INJECT_OFFSET 3
> +
> +#define SBI_SSE_ATTR_CONFIG_ONESHOT BIT(0)
> +
> +#define SBI_SSE_ATTR_INTERRUPTED_FLAGS_SSTATUS_SPP BIT(0)
> +#define SBI_SSE_ATTR_INTERRUPTED_FLAGS_SSTATUS_SPIE BIT(1)
> +#define SBI_SSE_ATTR_INTERRUPTED_FLAGS_HSTATUS_SPV BIT(2)
> +#define SBI_SSE_ATTR_INTERRUPTED_FLAGS_HSTATUS_SPVP BIT(3)
> +
> +enum sbi_sse_state {
> + SBI_SSE_STATE_UNUSED = 0,
> + SBI_SSE_STATE_REGISTERED = 1,
> + SBI_SSE_STATE_ENABLED = 2,
> + SBI_SSE_STATE_RUNNING = 3,
> +};
> +
> +/* SBI SSE Event IDs. */
> +/* Range 0x00000000 - 0x0000ffff */
> +#define SBI_SSE_EVENT_LOCAL_HIGH_PRIO_RAS 0x00000000
> +#define SBI_SSE_EVENT_LOCAL_DOUBLE_TRAP 0x00000001
> +#define SBI_SSE_EVENT_LOCAL_PLAT_0_START 0x00004000
> +#define SBI_SSE_EVENT_LOCAL_PLAT_0_END 0x00007fff
> +
> +#define SBI_SSE_EVENT_GLOBAL_HIGH_PRIO_RAS 0x00008000
> +#define SBI_SSE_EVENT_GLOBAL_PLAT_0_START 0x0000c000
> +#define SBI_SSE_EVENT_GLOBAL_PLAT_0_END 0x0000ffff
> +
> +/* Range 0x00010000 - 0x0001ffff */
> +#define SBI_SSE_EVENT_LOCAL_PMU_OVERFLOW 0x00010000
> +#define SBI_SSE_EVENT_LOCAL_PLAT_1_START 0x00014000
> +#define SBI_SSE_EVENT_LOCAL_PLAT_1_END 0x00017fff
> +#define SBI_SSE_EVENT_GLOBAL_PLAT_1_START 0x0001c000
> +#define SBI_SSE_EVENT_GLOBAL_PLAT_1_END 0x0001ffff
> +
> +/* Range 0x00100000 - 0x0010ffff */
> +#define SBI_SSE_EVENT_LOCAL_LOW_PRIO_RAS 0x00100000
> +#define SBI_SSE_EVENT_LOCAL_PLAT_2_START 0x00104000
> +#define SBI_SSE_EVENT_LOCAL_PLAT_2_END 0x00107fff
> +#define SBI_SSE_EVENT_GLOBAL_LOW_PRIO_RAS 0x00108000
> +#define SBI_SSE_EVENT_GLOBAL_PLAT_2_START 0x0010c000
> +#define SBI_SSE_EVENT_GLOBAL_PLAT_2_END 0x0010ffff
> +
> +/* Range 0xffff0000 - 0xffffffff */
> +#define SBI_SSE_EVENT_LOCAL_SOFTWARE 0xffff0000
> +#define SBI_SSE_EVENT_LOCAL_PLAT_3_START 0xffff4000
> +#define SBI_SSE_EVENT_LOCAL_PLAT_3_END 0xffff7fff
> +#define SBI_SSE_EVENT_GLOBAL_SOFTWARE 0xffff8000
> +#define SBI_SSE_EVENT_GLOBAL_PLAT_3_START 0xffffc000
> +#define SBI_SSE_EVENT_GLOBAL_PLAT_3_END 0xffffffff
> +
> +#define SBI_SSE_EVENT_PLATFORM_BIT BIT(14)
> +#define SBI_SSE_EVENT_GLOBAL_BIT BIT(15)
> +
> struct sbiret {
> long error;
> long value;
> --
> 2.47.1
>
Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
next prev parent reply other threads:[~2025-01-15 12:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 11:12 [kvm-unit-tests PATCH v6 0/5] riscv: add SBI SSE extension tests Clément Léger
2025-01-10 11:12 ` [kvm-unit-tests PATCH v6 1/5] kbuild: allow multiple asm-offsets file to be generated Clément Léger
2025-01-10 11:12 ` [kvm-unit-tests PATCH v6 2/5] riscv: use asm-offsets to generate SBI_EXT_HSM values Clément Léger
2025-01-15 11:53 ` Andrew Jones
2025-01-10 11:12 ` [kvm-unit-tests PATCH v6 3/5] riscv: Add "-deps" handling for tests Clément Léger
2025-01-10 11:12 ` [kvm-unit-tests PATCH v6 4/5] riscv: lib: Add SBI SSE extension definitions Clément Léger
2025-01-15 12:06 ` Andrew Jones [this message]
2025-01-10 11:12 ` [kvm-unit-tests PATCH v6 5/5] riscv: sbi: Add SSE extension tests Clément Léger
2025-01-15 13:12 ` Andrew Jones
2025-01-13 14:11 ` [kvm-unit-tests PATCH v6 0/5] riscv: add SBI " Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115-ce8e8a312ade5e6c362d514d@orel \
--to=andrew.jones@linux.dev \
--cc=ajones@ventanamicro.com \
--cc=apatel@ventanamicro.com \
--cc=atishp@rivosinc.com \
--cc=cleger@rivosinc.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox