From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 139921993B2 for ; Thu, 16 Jan 2025 20:18:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737058737; cv=none; b=sfTzb3AySey201mmuq4EZHnkPnaGkIBPWwphbiXIoOEmpPVjqD/QVX2SpvYwO2WRMDtCDazyDtMddW+cYFTz4zyMG793jSWRp7M2To6HQT+mavA9gm4BCNj+YfrO56tgsaInzVUiYRhFrDqrguWZ8QJJro3fj/AHPMsBpZRfxSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737058737; c=relaxed/simple; bh=TW2t02hwCcCvA4dY7CqwLTCEluJxPrBR26gpeJGJ43c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XISH1JGyYll/78krmKRHxFcJ8HXuX2d3BLmBkdDrbDeslyeUPO/LiXDtY8ogGwhSrOq9HqbFwWEqytctHY7mazT5y9sKtynmAsTBhWuGfK6MTo3q/BwOe3PNp6cZOIw+T+eWYq1e2+Xa3t+9TnRxeRsWG4dA75hI93VzRq9zYnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=Z1gNKkW1; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Z1gNKkW1" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6dd15d03eacso14465556d6.0 for ; Thu, 16 Jan 2025 12:18:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1737058735; x=1737663535; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vjLKJevC2V7Xu5ADPJrgzXE+Cum0TiiT74cho1sXgi8=; b=Z1gNKkW14lxu8cW6U2PHwwOrjlbCi3tIzLd/2avcQf9Fuzn889VVOr9ybxwoUPqCuv UrlUDZ8tiO7rR5LLqvlFYQKbdmpXMfQ2XW0hBXvTBBMHgQAT0J45BMQfSK2jLIguAsar s1iLvXU2HwWnQagI5cNOnCWs4jUS0zi2csu0fYL1DffC/iEu8/cENDOofNAxmypsSlu0 K/Uu2XHu9BlJih4R30VaZ0vHZWqixXYRbwp1mt4wg92EH/TDgMvLXFUSCKgvSJEQSDOP bdSWOfiRkI69IZPm0fI1wPl4+xqHyU4z127BDzbHmrE+4WX19o3G+2Q6xszzjQ5/WiAR 4pLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737058735; x=1737663535; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vjLKJevC2V7Xu5ADPJrgzXE+Cum0TiiT74cho1sXgi8=; b=CfoUpx7+iuQyBpsYR0KgVG+c+UhmRQW65FQ5DmhgdRFrLOopruA2AMdenPBDjPR6HL AWLCRA0ea92uo5aBfN/cJadW46/RRv7y100/zND77b4tZiD1AN7e0aTNz+whnCnqx0bL lH1v8baauqiUNmeik9lbCSnNH94XIZvHf9E2NC+dEjCpNcXe9MkzYObKZyGv8qtidcLD CbRwNEhcMFDuBKWuKNyLi/PycUL+0nhaA8B8iO+PXYCdkAnsfIvcMKZIPiZPJvnXnDPg Oe9qNV8QQdU76NI8hZRReQ130B5d7ld6hKh2vuU4l/6kmJlFSkN9Lo2WzQCpl8mWHeaH ppJg== X-Forwarded-Encrypted: i=1; AJvYcCV26v1Y3D8T1GnosixtHKPtd3Btaxbd/GES02b1ggsj6tNgtZpZpSUy2L+zyuEwBDaFo3c=@vger.kernel.org X-Gm-Message-State: AOJu0YzGBghLq0jLqUdFuPRD5bISjoMRt9As2IWWBnGGfItzVWIFokPQ FCuy9z6ImT8tme4lCeAq9Pwk2B56bOcl6GwtXWS4wHE/fY+aaUReuTG21nGML4A= X-Gm-Gg: ASbGncv1rQM/PlNlGC9EJaTb10o3Okb5oHU/sBisc0qsxopTxuJqeHnLtm28SnIZT8Y pNZmbZUvvMUIz1jATxkn/hrzOpYlYYrVOZvR8WOZQOnPN0MMhrLOyPoE0PSmHQ4a8g+UvSRhoVB aBGXMz6cF8K4WJSbi8wVN8Sy1J3i6SpgIfW7cYqqSleLX+9RRQjAlTlJy6w3NkYpobSDQcqoIWI k3g7mnJFOuVLoH5kBvIxU5OmjUMdAetGSlBowUX3n0AxlKcSmhuvByonVo/qTGUKUDm8Le7dBMN UA0vTNn5f4luy/LztymvQG4K/j5ixQ== X-Google-Smtp-Source: AGHT+IGiuhJCb6CE3xcrJekt3qGHV8KtpIud5ATr1ePaT30zfzK6ww+BnPBnVPMzNC6cTFY+JSWjmQ== X-Received: by 2002:a05:6214:20a2:b0:6e1:715f:cdf5 with SMTP id 6a1803df08f44-6e192ca312amr104688286d6.15.1737058735081; Thu, 16 Jan 2025 12:18:55 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6e1afce4695sm3441426d6.104.2025.01.16.12.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 12:18:54 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1tYWKL-00000002y1X-3wBD; Thu, 16 Jan 2025 16:18:53 -0400 Date: Thu, 16 Jan 2025 16:18:53 -0400 From: Jason Gunthorpe To: Leon Romanovsky Cc: Robin Murphy , Jens Axboe , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Randy Dunlap Subject: Re: [PATCH v5 07/17] dma-mapping: Implement link/unlink ranges API Message-ID: <20250116201853.GE674319@ziepe.ca> References: <20250115083340.GL3146852@unreal> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250115083340.GL3146852@unreal> On Wed, Jan 15, 2025 at 10:33:40AM +0200, Leon Romanovsky wrote: > > > + do { > > > + phys_addr_t phys; > > > + size_t len; > > > + > > > + phys = iommu_iova_to_phys(domain, addr); > > > + if (WARN_ON(!phys)) > > > + continue; > > > > Infinite WARN_ON loop, nice. > > No problem, will change it to WARN_ON_ONCE. I think the other point is that the addr doesn't increase, so this loop will lock up. Possibly just do return? I suppose something is hopelessly corrupted if we ever hit this.. Jason