From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D4621E0E0A for ; Mon, 20 Jan 2025 14:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737382804; cv=none; b=vB9qTbMB5v6nsEH7nKMhKPmNv6neWK1/71bxqGWdbr4dHdQv6M1Wj5Vf3+vqg68mlnqxXdpEQ4KWZI0UF9eH0Sxsqdx1zL97huR1TSNGklMkFGTEnHGpdj+s/x92Wo3Mv6dhzDU12lUUcgwvYGUoG6WqB9hxT5oiG+CrkRTrrxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737382804; c=relaxed/simple; bh=ChimlzVgnnRdEx0IbwOEzpVywHcES5IyZTAkGygkZMk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JqWC/KNf8ahr5Eplj7eMpDU7ghjKawDPFUJWJ5Rr5qtpdeRVIF0xMqx3bVjmduIS+pnzXLYBEPJk9q3ZrodAxc/m6DQ6r87vAcQygFJvEQG2YQUpQ58zqtzcGMFzUvDLmCx1iNFt6qYJZ4ILmKx8Gsp9tUfwwY5OKZncbT/kmwU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=UVXBebsp; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="UVXBebsp" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7b8618be68bso370733585a.3 for ; Mon, 20 Jan 2025 06:20:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1737382802; x=1737987602; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nJYVtS2wyp4YmPXThKgYxTKEqaWqBzZ28kCjv5DfTK0=; b=UVXBebspd4Gkrbdv7VJxo0G3Dt6moz2PcgZu99UxmpsGAOTjf9hfrwvRAL8lSrDosi BYhiFtVyX8cVzt9gIeYi2wsaEpgIdxzu3A1Dia/7fyQqKSx6bvg7zPGkLcNZtwv8laeB ds2QBssEGW2ZuuRdiTDukMrGMTSizd82mR5yR7+o4uk8V12ivposSq5ySWuXDQv3sjr6 NddstMpXwWgarivrHwJsnAR7WEWIXGnPNf1VxhXOLEikw+vtYZVTV8K2M76xOu5AKwRr kAXaHEdXPYTuHMJAVGNN0lHBKunMdLZj/sDYE86O53HSV/kTCGmXdgfksBJxTyDaYVoI hcVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737382802; x=1737987602; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nJYVtS2wyp4YmPXThKgYxTKEqaWqBzZ28kCjv5DfTK0=; b=sbKFOwW2vpPTSNjRcOJFJj32tVhTmuhugTg0U+va0Cqcy1m2RgAWAvmP7L5A9mJyT8 j91FZGsRTh6fJm/pAOQCYd42jeKrblz6ad4igTsK2/Q1QA2Je8yERTh+BMMgineviwcz X0HsHzGl/3WwuwfobqS9p+SdHnawZB4pUrKTp0QPFQqDCwYyPdCLCpYVKxt7kP/u++PY ydkl1z726MKDdt3LqlBkuaqhALuG5bmHsRuFUfs8w+cl4kdmuqDtj+L5hlYMY7GWynai A9lTXpjELX2KStWs4SQ31hnsMGuzQrveo+Zy0dGdFwVc17kO/dmBpBms10DVbNwJLJjE L2+w== X-Forwarded-Encrypted: i=1; AJvYcCXSRmmVtMS6LRQC1XA5taOX421gOSIT8/sH6ZuJnaXY0e27mnPD9ewbt5KjNw5jaZwnvnA=@vger.kernel.org X-Gm-Message-State: AOJu0YyWTWiQ9zizuZC4b30RHGEJzyvhXOMVFsHMYqvyGy46lkxXNATq RhL/a6UAtmRjomjwlVbkrFAcRMcOZMUgvOhstNzByTtS3/1Pw5a6nDFkJm9Wx/I= X-Gm-Gg: ASbGncsZC1d8fFNm15C+rIJDvGwtU0co5KmTfeOS/rzGCsABwZR9TNBP8WYuCEThlb4 buOARNZO7ptY2rrRKWxeG80y/HTNOQdSPT+rQcm4I+3u3qd8qsDR0J83sn+y1gv9p1ipFgQEddx G3DkZ0hBrEpHvuKMlD+ZpdsGRxMl1XZ48whsD7bV9CVGm7qEPOBkQUb/NQhdYKWJTMOK+lVx40T cgWrU9RSWdcr9sItoiKnuTtjiI5EiIJqJDS2IUKj8ss9+3EgSE503u0JehvctlqflimbY/P0LmX 9rlQqaFtt2PL6flvRpJe2Mf8Na2hElOtc0fIeJ45TXM= X-Google-Smtp-Source: AGHT+IEQfbHlAGgpHPfeCc+lyD5fWS//N7IJUpSAPNWDgqwoZI0jSTzrUMiH8syVCBErRhB4O4Vhqg== X-Received: by 2002:a05:620a:43a4:b0:7bc:ded5:888d with SMTP id af79cd13be357-7be63210578mr2197984585a.1.1737382802189; Mon, 20 Jan 2025 06:20:02 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7be614758b6sm447691685a.13.2025.01.20.06.20.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 06:20:01 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1tZsdF-00000003Pge-0aIb; Mon, 20 Jan 2025 10:20:01 -0400 Date: Mon, 20 Jan 2025 10:20:01 -0400 From: Jason Gunthorpe To: Nicolin Chen Cc: Yi Liu , will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com, tglx@linutronix.de, maz@kernel.org, alex.williamson@redhat.com, joro@8bytes.org, shuah@kernel.org, reinette.chatre@intel.com, eric.auger@redhat.com, yebin10@huawei.com, apatel@ventanamicro.com, shivamurthy.shastri@linutronix.de, bhelgaas@google.com, anna-maria@linutronix.de, yury.norov@gmail.com, nipun.gupta@amd.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, patches@lists.linux.dev, jean-philippe@linaro.org, mdf@kernel.org, mshavit@google.com, shameerali.kolothum.thodi@huawei.com, smostafa@google.com, ddutile@redhat.com Subject: Re: [PATCH RFCv2 06/13] iommufd: Make attach_handle generic Message-ID: <20250120142001.GL674319@ziepe.ca> References: <62ccc75d-3f30-4167-b9e1-21dd95a6631d@intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Jan 18, 2025 at 12:32:49PM -0800, Nicolin Chen wrote: > On Sat, Jan 18, 2025 at 04:23:22PM +0800, Yi Liu wrote: > > On 2025/1/11 11:32, Nicolin Chen wrote: > > > "attach_handle" was added exclusively for the iommufd_fault_iopf_handler() > > > used by IOPF/PRI use cases, along with the "fault_data". Now, the iommufd > > > version of sw_msi function will resue the attach_handle and fault_data for > > > a non-fault case. > > > > > > Move the attach_handle part out of the fault.c file to make it generic for > > > all cases. Simplify the remaining fault specific routine to attach/detach. > > > > I guess you can send it separately since both of our series need it. :) > > Jason, would you like to take this patch separately? I can send > it prior to two big series for a quick review after rc1. It'll > likely impact the vEVENTQ series too. If it helps you can put it in its own series and I will take it with pasid or vevent, which ever goes first Jason