Re: [PATCH v3 15/15] KVM: s390: remove the last user of page->index

[Claudio Imbrenda <imbrenda@linux.ibm.com>]

On Tue, 21 Jan 2025 15:44:37 +0100
Janosch Frank <frankja@linux.ibm.com> wrote:

> On 1/17/25 8:09 PM, Claudio Imbrenda wrote:
> > Shadow page tables use page->index to keep the g2 address of the guest
> > page table being shadowed.
> > 
> > Instead of keeping the information in page->index, split the address
> > and smear it over the 16-bit softbits areas of 4 PGSTEs.
> > 
> > This removes the last s390 user of page->index.
> > 
> > Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> > Reviewed-by: Steffen Eiden <seiden@linux.ibm.com>
> > ---
> >   arch/s390/include/asm/pgtable.h | 15 +++++++++++++++
> >   arch/s390/kvm/gaccess.c         |  6 ++++--
> >   arch/s390/mm/gmap.c             | 22 ++++++++++++++++++++--
> >   3 files changed, 39 insertions(+), 4 deletions(-)  
> 
> s/index/paddr/ or pgaddr?
> 
> I get that you're replacing index but you now have the opportunity to 
> choose an expressive name for this field/variable.

yes, makes sense