public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, frankja@linux.ibm.com,
	borntraeger@de.ibm.com, schlameuss@linux.ibm.com,
	david@redhat.com, willy@infradead.org, hca@linux.ibm.com,
	svens@linux.ibm.com, agordeev@linux.ibm.com, gor@linux.ibm.com,
	nrb@linux.ibm.com, nsg@linux.ibm.com, seanjc@google.com,
	seiden@linux.ibm.com, pbonzini@redhat.com
Subject: [PATCH v4 01/15] KVM: Do not restrict the size of KVM-internal memory regions
Date: Thu, 23 Jan 2025 15:46:13 +0100	[thread overview]
Message-ID: <20250123144627.312456-2-imbrenda@linux.ibm.com> (raw)
In-Reply-To: <20250123144627.312456-1-imbrenda@linux.ibm.com>

From: Sean Christopherson <seanjc@google.com>

Exempt KVM-internal memslots from the KVM_MEM_MAX_NR_PAGES restriction, as
the limit on the number of pages exists purely to play nice with dirty
bitmap operations, which use 32-bit values to index the bitmaps, and dirty
logging isn't supported for KVM-internal memslots.

Link: https://lore.kernel.org/all/20240802205003.353672-6-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
Reviewed-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
---
 virt/kvm/kvm_main.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index a8a84bf450f9..ee3f040a4891 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -1966,7 +1966,15 @@ static int kvm_set_memory_region(struct kvm *kvm,
 		return -EINVAL;
 	if (mem->guest_phys_addr + mem->memory_size < mem->guest_phys_addr)
 		return -EINVAL;
-	if ((mem->memory_size >> PAGE_SHIFT) > KVM_MEM_MAX_NR_PAGES)
+
+	/*
+	 * The size of userspace-defined memory regions is restricted in order
+	 * to play nice with dirty bitmap operations, which are indexed with an
+	 * "unsigned int".  KVM's internal memory regions don't support dirty
+	 * logging, and so are exempt.
+	 */
+	if (id < KVM_USER_MEM_SLOTS &&
+	    (mem->memory_size >> PAGE_SHIFT) > KVM_MEM_MAX_NR_PAGES)
 		return -EINVAL;
 
 	slots = __kvm_memslots(kvm, as_id);
-- 
2.48.1


  reply	other threads:[~2025-01-23 14:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23 14:46 [PATCH v4 00/15] KVM: s390: Stop using page->index and other things Claudio Imbrenda
2025-01-23 14:46 ` Claudio Imbrenda [this message]
2025-01-23 14:46 ` [PATCH v4 02/15] KVM: s390: wrapper for KVM_BUG Claudio Imbrenda
2025-01-23 14:46 ` [PATCH v4 03/15] KVM: s390: fake memslot for ucontrol VMs Claudio Imbrenda
2025-01-23 14:46 ` [PATCH v4 04/15] KVM: s390: selftests: fix ucontrol memory region test Claudio Imbrenda
2025-01-24 14:34   ` Christoph Schlameuss
2025-01-23 14:46 ` [PATCH v4 05/15] KVM: s390: move pv gmap functions into kvm Claudio Imbrenda
2025-01-27  8:06   ` Christoph Schlameuss
2025-01-23 14:46 ` [PATCH v4 06/15] KVM: s390: use __kvm_faultin_pfn() Claudio Imbrenda
2025-01-23 14:46 ` [PATCH v4 07/15] KVM: s390: get rid of gmap_fault() Claudio Imbrenda
2025-01-23 14:46 ` [PATCH v4 08/15] KVM: s390: get rid of gmap_translate() Claudio Imbrenda
2025-01-23 14:46 ` [PATCH v4 09/15] KVM: s390: move some gmap shadowing functions away from mm/gmap.c Claudio Imbrenda
2025-01-27  9:16   ` Christoph Schlameuss
2025-01-23 14:46 ` [PATCH v4 10/15] KVM: s390: stop using page->index for non-shadow gmaps Claudio Imbrenda
2025-01-27  9:26   ` Christoph Schlameuss
2025-01-23 14:46 ` [PATCH v4 11/15] KVM: s390: stop using lists to keep track of used dat tables Claudio Imbrenda
2025-01-23 14:46 ` [PATCH v4 12/15] KVM: s390: move gmap_shadow_pgt_lookup() into kvm Claudio Imbrenda
2025-01-27  9:33   ` Christoph Schlameuss
2025-01-23 14:46 ` [PATCH v4 13/15] KVM: s390: remove useless page->index usage Claudio Imbrenda
2025-01-27  9:34   ` Christoph Schlameuss
2025-01-23 14:46 ` [PATCH v4 14/15] KVM: s390: move PGSTE softbits Claudio Imbrenda
2025-01-27  9:35   ` Christoph Schlameuss
2025-01-23 14:46 ` [PATCH v4 15/15] KVM: s390: remove the last user of page->index Claudio Imbrenda
2025-01-27  9:36   ` Christoph Schlameuss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250123144627.312456-2-imbrenda@linux.ibm.com \
    --to=imbrenda@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    --cc=nsg@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=schlameuss@linux.ibm.com \
    --cc=seanjc@google.com \
    --cc=seiden@linux.ibm.com \
    --cc=svens@linux.ibm.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox