From: Stefan Hajnoczi <stefanha@redhat.com>
To: Israel Rukshin <israelr@nvidia.com>
Cc: Max Gurtovoy <mgurtovoy@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>, Parav Pandit <parav@nvidia.com>,
virtualization@lists.linux.dev, mst@redhat.com,
Linux-block <linux-block@vger.kernel.org>,
Nitzan Carmi <nitzanc@nvidia.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] virtio_blk: Add support for transport error recovery
Date: Thu, 30 Jan 2025 10:48:37 -0500 [thread overview]
Message-ID: <20250130154837.GB223554@fedora> (raw)
In-Reply-To: <1732690652-3065-3-git-send-email-israelr@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]
On Wed, Nov 27, 2024 at 08:57:32AM +0200, Israel Rukshin wrote:
> Add support for proper cleanup and re-initialization of virtio-blk devices
> during transport reset error recovery flow.
> This enhancement includes:
> - Pre-reset handler (reset_prepare) to perform device-specific cleanup
> - Post-reset handler (reset_done) to re-initialize the device
>
> These changes allow the device to recover from various reset scenarios,
> ensuring proper functionality after a reset event occurs.
> Without this implementation, the device cannot properly recover from
> resets, potentially leading to undefined behavior or device malfunction.
>
> This feature has been tested using PCI transport with Function Level
> Reset (FLR) as an example reset mechanism. The reset can be triggered
> manually via sysfs (echo 1 > /sys/bus/pci/devices/$PCI_ADDR/reset).
>
> Signed-off-by: Israel Rukshin <israelr@nvidia.com>
> Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
> drivers/block/virtio_blk.c | 28 +++++++++++++++++++++++++---
> 1 file changed, 25 insertions(+), 3 deletions(-)
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-01-30 15:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 6:57 [PATCH v2 0/2] Add Error Recovery support for Virtio PCI devices Israel Rukshin
2024-11-27 6:57 ` [PATCH 1/2] virtio_pci: Add support for PCIe Function Level Reset Israel Rukshin
2024-11-27 6:57 ` [PATCH 2/2] virtio_blk: Add support for transport error recovery Israel Rukshin
2025-01-30 15:48 ` Stefan Hajnoczi [this message]
2025-01-30 15:57 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2024-11-07 15:16 [PATCH 0/2] Add Error Recovery support for Virtio PCI devices Israel Rukshin
2024-11-07 15:17 ` [PATCH 2/2] virtio_blk: Add support for transport error recovery Israel Rukshin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250130154837.GB223554@fedora \
--to=stefanha@redhat.com \
--cc=israelr@nvidia.com \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=nitzanc@nvidia.com \
--cc=parav@nvidia.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox