From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BD17200BA9; Mon, 3 Feb 2025 11:09:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738580981; cv=none; b=OHW7M/3AQha2gDSP7Ll6Crmmc7CJs7WEv2vVeG+DRnzdUbJ8XNObArailei1mprxHkYEK5gxOR68p9yEHyfNkg2FujQ+LyGHxPZdUAvIYySSXVxN0WaRfjC3Yg8bouFsJPfv3hflDZETFVlMLOg5m/fF42rhqNPouxfwsjVMRh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738580981; c=relaxed/simple; bh=Soq1uLZt3ko9Dff3dPj50jjbJTQ3V9DCd0zHsJThs3U=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=agL4dvVpFdeN+jR5FSq/sNJbYIUY7xtc0YL8FMUTLy+M+KsgP3FMP2juo7eK8TH57ufCDPy9kaC79fzG6d/9VEgZiECriR8CQ/cYTlDu9j1yX81uqcBvi+GWSsuI9zCIKbHqmI1OIBGb4Yrno+gwoH5A4aQebrK+wyDgtAnMjWw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YmkH01cnbz6M4S4; Mon, 3 Feb 2025 19:07:24 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id D421A140A34; Mon, 3 Feb 2025 19:09:36 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 3 Feb 2025 12:09:35 +0100 Date: Mon, 3 Feb 2025 11:09:34 +0000 From: Jonathan Cameron To: Mauro Carvalho Chehab CC: Igor Mammedov , "Michael S . Tsirkin" , Shiju Jose , , , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , Ani Sinha , Cleber Rosa , Dongjiu Geng , Eduardo Habkost , Eric Blake , John Snow , Marcel Apfelbaum , "Markus Armbruster" , Michael Roth , "Paolo Bonzini" , Peter Maydell , Shannon Zhao , Yanan Wang , Zhao Liu , , Subject: Re: [PATCH v3 00/14] Change ghes to use HEST-based offsets and add support for error inject Message-ID: <20250203110934.000038d8@huawei.com> In-Reply-To: References: X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To frapeml500008.china.huawei.com (7.182.85.71) On Fri, 31 Jan 2025 18:42:41 +0100 Mauro Carvalho Chehab wrote: > Now that the ghes preparation patches were merged, let's add support > for error injection. > > On this series, the first 6 patches chang to the math used to calculate offsets at HEST > table and hardware_error firmware file, together with its migration code. Migration tested > with both latest QEMU released kernel and upstream, on both directions. > > The next patches add a new QAPI to allow injecting GHESv2 errors, and a script using such QAPI > to inject ARM Processor Error records. > > If I'm counting well, this is the 19th submission of my error inject patches. Looks good to me. All remaining trivial things are in the category of things to consider only if you are doing another spin. The code ends up how I'd like it at the end of the series anyway, just a question of the precise path to that state! Jonathan