* [PATCH v2] RISC-V: KVM: Optimize comments in kvm_riscv_vcpu_isa_disable_allowed
@ 2025-02-21 2:59 Chao Du
2025-02-21 8:48 ` Andrew Jones
2025-03-20 6:16 ` Anup Patel
0 siblings, 2 replies; 3+ messages in thread
From: Chao Du @ 2025-02-21 2:59 UTC (permalink / raw)
To: kvm, kvm-riscv, anup, atishp, paul.walmsley, palmer, aou
The comments for EXT_SVADE are a bit confusing. Optimize it to make it
more clear.
Signed-off-by: Chao Du <duchao@eswincomputing.com>
---
arch/riscv/kvm/vcpu_onereg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/kvm/vcpu_onereg.c b/arch/riscv/kvm/vcpu_onereg.c
index f6d27b59c641..43ee8e33ba23 100644
--- a/arch/riscv/kvm/vcpu_onereg.c
+++ b/arch/riscv/kvm/vcpu_onereg.c
@@ -203,7 +203,7 @@ static bool kvm_riscv_vcpu_isa_disable_allowed(unsigned long ext)
case KVM_RISCV_ISA_EXT_SVADE:
/*
* The henvcfg.ADUE is read-only zero if menvcfg.ADUE is zero.
- * Svade is not allowed to disable when the platform use Svade.
+ * Svade can't be disabled unless we support Svadu.
*/
return arch_has_hw_pte_young();
default:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] RISC-V: KVM: Optimize comments in kvm_riscv_vcpu_isa_disable_allowed
2025-02-21 2:59 [PATCH v2] RISC-V: KVM: Optimize comments in kvm_riscv_vcpu_isa_disable_allowed Chao Du
@ 2025-02-21 8:48 ` Andrew Jones
2025-03-20 6:16 ` Anup Patel
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Jones @ 2025-02-21 8:48 UTC (permalink / raw)
To: Chao Du; +Cc: kvm, kvm-riscv, anup, atishp, paul.walmsley, palmer, aou
On Fri, Feb 21, 2025 at 02:59:29AM +0000, Chao Du wrote:
> The comments for EXT_SVADE are a bit confusing. Optimize it to make it
> more clear.
nit: s/Optimize it to make it more clear./Clarify it./
>
> Signed-off-by: Chao Du <duchao@eswincomputing.com>
> ---
> arch/riscv/kvm/vcpu_onereg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kvm/vcpu_onereg.c b/arch/riscv/kvm/vcpu_onereg.c
> index f6d27b59c641..43ee8e33ba23 100644
> --- a/arch/riscv/kvm/vcpu_onereg.c
> +++ b/arch/riscv/kvm/vcpu_onereg.c
> @@ -203,7 +203,7 @@ static bool kvm_riscv_vcpu_isa_disable_allowed(unsigned long ext)
> case KVM_RISCV_ISA_EXT_SVADE:
> /*
> * The henvcfg.ADUE is read-only zero if menvcfg.ADUE is zero.
> - * Svade is not allowed to disable when the platform use Svade.
> + * Svade can't be disabled unless we support Svadu.
> */
> return arch_has_hw_pte_young();
> default:
> --
> 2.34.1
Otherwise,
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] RISC-V: KVM: Optimize comments in kvm_riscv_vcpu_isa_disable_allowed
2025-02-21 2:59 [PATCH v2] RISC-V: KVM: Optimize comments in kvm_riscv_vcpu_isa_disable_allowed Chao Du
2025-02-21 8:48 ` Andrew Jones
@ 2025-03-20 6:16 ` Anup Patel
1 sibling, 0 replies; 3+ messages in thread
From: Anup Patel @ 2025-03-20 6:16 UTC (permalink / raw)
To: Chao Du; +Cc: kvm, kvm-riscv, atishp, paul.walmsley, palmer, aou, Andrew Jones
On Fri, Feb 21, 2025 at 8:29 AM Chao Du <duchao@eswincomputing.com> wrote:
>
> The comments for EXT_SVADE are a bit confusing. Optimize it to make it
> more clear.
>
> Signed-off-by: Chao Du <duchao@eswincomputing.com>
Queued this patch for Linux-6.15.
I have taken care of Drew's comment.
Regards,
Anup
> ---
> arch/riscv/kvm/vcpu_onereg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kvm/vcpu_onereg.c b/arch/riscv/kvm/vcpu_onereg.c
> index f6d27b59c641..43ee8e33ba23 100644
> --- a/arch/riscv/kvm/vcpu_onereg.c
> +++ b/arch/riscv/kvm/vcpu_onereg.c
> @@ -203,7 +203,7 @@ static bool kvm_riscv_vcpu_isa_disable_allowed(unsigned long ext)
> case KVM_RISCV_ISA_EXT_SVADE:
> /*
> * The henvcfg.ADUE is read-only zero if menvcfg.ADUE is zero.
> - * Svade is not allowed to disable when the platform use Svade.
> + * Svade can't be disabled unless we support Svadu.
> */
> return arch_has_hw_pte_young();
> default:
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-20 6:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-21 2:59 [PATCH v2] RISC-V: KVM: Optimize comments in kvm_riscv_vcpu_isa_disable_allowed Chao Du
2025-02-21 8:48 ` Andrew Jones
2025-03-20 6:16 ` Anup Patel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox