From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [GIT PULL] KVM changes for Linux 6.14
Date: Wed, 26 Feb 2025 20:03:23 +0100 [thread overview]
Message-ID: <20250226190322.GL8995@redhat.com> (raw)
In-Reply-To: <20250226-portieren-staudamm-10823e224307@brauner>
Sorry, didn't have time to actually read this patch, but after a quick
glance...
On 02/26, Christian Brauner wrote:
>
> @@ -3949,7 +3955,7 @@ static int proc_task_readdir(struct file *file, struct dir_context *ctx)
> tid = (int)(intptr_t)file->private_data;
> file->private_data = NULL;
> for (task = first_tid(proc_pid(inode), tid, ctx->pos - 2, ns);
> - task;
> + task && !(task->flags & PF_USER_WORKER);
unless I am totally confused this looks "obviously wrong".
proc_task_readdir() should not stop if it sees a PF_USER_WORKER task, this
check should go into first_tid/next_tid.
Oleg.
next prev parent reply other threads:[~2025-02-26 19:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 16:37 [GIT PULL] KVM changes for Linux 6.14 Paolo Bonzini
2025-01-25 14:30 ` Marc Zyngier
2025-01-25 18:12 ` Linus Torvalds
2025-01-25 18:31 ` Linus Torvalds
2025-01-27 3:55 ` Eric W. Biederman
2025-01-26 14:20 ` Oleg Nesterov
2025-01-26 18:34 ` Linus Torvalds
2025-01-26 18:53 ` Oleg Nesterov
2025-01-26 19:03 ` Oleg Nesterov
2025-01-26 19:16 ` Linus Torvalds
2025-01-27 14:09 ` Oleg Nesterov
2025-01-27 15:15 ` Paolo Bonzini
2025-02-04 14:19 ` Christian Brauner
2025-02-04 16:05 ` Paolo Bonzini
2025-02-05 11:49 ` Christian Brauner
2025-02-05 16:12 ` Linus Torvalds
2025-02-26 12:14 ` Christian Brauner
2025-02-26 19:03 ` Oleg Nesterov [this message]
2025-02-27 8:15 ` Christian Brauner
2025-01-25 18:16 ` Linus Torvalds
2025-01-27 15:24 ` Sean Christopherson
2025-01-27 15:25 ` Paolo Bonzini
2025-01-25 18:30 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226190322.GL8995@redhat.com \
--to=oleg@redhat.com \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox