public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Naveen N Rao <naveen@kernel.org>,
	Kim Phillips <kim.phillips@amd.com>,
	 Tom Lendacky <thomas.lendacky@amd.com>,
	Alexey Kardashevskiy <aik@amd.com>,
	 Pankaj Gupta <pankaj.gupta@amd.com>
Subject: [PATCH v2 00/10] KVM: SVM: Attempt to cleanup SEV_FEATURES
Date: Wed, 26 Feb 2025 17:25:31 -0800	[thread overview]
Message-ID: <20250227012541.3234589-1-seanjc@google.com> (raw)

Try to address the worst of the issues that arise with guest controlled SEV
features (thanks AP creation)[1].  The most pressing issue is with DebugSwap,
as a misbehaving guest could clobber host DR masks (which should be relatively
benign?).

The other notable issue is that KVM doesn't guard against userspace manually
making a vCPU RUNNABLE after it has been DESTROYED (or after a failed CREATE).
This shouldn't be super problematic, as VMRUN is supposed to "only" fail if
the VMSA page is invalid, but passing a known bad PA to hardware isn't exactly
desirable.

[1] https://lore.kernel.org/all/Z7TSef290IQxQhT2@google.com

v2:
 - Collect reviews. [Tom, Pankaj]
 - Fix a changelog typo. [Tom]
 - Reject KVM_RUN, but don't terminate the guest if KVM attempts VMRUN
   with a bad VMSA. [Tom]
 - Fix a commment where DRs were incorreclty listed as Type-A when DebugSwap
   is disabled/unsupported. [Tom]

v1: https://lore.kernel.org/all/20250219012705.1495231-1-seanjc@google.com

Sean Christopherson (10):
  KVM: SVM: Save host DR masks on CPUs with DebugSwap
  KVM: SVM: Don't rely on DebugSwap to restore host DR0..DR3
  KVM: SVM: Refuse to attempt VRMUN if an SEV-ES+ guest has an invalid
    VMSA
  KVM: SVM: Don't change target vCPU state on AP Creation VMGEXIT error
  KVM: SVM: Require AP's "requested" SEV_FEATURES to match KVM's view
  KVM: SVM: Simplify request+kick logic in SNP AP Creation handling
  KVM: SVM: Use guard(mutex) to simplify SNP AP Creation error handling
  KVM: SVM: Mark VMCB dirty before processing incoming snp_vmsa_gpa
  KVM: SVM: Use guard(mutex) to simplify SNP vCPU state updates
  KVM: SVM: Invalidate "next" SNP VMSA GPA even on failure

 arch/x86/kvm/svm/sev.c | 218 +++++++++++++++++++----------------------
 arch/x86/kvm/svm/svm.c |  11 ++-
 arch/x86/kvm/svm/svm.h |   2 +-
 3 files changed, 109 insertions(+), 122 deletions(-)


base-commit: fed48e2967f402f561d80075a20c5c9e16866e53
-- 
2.48.1.711.g2feabab25a-goog


             reply	other threads:[~2025-02-27  1:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27  1:25 Sean Christopherson [this message]
2025-02-27  1:25 ` [PATCH v2 01/10] KVM: SVM: Save host DR masks on CPUs with DebugSwap Sean Christopherson
2025-02-27  1:25 ` [PATCH v2 02/10] KVM: SVM: Don't rely on DebugSwap to restore host DR0..DR3 Sean Christopherson
2025-02-27  1:25 ` [PATCH v2 03/10] KVM: SVM: Refuse to attempt VRMUN if an SEV-ES+ guest has an invalid VMSA Sean Christopherson
2025-02-27 16:03   ` Tom Lendacky
2025-02-27 16:56   ` Gupta, Pankaj
2025-02-27  1:25 ` [PATCH v2 04/10] KVM: SVM: Don't change target vCPU state on AP Creation VMGEXIT error Sean Christopherson
2025-02-27 10:25   ` Gupta, Pankaj
2025-02-27  1:25 ` [PATCH v2 05/10] KVM: SVM: Require AP's "requested" SEV_FEATURES to match KVM's view Sean Christopherson
2025-02-27  7:12   ` Gupta, Pankaj
2025-02-27 14:33     ` Sean Christopherson
2025-02-27 15:18       ` Gupta, Pankaj
2025-02-27 15:42         ` Sean Christopherson
2025-02-27  1:25 ` [PATCH v2 06/10] KVM: SVM: Simplify request+kick logic in SNP AP Creation handling Sean Christopherson
2025-02-27  1:25 ` [PATCH v2 07/10] KVM: SVM: Use guard(mutex) to simplify SNP AP Creation error handling Sean Christopherson
2025-02-27 16:51   ` Gupta, Pankaj
2025-02-27  1:25 ` [PATCH v2 08/10] KVM: SVM: Mark VMCB dirty before processing incoming snp_vmsa_gpa Sean Christopherson
2025-02-27  1:25 ` [PATCH v2 09/10] KVM: SVM: Use guard(mutex) to simplify SNP vCPU state updates Sean Christopherson
2025-02-27  1:25 ` [PATCH v2 10/10] KVM: SVM: Invalidate "next" SNP VMSA GPA even on failure Sean Christopherson
2025-03-05  1:05 ` [PATCH v2 00/10] KVM: SVM: Attempt to cleanup SEV_FEATURES Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250227012541.3234589-1-seanjc@google.com \
    --to=seanjc@google.com \
    --cc=aik@amd.com \
    --cc=kim.phillips@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naveen@kernel.org \
    --cc=pankaj.gupta@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox