public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	 Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	 "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	 Sean Christopherson <seanjc@google.com>,
	Juergen Gross <jgross@suse.com>,
	 "K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>,  Dexuan Cui <decui@microsoft.com>,
	Ajay Kaher <ajay.kaher@broadcom.com>,
	 Jan Kiszka <jan.kiszka@siemens.com>,
	Andy Lutomirski <luto@kernel.org>,
	 Peter Zijlstra <peterz@infradead.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	 John Stultz <jstultz@google.com>
Cc: linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev,
	 kvm@vger.kernel.org, virtualization@lists.linux.dev,
	 linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org,
	 Tom Lendacky <thomas.lendacky@amd.com>,
	Nikunj A Dadhania <nikunj@amd.com>
Subject: [PATCH v2 01/38] x86/tsc: Add a standalone helpers for getting TSC info from CPUID.0x15
Date: Wed, 26 Feb 2025 18:18:17 -0800	[thread overview]
Message-ID: <20250227021855.3257188-2-seanjc@google.com> (raw)
In-Reply-To: <20250227021855.3257188-1-seanjc@google.com>

Extract retrieval of TSC frequency information from CPUID into standalone
helpers so that TDX guest support and kvmlock can reuse the logic.  Provide
a version that includes the multiplier math as TDX in particular does NOT
want to use native_calibrate_tsc()'s fallback logic that derives the TSC
frequency based on CPUID.0x16 when the core crystal frequency isn't known.

Opportunsitically drop native_calibrate_tsc()'s "== 0" and "!= 0" check
in favor of the kernel's preferred style.

No functional change intended.

Signed-off-by: Sean Christopherson <seanjc@google.com>
---
 arch/x86/include/asm/tsc.h |  9 +++++
 arch/x86/kernel/tsc.c      | 67 +++++++++++++++++++++++++-------------
 2 files changed, 53 insertions(+), 23 deletions(-)

diff --git a/arch/x86/include/asm/tsc.h b/arch/x86/include/asm/tsc.h
index 94408a784c8e..a4d84f721775 100644
--- a/arch/x86/include/asm/tsc.h
+++ b/arch/x86/include/asm/tsc.h
@@ -28,6 +28,15 @@ static inline cycles_t get_cycles(void)
 }
 #define get_cycles get_cycles
 
+struct cpuid_tsc_info {
+	unsigned int denominator;
+	unsigned int numerator;
+	unsigned int crystal_khz;
+	unsigned int tsc_khz;
+};
+extern int cpuid_get_tsc_info(struct cpuid_tsc_info *info);
+extern int cpuid_get_tsc_freq(struct cpuid_tsc_info *info);
+
 extern void tsc_early_init(void);
 extern void tsc_init(void);
 extern void mark_tsc_unstable(char *reason);
diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 34dec0b72ea8..93713eb81f52 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -655,46 +655,67 @@ static unsigned long quick_pit_calibrate(void)
 	return delta;
 }
 
+int cpuid_get_tsc_info(struct cpuid_tsc_info *info)
+{
+	unsigned int ecx_hz, edx;
+
+	memset(info, 0, sizeof(*info));
+
+	if (boot_cpu_data.cpuid_level < CPUID_LEAF_TSC)
+		return -ENOENT;
+
+	/* CPUID 15H TSC/Crystal ratio, plus optionally Crystal Hz */
+	cpuid(CPUID_LEAF_TSC, &info->denominator, &info->numerator, &ecx_hz, &edx);
+
+	if (!info->denominator || !info->numerator)
+		return -ENOENT;
+
+	/*
+	 * Note, some CPUs provide the multiplier information, but not the core
+	 * crystal frequency.  The multiplier information is still useful for
+	 * such CPUs, as the crystal frequency can be gleaned from CPUID.0x16.
+	 */
+	info->crystal_khz = ecx_hz / 1000;
+	return 0;
+}
+
+int cpuid_get_tsc_freq(struct cpuid_tsc_info *info)
+{
+	if (cpuid_get_tsc_info(info) || !info->crystal_khz)
+		return -ENOENT;
+
+	info->tsc_khz = info->crystal_khz * info->numerator / info->denominator;
+	return 0;
+}
+
 /**
  * native_calibrate_tsc - determine TSC frequency
  * Determine TSC frequency via CPUID, else return 0.
  */
 unsigned long native_calibrate_tsc(void)
 {
-	unsigned int eax_denominator, ebx_numerator, ecx_hz, edx;
-	unsigned int crystal_khz;
+	struct cpuid_tsc_info info;
 
 	if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
 		return 0;
 
-	if (boot_cpu_data.cpuid_level < CPUID_LEAF_TSC)
+	if (cpuid_get_tsc_info(&info))
 		return 0;
 
-	eax_denominator = ebx_numerator = ecx_hz = edx = 0;
-
-	/* CPUID 15H TSC/Crystal ratio, plus optionally Crystal Hz */
-	cpuid(CPUID_LEAF_TSC, &eax_denominator, &ebx_numerator, &ecx_hz, &edx);
-
-	if (ebx_numerator == 0 || eax_denominator == 0)
-		return 0;
-
-	crystal_khz = ecx_hz / 1000;
-
 	/*
 	 * Denverton SoCs don't report crystal clock, and also don't support
 	 * CPUID_LEAF_FREQ for the calculation below, so hardcode the 25MHz
 	 * crystal clock.
 	 */
-	if (crystal_khz == 0 &&
-			boot_cpu_data.x86_vfm == INTEL_ATOM_GOLDMONT_D)
-		crystal_khz = 25000;
+	if (!info.crystal_khz && boot_cpu_data.x86_vfm == INTEL_ATOM_GOLDMONT_D)
+		info.crystal_khz = 25000;
 
 	/*
 	 * TSC frequency reported directly by CPUID is a "hardware reported"
 	 * frequency and is the most accurate one so far we have. This
 	 * is considered a known frequency.
 	 */
-	if (crystal_khz != 0)
+	if (info.crystal_khz)
 		setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ);
 
 	/*
@@ -702,15 +723,15 @@ unsigned long native_calibrate_tsc(void)
 	 * clock, but we can easily calculate it to a high degree of accuracy
 	 * by considering the crystal ratio and the CPU speed.
 	 */
-	if (crystal_khz == 0 && boot_cpu_data.cpuid_level >= CPUID_LEAF_FREQ) {
+	if (!info.crystal_khz && boot_cpu_data.cpuid_level >= CPUID_LEAF_FREQ) {
 		unsigned int eax_base_mhz, ebx, ecx, edx;
 
 		cpuid(CPUID_LEAF_FREQ, &eax_base_mhz, &ebx, &ecx, &edx);
-		crystal_khz = eax_base_mhz * 1000 *
-			eax_denominator / ebx_numerator;
+		info.crystal_khz = eax_base_mhz * 1000 *
+			info.denominator / info.numerator;
 	}
 
-	if (crystal_khz == 0)
+	if (!info.crystal_khz)
 		return 0;
 
 	/*
@@ -727,10 +748,10 @@ unsigned long native_calibrate_tsc(void)
 	 * lapic_timer_period here to avoid having to calibrate the APIC
 	 * timer later.
 	 */
-	lapic_timer_period = crystal_khz * 1000 / HZ;
+	lapic_timer_period = info.crystal_khz * 1000 / HZ;
 #endif
 
-	return crystal_khz * ebx_numerator / eax_denominator;
+	return info.crystal_khz * info.numerator / info.denominator;
 }
 
 static unsigned long cpu_khz_from_cpuid(void)
-- 
2.48.1.711.g2feabab25a-goog


  reply	other threads:[~2025-02-27  2:19 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27  2:18 [PATCH v2 00/38] x86: Try to wrangle PV clocks vs. TSC Sean Christopherson
2025-02-27  2:18 ` Sean Christopherson [this message]
2025-02-27  2:18 ` [PATCH v2 02/38] x86/tsc: Add standalone helper for getting CPU frequency from CPUID Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 03/38] x86/tsc: Add helper to register CPU and TSC freq calibration routines Sean Christopherson
2025-03-04  4:17   ` Michael Kelley
2025-02-27  2:18 ` [PATCH v2 04/38] x86/sev: Mark TSC as reliable when configuring Secure TSC Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 05/38] x86/sev: Move check for SNP Secure TSC support to tsc_early_init() Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 06/38] x86/tdx: Override PV calibration routines with CPUID-based calibration Sean Christopherson
2025-02-27 13:15   ` Kirill A. Shutemov
2025-02-27  2:18 ` [PATCH v2 07/38] x86/acrn: Mark TSC frequency as known when using ACRN for calibration Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 08/38] clocksource: hyper-v: Register sched_clock save/restore iff it's necessary Sean Christopherson
2025-03-04  4:17   ` Michael Kelley
2025-03-04 17:39     ` Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 09/38] clocksource: hyper-v: Drop wrappers to sched_clock save/restore helpers Sean Christopherson
2025-03-04  4:17   ` Michael Kelley
2025-02-27  2:18 ` [PATCH v2 10/38] clocksource: hyper-v: Don't save/restore TSC offset when using HV sched_clock Sean Christopherson
2025-03-04  4:17   ` Michael Kelley
2025-02-27  2:18 ` [PATCH v2 11/38] x86/kvmclock: Setup kvmclock for secondary CPUs iff CONFIG_SMP=y Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 12/38] x86/kvm: Don't disable kvmclock on BSP in syscore_suspend() Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 13/38] x86/paravirt: Move handling of unstable PV clocks into paravirt_set_sched_clock() Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 14/38] x86/kvmclock: Move sched_clock save/restore helpers up in kvmclock.c Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 15/38] x86/xen/time: Nullify x86_platform's sched_clock save/restore hooks Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 16/38] x86/vmware: Nullify save/restore hooks when using VMware's sched_clock Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 17/38] x86/tsc: WARN if TSC sched_clock save/restore used with PV sched_clock Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 18/38] x86/paravirt: Pass sched_clock save/restore helpers during registration Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 19/38] x86/kvmclock: Move kvm_sched_clock_init() down in kvmclock.c Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 20/38] x86/xen/time: Mark xen_setup_vsyscall_time_info() as __init Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 21/38] x86/pvclock: Mark setup helpers and related various as __init/__ro_after_init Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 22/38] x86/pvclock: WARN if pvclock's valid_flags are overwritten Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 23/38] x86/kvmclock: Refactor handling of PVCLOCK_TSC_STABLE_BIT during kvmclock_init() Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 24/38] timekeeping: Resume clocksources before reading persistent clock Sean Christopherson
2025-02-27  7:48   ` Thomas Gleixner
2025-02-27  2:18 ` [PATCH v2 25/38] x86/kvmclock: Hook clocksource.suspend/resume when kvmclock isn't sched_clock Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 26/38] x86/kvmclock: WARN if wall clock is read while kvmclock is suspended Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 27/38] x86/kvmclock: Enable kvmclock on APs during onlining if kvmclock isn't sched_clock Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 28/38] x86/paravirt: Mark __paravirt_set_sched_clock() as __init Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 29/38] x86/paravirt: Plumb a return code into __paravirt_set_sched_clock() Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 30/38] x86/paravirt: Don't use a PV sched_clock in CoCo guests with trusted TSC Sean Christopherson
2025-02-27 13:17   ` Kirill A. Shutemov
2025-02-27  2:18 ` [PATCH v2 31/38] x86/tsc: Pass KNOWN_FREQ and RELIABLE as params to registration Sean Christopherson
2025-03-04  4:18   ` Michael Kelley
2025-02-27  2:18 ` [PATCH v2 32/38] x86/tsc: Rejects attempts to override TSC calibration with lesser routine Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 33/38] x86/kvmclock: Mark TSC as reliable when it's constant and nonstop Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 34/38] x86/kvmclock: Get CPU base frequency from CPUID when it's available Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 35/38] x86/kvmclock: Get TSC frequency from CPUID when its available Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 36/38] x86/kvmclock: Stuff local APIC bus period when core crystal freq comes from CPUID Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 37/38] x86/kvmclock: Use TSC for sched_clock if it's constant and non-stop Sean Christopherson
2025-02-27  2:18 ` [PATCH v2 38/38] x86/paravirt: kvmclock: Setup kvmclock early iff it's sched_clock Sean Christopherson
2025-02-28 11:23 ` [PATCH v2 00/38] x86: Try to wrangle PV clocks vs. TSC David Woodhouse
2025-03-03 20:53   ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250227021855.3257188-2-seanjc@google.com \
    --to=seanjc@google.com \
    --cc=ajay.kaher@broadcom.com \
    --cc=bp@alien8.de \
    --cc=daniel.lezcano@linaro.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jgross@suse.com \
    --cc=jstultz@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=kys@microsoft.com \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=nikunj@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=virtualization@lists.linux.dev \
    --cc=wei.liu@kernel.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox