From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE7581CAA99; Fri, 28 Feb 2025 09:19:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740734375; cv=none; b=Eqaq1BAvdBQiUfF+uBhSh+uFh2m/DRLX32Ph6eV5jS14psGgPScbbi8W2t2lVlE6Vh5C7Qv6583pSFgO2s1gYp+ZGWlTMjXdku2U77NDYD0+f1psoPbwvpaofS4qSWVqDt9yuALa20NQCwFnYTrLEprzrjC8Dflk1bqe8hQM9ZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740734375; c=relaxed/simple; bh=Vd3UmTfRLm+F06cpBFFtBHu6pRElLdw3agBFpIi7T2w=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PBaZZR1BEin0XXEqNTNG9st6NN1hoUcREccUPTG/FawgTKea6L7kN5ZTc5s6JFDLZsLA5np6692O6FFYwYs2NHew8IEjnwxHSZf6zq5jUdWoXndHjbffgKgM0/RiTGP/qDWJJoY66Ker22TsIVW+fcupDbz8ifhewFlO5Q1KmDs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Z42ff3zTmz6K9Sq; Fri, 28 Feb 2025 17:17:30 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 6F3ED140CF4; Fri, 28 Feb 2025 17:19:31 +0800 (CST) Received: from localhost (10.96.237.92) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 28 Feb 2025 10:19:17 +0100 Date: Fri, 28 Feb 2025 17:19:13 +0800 From: Jonathan Cameron To: Mauro Carvalho Chehab CC: Igor Mammedov , "Michael S . Tsirkin" , Shiju Jose , , , Ani Sinha , Dongjiu Geng , Paolo Bonzini , "Peter Maydell" , , Subject: Re: [PATCH v6 04/19] acpi/ghes: Cleanup the code which gets ghes ged state Message-ID: <20250228171913.00003442@huawei.com> In-Reply-To: References: X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500009.china.huawei.com (7.191.174.84) To frapeml500008.china.huawei.com (7.182.85.71) On Thu, 27 Feb 2025 17:00:42 +0100 Mauro Carvalho Chehab wrote: > Move the check logic into a common function and simplify the > code which checks if GHES is enabled and was properly setup. > > Signed-off-by: Mauro Carvalho Chehab > Reviewed-by: Jonathan Cameron > Reviewed-by: Igor Mammedov This is the only place Igor's tag seems to have a bonus space.. Probably worth tidying up if you are doing a v7 Jonathan