From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Kai Huang <kai.huang@intel.com>,
xuyun <xuyun_xy.xy@linux.alibaba.com>,
weizijie <zijie.wei@linux.alibaba.com>
Subject: [PATCH v5 1/3] KVM: x86: Isolate edge vs. level check in userspace I/O APIC route scanning
Date: Mon, 3 Mar 2025 17:33:33 -0800 [thread overview]
Message-ID: <20250304013335.4155703-2-seanjc@google.com> (raw)
In-Reply-To: <20250304013335.4155703-1-seanjc@google.com>
Extract and isolate the trigger mode check in kvm_scan_ioapic_routes() in
anticipation of moving destination matching logic to a common helper (for
userspace vs. in-kernel I/O APIC emulation).
No functional change intended.
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
arch/x86/kvm/irq_comm.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kvm/irq_comm.c b/arch/x86/kvm/irq_comm.c
index 8136695f7b96..866f84392797 100644
--- a/arch/x86/kvm/irq_comm.c
+++ b/arch/x86/kvm/irq_comm.c
@@ -424,10 +424,12 @@ void kvm_scan_ioapic_routes(struct kvm_vcpu *vcpu,
kvm_set_msi_irq(vcpu->kvm, entry, &irq);
- if (irq.trig_mode &&
- (kvm_apic_match_dest(vcpu, NULL, APIC_DEST_NOSHORT,
- irq.dest_id, irq.dest_mode) ||
- kvm_apic_pending_eoi(vcpu, irq.vector)))
+ if (!irq.trig_mode)
+ continue;
+
+ if (kvm_apic_match_dest(vcpu, NULL, APIC_DEST_NOSHORT,
+ irq.dest_id, irq.dest_mode) ||
+ kvm_apic_pending_eoi(vcpu, irq.vector))
__set_bit(irq.vector, ioapic_handled_vectors);
}
}
--
2.48.1.711.g2feabab25a-goog
next prev parent reply other threads:[~2025-03-04 1:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 1:33 [PATCH v5 0/3] KVM: x86: Optimize "stale" EOI bitmap exiting Sean Christopherson
2025-03-04 1:33 ` Sean Christopherson [this message]
2025-03-04 9:42 ` [PATCH v5 1/3] KVM: x86: Isolate edge vs. level check in userspace I/O APIC route scanning Huang, Kai
2025-04-10 22:46 ` Sean Christopherson
2025-04-10 22:55 ` Kai Huang
2025-03-04 1:33 ` [PATCH v5 2/3] KVM: x86: Add a helper to deduplicate I/O APIC EOI interception logic Sean Christopherson
2025-03-04 9:45 ` Huang, Kai
2025-03-04 1:33 ` [PATCH v5 3/3] KVM: x86: Rescan I/O APIC routes after EOI interception for old routing Sean Christopherson
2025-03-04 9:54 ` Huang, Kai
2025-04-25 22:09 ` [PATCH v5 0/3] KVM: x86: Optimize "stale" EOI bitmap exiting Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304013335.4155703-2-seanjc@google.com \
--to=seanjc@google.com \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=xuyun_xy.xy@linux.alibaba.com \
--cc=zijie.wei@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox